changefeedccl: add observability into kvfeed restarts

[andyyang890]

This code in (*kvfeed.kvFeed).run surrounding restarts due to schema changes does not have any observability in the form of either logs or metrics:

cockroach/pkg/ccl/changefeedccl/kvfeed/kv_feed.go

Lines 331 to 408 in df19639

	for i := 0; ; i++ {
	initialScan := i == 0
	initialScanOnly := f.endTime.EqOrdering(f.initialHighWater)
	scannedSpans, scannedTS, err := f.scanIfShould(ctx, initialScan, initialScanOnly, rangeFeedResumeFrontier.Frontier())
	if err != nil {
	return err
	}
	// We have scanned scannedSpans up to and including scannedTS. Advance frontier
	// for those spans. Note, since rangefeed start time is *exclusive* (that it, rangefeed
	// starts from timestamp.Next()), we advanced frontier to the scannedTS.
	for _, sp := range scannedSpans {
	if _, err := rangeFeedResumeFrontier.Forward(sp, scannedTS); err != nil {
	return err
	}
	}
	if initialScanOnly {
	if err := emitResolved(f.initialHighWater, jobspb.ResolvedSpan_EXIT); err != nil {
	return err
	}
	return errChangefeedCompleted
	}
	if err = f.runUntilTableEvent(ctx, rangeFeedResumeFrontier); err != nil {
	if tErr := (*errEndTimeReached)(nil); errors.As(err, &tErr) {
	if err := emitResolved(rangeFeedResumeFrontier.Frontier(), jobspb.ResolvedSpan_EXIT); err != nil {
	return err
	}
	return errChangefeedCompleted
	}
	return err
	}
	// Clear out checkpoint after the initial scan or rangefeed.
	if initialScan {
	f.checkpoint = nil
	f.checkpointTimestamp = hlc.Timestamp{}
	}
	highWater := rangeFeedResumeFrontier.Frontier()
	boundaryType := jobspb.ResolvedSpan_BACKFILL
	events, err := f.tableFeed.Peek(ctx, highWater.Next())
	if err != nil {
	return err
	}
	// Detect whether the event corresponds to a primary index change. Also
	// detect whether the change corresponds to any change in the set of visible
	// primary key columns.
	//
	// If a primary key is being changed and there are no changes in the
	// primary key's columns, this may be due to a column which was dropped
	// logically before and is presently being physically dropped.
	//
	// If is no change in the primary key columns, then a primary key change
	// should not trigger a failure in the `stop` policy because this change is
	// effectively invisible to consumers.
	primaryIndexChange, noColumnChanges := isPrimaryKeyChange(events, f.targets)
	if primaryIndexChange && (noColumnChanges ||
	f.schemaChangePolicy != changefeedbase.OptSchemaChangePolicyStop) {
	boundaryType = jobspb.ResolvedSpan_RESTART
	} else if f.schemaChangePolicy == changefeedbase.OptSchemaChangePolicyStop {
	boundaryType = jobspb.ResolvedSpan_EXIT
	}
	// Resolve all of the spans as a boundary if the policy indicates that
	// we should do so.
	if f.schemaChangePolicy != changefeedbase.OptSchemaChangePolicyNoBackfill ||
	boundaryType == jobspb.ResolvedSpan_RESTART {
	if err := emitResolved(highWater, boundaryType); err != nil {
	return err
	}
	}
	// Exit if the policy says we should.
	if boundaryType == jobspb.ResolvedSpan_RESTART || boundaryType == jobspb.ResolvedSpan_EXIT {
	return schemaChangeDetectedError{highWater.Next()}
	}
	}

One possible thing we could do is log a message right before the loop restarts explaining why the kvfeed is not exiting and/or why it needed to stop in the first place. We could also maybe have a metric counting the number of kvfeed restarts (possibly broken down by reason).

This would've been useful while investigating https://github.com/cockroachlabs/support/issues/2958.

Jira issue: CRDB-38982

Epic CRDB-37337

[blathers-crl]

cc @cockroachdb/cdc

[blathers-crl]

Based on the specified backports for linked PR #131244, I applied the following new label(s) to this issue: branch-release-23.1, branch-release-23.2, branch-release-24.1, branch-release-24.2. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches.

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}