Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admission: fix naming and units in exhausted metrics #124295

Closed
Tracked by #121574
aadityasondhi opened this issue May 16, 2024 · 1 comment
Closed
Tracked by #121574

admission: fix naming and units in exhausted metrics #124295

aadityasondhi opened this issue May 16, 2024 · 1 comment
Labels
A-admission-control C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-admission-control Admission Control

Comments

@aadityasondhi
Copy link
Collaborator

aadityasondhi commented May 16, 2024

Recently, there has been toil around the naming and the units used in the exhausted duration metrics. The elasticCPUNanosExhaustedDuration should really be called elasticCPUExhaustedDuration. The units for the following should be nanoseconds, instead of microseconds:

  • elasticCPUNanosExhaustedDuration
  • admission.granter.slots_exhausted_duration.kv
  • admission.granter.io_tokens_exhausted_duration.kv

Internal threads:

Jira issue: CRDB-38812

@aadityasondhi aadityasondhi added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-admission-control T-admission-control Admission Control labels May 16, 2024
@aadityasondhi
Copy link
Collaborator Author

Internally, we discussed that it may be cumbersome to do this. Even though there were no strict dependencies to the metric, it may cause confusion in any investigations that look at this metric using Advanced Debug or Grafana since the raw values will go up 1000x from micros to nanos.

Decided not to do this.

@aadityasondhi aadityasondhi closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-admission-control C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-admission-control Admission Control
Projects
None yet
Development

No branches or pull requests

1 participant