Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/ccl/testccl/sqlccl/sqlccl_test: TestShowCreateRedactableValues failed #124217

Closed
cockroach-teamcity opened this issue May 15, 2024 · 1 comment
Closed

pkg/ccl/testccl/sqlccl/sqlccl_test: TestShowCreateRedactableValues failed #124217

cockroach-teamcity opened this issue May 15, 2024 · 1 comment
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team X-duplicate Closed as a duplicate of another issue.
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 15, 2024 •
edited by cockroach-jira-scripts
Loading

pkg/ccl/testccl/sqlccl/sqlccl_test.TestShowCreateRedactableValues failed with artifacts on release-23.1 @ 59b75e6d8bfb37e202fb7e8a03aa3ee3e8da4f75:

Fatal error:

panic: ReturnType called on TypedExpr with empty typeAnnotation. Was the underlying Expr type-checked before asserting a type of TypedExpr? [recovered]
	panic: ReturnType called on TypedExpr with empty typeAnnotation. Was the underlying Expr type-checked before asserting a type of TypedExpr?

Stack:

goroutine 7379978 [running]:
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).recover(0xc0129208f0?, {0x74e5780, 0xc004f26450})
	github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:229 +0x6a
panic({0x58ee940, 0xc0005b4ee0})
	GOROOT/src/runtime/panic.go:884 +0x212
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.typeAnnotation.assertTyped(...)
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/expr.go:153
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Subquery).TypeCheck(0xc0054dc9f0?, {0x7503e38?, 0xc006886210?}, 0xc00f717500?, 0x74b76c8?)
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/type_check.go:1506 +0xe5
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*CastExpr).TypeCheck(0xc006886240, {0x74e5780, 0xc004f26450}, 0xc0054dc9d8, 0x0?)
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/type_check.go:586 +0x268
github.com/cockroachdb/cockroach/pkg/sql/catalog/schemaexpr.deserializeExprForFormatting({0x74e5780, 0xc004f26450}, {0x75b9130, 0xc00422d400}, {0xc012e834c0?, 0x3b?}, 0xc012e834c0?, 0x48000)
	github.com/cockroachdb/cockroach/pkg/sql/catalog/schemaexpr/expr.go:339 +0xd6
github.com/cockroachdb/cockroach/pkg/sql/catalog/schemaexpr.formatExprForDisplayImpl({0x74e5780, 0xc004f26450}, {0x75b9130?, 0xc00422d400?}, {0xc012e834c0?, 0xc012920f50?}, 0x99af05?, 0xc012570380, 0xc008cb6f3b?, 0x0)
	github.com/cockroachdb/cockroach/pkg/sql/catalog/schemaexpr/expr.go:294 +0x6b
github.com/cockroachdb/cockroach/pkg/sql/catalog/schemaexpr.FormatExprForDisplay(...)
	github.com/cockroachdb/cockroach/pkg/sql/catalog/schemaexpr/expr.go:251
github.com/cockroachdb/cockroach/pkg/sql.formatViewQueryTypesForDisplay.func1({0x7503230?, 0xc00d9b1c80})
	github.com/cockroachdb/cockroach/pkg/sql/show_create_clauses.go:271 +0x165
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*simpleVisitor).VisitPre(0xc0115d2798, {0x7503230, 0xc00d9b1c80})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2025 +0x46
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.WalkExpr({0x74b8e10, 0xc0115d2798}, {0x7503230?, 0xc00d9b1c80})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:831 +0x5a
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*SelectClause).walkStmt(0xc014b1a500, {0x74b8e10, 0xc0115d2798})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1702 +0x78b
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt({0x74b8e10, 0xc0115d2798}, {0x75119c0?, 0xc014b1a500})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010 +0x5d
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Select).walkStmt(0xc00e3db090, {0x74b8e10, 0xc0115d2798})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1626 +0x7d
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt({0x74b8e10, 0xc0115d2798}, {0x7511980?, 0xc00e3db090})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010 +0x5d
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*ParenSelect).walkStmt(0xc00ad1b468, {0x74b8e10?, 0xc0115d2798?})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1486 +0x3c
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt({0x74b8e10, 0xc0115d2798}, {0x7511400?, 0xc00ad1b468})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010 +0x5d
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Subquery).Walk(0xc00d9b1f80, {0x74b8e10, 0xc0115d2798})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:515 +0x5c
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.WalkExpr({0x74b8e10, 0xc0115d2798}, {0x7503e38?, 0xc00d9b1f80})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:834 +0x77
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*ComparisonExpr).Walk(0xc00e3db0e0, {0x74b8e10, 0xc0115d2798})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:192 +0x6a
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.WalkExpr({0x74b8e10, 0xc0115d2798}, {0x7503348?, 0xc00e3db0e0})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:834 +0x77
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*SelectClause).walkStmt(0xc014b1a5a0, {0x74b8e10, 0xc0115d2798})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1722 +0x135
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt({0x74b8e10, 0xc0115d2798}, {0x75119c0?, 0xc014b1a5a0})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010 +0x5d
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Select).walkStmt(0xc00e3db1d0, {0x74b8e10, 0xc0115d2798})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1626 +0x7d
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt({0x74b8e10, 0xc0115d2798}, {0x7511980?, 0xc00e3db1d0})
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010 +0x5d
github.com/cockroachdb/cockroach/pkg/sql/sem/tree.SimpleStmtVisit({0x7511980, 0xc00e3db1d0}, 0xc00f717040)
	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2057 +0x85
github.com/cockroachdb/cockroach/pkg/sql.formatViewQueryTypesForDisplay({0x74e5780?, 0xc004f26450}, 0xc0054dc9d8, 0xc012570380, {0x75b9130?, 0xc00422d400})
	github.com/cockroachdb/cockroach/pkg/sql/show_create_clauses.go:290 +0x1d6
github.com/cockroachdb/cockroach/pkg/sql.formatViewQueryForDisplay({0x74e5780, 0xc004f26450}, 0xc00b987380?, 0x203003?, {0x75b9130, 0xc00422d400}, {0x60, 0x4, 0x0, 0x1, ...})
	github.com/cockroachdb/cockroach/pkg/sql/show_create_clauses.go:175 +0x192
github.com/cockroachdb/cockroach/pkg/sql.ShowCreateView({0x74e5780, 0xc004f26450}, 0xc012921838?, 0x46115d?, 0x5e2c200?, {0x75b9130, 0xc00422d400}, 0x0)
	github.com/cockroachdb/cockroach/pkg/sql/show_create_clauses.go:144 +0x29f
github.com/cockroachdb/cockroach/pkg/sql.glob..func67({0x74e5780, 0xc004f26450}, 0xc0054dc640, {{0xc018fedbf0?, 0x65?}}, {0x7587680, 0xc003a45a20}, {0x7585018, 0xc00bcb8140}, {0x75b9130, ...}, ...)
	github.com/cockroachdb/cockroach/pkg/sql/crdb_internal.go:3482 +0x48d
github.com/cockroachdb/cockroach/pkg/sql.makeAllRelationsVirtualTableWithDescriptorIDIndex.func1.1({0x7587680?, 0xc003a45a20?}, {0x7585018?, 0xc00bcb8140?}, {0x75b9130?, 0xc00422d400?}, 0xc003a45a20?)
	github.com/cockroachdb/cockroach/pkg/sql/pg_catalog.go:1170 +0xcf
github.com/cockroachdb/cockroach/pkg/sql.forEachTableDescWithTableLookupInternalFromDescriptors({0x74e5780, 0xc004f26450}, 0xc0054dc640, {0x7587680, 0xc00bbc5760}, 0x1, 0x0?, {{0xc003002300}, {0xc003002380}, 0x5b717}, ...)
	github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:2667 +0x5a3
github.com/cockroachdb/cockroach/pkg/sql.forEachTableDescWithTableLookupInternal({0x74e5780, 0xc004f26450}, 0xc0054dc640, {0x7587680?, 0xc00bbc5760}, 0x7f03ab658620?, 0x40?, 0x7f03dd3663c8?)
	github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:2540 +0x145
github.com/cockroachdb/cockroach/pkg/sql.forEachTableDescWithTableLookup(...)
	github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:2511
github.com/cockroachdb/cockroach/pkg/sql.makeAllRelationsVirtualTableWithDescriptorIDIndex.func1({0x74e5780, 0xc004f26450}, 0xc0054dc640, {0x7587680, 0xc00bbc5760}, 0xc0111d4100)
	github.com/cockroachdb/cockroach/pkg/sql/pg_catalog.go:1168 +0x125
github.com/cockroachdb/cockroach/pkg/sql.(*virtualDefEntry).getPlanInfo.func1.1({0x74e5780, 0xc004f26450}, {0x74a9d80?, 0xc00d7e92a0})
	github.com/cockroachdb/cockroach/pkg/sql/virtual_schema.go:682 +0x196
github.com/cockroachdb/cockroach/pkg/sql.setupGenerator.func3({0x74e5780, 0xc004f26450})
	github.com/cockroachdb/cockroach/pkg/sql/virtual_table.go:127 +0x114
github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
	github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:470 +0x146
created by github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx
	github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:461 +0x43b
Log preceding fatal error 

*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:831
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*SelectClause).walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1702
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Select).walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1626
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*ParenSelect).walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1486
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Subquery).Walk
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:515
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.WalkExpr
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:834
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*ComparisonExpr).Walk
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:192
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.WalkExpr
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:834
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*SelectClause).walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1722
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.(*Select).walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:1626
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.walkStmt
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2010
*   | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.SimpleStmtVisit
*   | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/walk.go:2057
*   | github.com/cockroachdb/cockroach/pkg/sql.formatViewQueryTypesForDisplay
*   | 	github.com/cockroachdb/cockroach/pkg/sql/show_create_clauses.go:290
*   | github.com/cockroachdb/cockroach/pkg/sql.formatViewQueryForDisplay
*   | 	github.com/cockroachdb/cockroach/pkg/sql/show_create_clauses.go:175
*   | github.com/cockroachdb/cockroach/pkg/sql.ShowCreateView
*   | 	github.com/cockroachdb/cockroach/pkg/sql/show_create_clauses.go:144
*   | github.com/cockroachdb/cockroach/pkg/sql.glob..func67
*   | 	github.com/cockroachdb/cockroach/pkg/sql/crdb_internal.go:3482
*   | github.com/cockroachdb/cockroach/pkg/sql.makeAllRelationsVirtualTableWithDescriptorIDIndex.func1.1
*   | 	github.com/cockroachdb/cockroach/pkg/sql/pg_catalog.go:1170
*   | github.com/cockroachdb/cockroach/pkg/sql.forEachTableDescWithTableLookupInternalFromDescriptors
*   | 	github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:2667
*   | github.com/cockroachdb/cockroach/pkg/sql.forEachTableDescWithTableLookupInternal
*   | 	github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:2540
*   | github.com/cockroachdb/cockroach/pkg/sql.forEachTableDescWithTableLookup
*   | 	github.com/cockroachdb/cockroach/pkg/sql/information_schema.go:2511
* Wraps: (4) ReturnType called on TypedExpr with empty typeAnnotation. Was the underlying Expr type-checked before asserting a type of TypedExpr?
* Error types: (1) *withstack.withStack (2) *assert.withAssertionFailure (3) *withstack.withStack (4) *errutil.leafError
*

Parameters:

  • TAGS=bazel,gss,deadlock
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

Jira issue: CRDB-38777
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels May 15, 2024
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone May 15, 2024
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries May 15, 2024
@github-actions github-actions bot mentioned this issue May 17, 2024
Closed
@yuzefovich yuzefovich added the X-duplicate Closed as a duplicate of another issue. label May 21, 2024
@yuzefovich
Copy link
Member

dup of #112750

@github-project-automation github-project-automation bot moved this from Triage to Done in SQL Queries May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team X-duplicate Closed as a duplicate of another issue.
Projects
SQL Queries
Archived in project
Milestone
23.1
Development

No branches or pull requests
2 participants
@yuzefovich @cockroach-teamcity