Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: investigate whether session revival should be made available to UA clusters #116537

Open
Tracked by #116445
stevendanna opened this issue Dec 15, 2023 · 0 comments
Open
Tracked by #116445
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@stevendanna
Copy link
Collaborator

stevendanna commented Dec 15, 2023

Describe the problem

We currently gate session revival both on a non-public cluster setting and on whether we are in a secondary tenant. UA clusters will always be running in secondary tenant, making this secondary check less effective.

pkg/sql/conn_executor_exec.go:2754:79:		AllowSessionRevival.Get(&ex.server.cfg.Settings.SV) && !ex.server.cfg.Codec.ForSystemTenant(),
pkg/sql/session_revival_token.go:43:75:		AllowSessionRevival.Get(&p.ExecCfg().Settings.SV) && !p.ExecCfg().Codec.ForSystemTenant(),
pkg/sql/session_revival_token.go:79:77:	if !AllowSessionRevival.Get(&p.ExecCfg().Settings.SV) || p.ExecCfg().Codec.ForSystemTenant() {

This seems relatively minor to me since the tenant setting itself is SystemVisible, so users would have to go out of their way to enable this non-public setting.

Jira issue: CRDB-34662

@stevendanna stevendanna added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Dec 15, 2023
@stevendanna stevendanna changed the title sql: investigate whether session arrival should be made available to UA clusters sql: investigate whether session revival should be made available to UA clusters Dec 15, 2023
@stevendanna stevendanna added the T-sql-queries SQL Queries Team label Dec 18, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Dec 18, 2023
@yuzefovich yuzefovich added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-queries SQL Queries Team labels Dec 19, 2023
@yuzefovich yuzefovich removed this from SQL Queries Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
Status: Triage
Development

No branches or pull requests

2 participants