Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/ccl/importerccl/importerccl_test: TestImportMultiRegion failed #116049

Closed
cockroach-teamcity opened this issue Dec 11, 2023 · 3 comments
Closed
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-remote-execution An issue found only using Bazel Remote Execution function. O-robot Originated from a bot. T-testeng TestEng Team
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 11, 2023

pkg/ccl/importerccl/importerccl_test.TestImportMultiRegion failed on master @ 8f91e0324af0bd99cbfcc9d44ceeda45ad0960ec:

pkg/ccl/importerccl/importerccl_test/pkg/ccl/importerccl/ccl_test.go:72: (TestImportMultiRegion)
	NOTICE: .JobRegistry() called via implicit interface ApplicationLayerInterface;
HINT: consider using .ApplicationLayer().JobRegistry() instead.
TIP: consider replacing the test server initialization from:
    ts, ... := serverutils.StartServer(t, ...)
    defer ts.Stopper().Stop(...)
to:
    srv, ... := serverutils.StartServer(t, ...)
    defer srv.Stopper().Stop(...)
    ts := srv.ApplicationLayer()

See also: https://go.crdb.dev/p/testserver-and-cluster-virtualization

pkg/ccl/importerccl/importerccl_test/pkg/ccl/importerccl/ccl_test.go:72: (TestImportMultiRegion)
	NOTICE: .JobRegistry() called via implicit interface ApplicationLayerInterface;
HINT: consider using .ApplicationLayer().JobRegistry() instead.
TIP: consider replacing the test server initialization from:
    ts, ... := serverutils.StartServer(t, ...)
    defer ts.Stopper().Stop(...)
to:
    srv, ... := serverutils.StartServer(t, ...)
    defer srv.Stopper().Stop(...)
    ts := srv.ApplicationLayer()

See also: https://go.crdb.dev/p/testserver-and-cluster-virtualization

pkg/ccl/importerccl/importerccl_test/pkg/ccl/importerccl/ccl_test.go:72: (TestImportMultiRegion)
	NOTICE: .JobRegistry() called via implicit interface ApplicationLayerInterface;
HINT: consider using .ApplicationLayer().JobRegistry() instead.
TIP: consider replacing the test server initialization from:
    ts, ... := serverutils.StartServer(t, ...)
    defer ts.Stopper().Stop(...)
to:
    srv, ... := serverutils.StartServer(t, ...)
    defer srv.Stopper().Stop(...)
    ts := srv.ApplicationLayer()

See also: https://go.crdb.dev/p/testserver-and-cluster-virtualization
=== RUN   TestImportMultiRegion/avro
=== RUN   TestImportMultiRegion/avro/import-into-multi-region-global-to-multi-region-database
=== RUN   TestImportMultiRegion/avro/import-into-multi-region-regional-by-row-to-multi-region-database
=== RUN   TestImportMultiRegion/mysqldump
=== RUN   TestImportMultiRegion/avro/import-into-multi-region-regional-by-row-dupes
=== RUN   TestImportMultiRegion/avro/import-into-multi-region-regional-by-row-to-multi-region-database-wrong-value
=== RUN   TestImportMultiRegion/avro/import-into-multi-region-regional-by-row-with-enum-which-has-been-modified
=== RUN   TestImportMultiRegion/pgdump
=== RUN   TestImportMultiRegion/avro/import-create-using-multi-region-regional-by-table-to-multi-region-database
=== RUN   TestImportMultiRegion/avro/import-into-multi-region-regional-by-row-to-multi-region-database-concurrent-add-region
=== RUN   TestImportMultiRegion/avro/import-into-multi-region-regional-by-row-to-multi-region-database-concurrent-table-add
=== RUN   TestImportMultiRegion/avro/import-into-multi-region-regional-by-row-default-col-to-multi-region-database

Parameters:

  • attempt=1
  • race=true
  • run=2
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-34413

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Dec 11, 2023
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Dec 11, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Dec 11, 2023
@rickystewart
Copy link
Collaborator

Skipping in #116080

@mgartner mgartner added O-remote-execution An issue found only using Bazel Remote Execution function. and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Dec 11, 2023
@blathers-crl blathers-crl bot added the T-testeng TestEng Team label Dec 11, 2023
@mgartner mgartner removed this from SQL Queries Dec 11, 2023
Copy link

blathers-crl bot commented Dec 11, 2023

cc @cockroachdb/test-eng

@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Dec 11, 2023
@yuzefovich yuzefovich removed the T-sql-queries SQL Queries Team label Dec 12, 2023
@yuzefovich yuzefovich removed this from SQL Queries Dec 12, 2023
@renatolabs
Copy link
Contributor

Closing now that the test was skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-remote-execution An issue found only using Bazel Remote Execution function. O-robot Originated from a bot. T-testeng TestEng Team
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants