Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentry: type_desc.go:701: type × (223): referencing × 256 was dropped without dependency unlinking (1) Wraps: (2) keys: [sql.schema.validation_errors.read.backward_references.type] Wraps: (3) keys: ... #114109

Closed
cockroach-sentry opened this issue Nov 8, 2023 · 1 comment
Closed

Sentry: type_desc.go:701: type × (223): referencing × 256 was dropped without dependency unlinking (1) Wraps: (2) keys: [sql.schema.validation_errors.read.backward_references.type] Wraps: (3) keys: ... #114109

cockroach-sentry opened this issue Nov 8, 2023 · 1 comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report.

Comments

@cockroach-sentry
Copy link
Collaborator

cockroach-sentry commented Nov 8, 2023 •
edited by cockroach-jira-scripts
Loading

This issue was auto filed by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry Link: https://cockroach-labs.sentry.io/issues/4614919306/?referrer=webhooks_plugin

Panic Message:

type_desc.go:701: type × (223): referencing × 256 was dropped without dependency unlinking
(1)
Wraps: (2) keys: [sql.schema.validation_errors.read.backward_references.type]
Wraps: (3) keys: [sql.schema.validation_errors.read.backward_references.type]
Wraps: (4) attached stack trace
  -- stack trace:
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate.(*validationErrorAccumulator).decorate
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate/validate.go:253
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate.(*validationErrorAccumulator).Report
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate/validate.go:177
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/typedesc.(*immutable).ValidateBackReferences
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/typedesc/type_desc.go:701
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate.Validate.func3
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate/validate.go:105
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate.(*validationErrorAccumulator).validateDescriptorsAtLevel
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate/validate.go:193
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate.Validate
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate/validate.go:100
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).Validate
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/validate.go:36
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).finalizeDescriptors
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/descriptor.go:566
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.getDescriptorsByID
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/descriptor.go:203
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).getDescriptorByID
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/descriptor.go:88
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).getDescriptorByName
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/descriptor.go:336
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).GetObjectByName
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/object.go:53
  | github.com/cockroachdb/cockroach/pkg/sql.(*schemaResolver).LookupObject
  | 	github.com/cockroachdb/cockroach/pkg/sql/schema_resolver.go:118
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/resolver.ResolveExisting
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/resolver/resolver.go:390
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/resolver.ResolveExistingObject
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/resolver/resolver.go:198
  | github.com/cockroachdb/cockroach/pkg/sql.(*schemaResolver).ResolveType
  | 	github.com/cockroachdb/cockroach/pkg/sql/schema_resolver.go:262
  | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.ResolveType
  | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/type_name.go:164
  | github.com/cockroachdb/cockroach/pkg/sql.NewTableDesc
  | 	github.com/cockroachdb/cockroach/pkg/sql/create_table.go:1578
  | github.com/cockroachdb/cockroach/pkg/sql.newTableDesc.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/create_table.go:2349
  | github.com/cockroachdb/cockroach/pkg/sql.(*schemaResolver).runWithOptions
  | 	github.com/cockroachdb/cockroach/pkg/sql/schema_resolver.go:384
  | github.com/cockroachdb/cockroach/pkg/sql.newTableDesc
  | 	github.com/cockroachdb/cockroach/pkg/sql/create_table.go:2348
  | github.com/cockroachdb/cockroach/pkg/sql.(*createTableNode).startExec
  | 	github.com/cockroachdb/cockroach/pkg/sql/create_table.go:391
  | github.com/cockroachdb/cockroach/pkg/sql.startExec.func2
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan.go:518
  | github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visitInternal.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/walk.go:112
  | github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visitInternal
  | 	github.com/cockroachdb/cockroach/pkg/sql/walk.go:297
  | github.com/cockroachdb/cockroach/pkg/sql.(*planVisitor).visit
  | 	github.com/cockroachdb/cockroach/pkg/sql/walk.go:79
  | github.com/cockroachdb/cockroach/pkg/sql.walkPlan
  | 	github.com/cockroachdb/cockroach/pkg/sql/walk.go:43
  | github.com/cockroachdb/cockroach/pkg/sql.startExec
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan.go:521
  | github.com/cockroachdb/cockroach/pkg/sql.(*planNodeToRowSource).Start
  | 	github.com/cockroachdb/cockroach/pkg/sql/plan_node_to_row_source.go:166
  | github.com/cockroachdb/cockroach/pkg/sql/colexec.(*Columnarizer).Init
  | 	github.com/cockroachdb/cockroach/pkg/sql/colexec/columnarizer.go:187
  | github.com/cockroachdb/cockroach/pkg/sql/colflow.(*batchInfoCollector).init
  | 	github.com/cockroachdb/cockroach/pkg/sql/colflow/stats.go:92
Wraps: (5) type × (223)
Wraps: (6) assertion failure
Wraps: (7) attached stack trace
  -- stack trace:
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/typedesc.(*immutable).ValidateBackReferences
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/typedesc/type_desc.go:701
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate.Validate.func3
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate/validate.go:105
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate.(*validationErrorAccumulator).validateDescriptorsAtLevel
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate/validate.go:193
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate.Validate
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/internal/validate/validate.go:100
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).Validate
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/validate.go:36
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).finalizeDescriptors
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/descriptor.go:566
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.getDescriptorsByID
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/descriptor.go:203
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).getDescriptorByID
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/descriptor.go:88
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).getDescriptorByName
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/descriptor.go:336
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/descs.(*Collection).GetObjectByName
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/descs/object.go:53
  | github.com/cockroachdb/cockroach/pkg/sql.(*schemaResolver).LookupObject
  | 	github.com/cockroachdb/cockroach/pkg/sql/schema_resolver.go:118
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/resolver.ResolveExisting
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/resolver/resolver.go:390
  | github.com/cockroachdb/cockroach/pkg/sql/catalog/resolver.ResolveExistingObject
  | 	github.com/cockroachdb/cockroach/pkg/sql/catalog/resolver/resolver.go:198
  | github.com/cockroachdb/cockroach/pkg/sql.(*schemaResolver).ResolveType
  | 	github.com/cockroachdb/cockroach/pkg/sql/schema_resolver.go:262
  | github.com/cockroachdb/cockroach/pkg/sql/sem/tree.ResolveType
  | 	github.com/cockroachdb/cockroach/pkg/sql/sem/tree/type_name.go:164
  | github.com/cockroachdb/cockroach/pkg/sql.NewTableDesc
  | 	github.com/cockroachdb/cockroach/pkg/sql/create_table.go:1578
  | github.com/cockroachdb/cockroach/pkg/sql.newTableDesc.func1
  | 	github.com/cockroachdb/cockroach/pkg/sql/create_table.go:2349
  | github.com/cockroachdb/cockroach/pkg/sql.(*schemaResolver).runWithOptions
  | 	github.com/cockroachdb/cockroach/pkg/sql/schema_resolver.go:384
  | github.com/cockroachdb/cockroach/pkg/sql.newTableDesc
  | 	github.com/cockroachdb/cockroach/pkg/sql/create_table.go:2348
  | github.com/cockroachdb/cockroach/pkg/sql.(*createTableNode).startExec
  | ...
Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/colexecerror/error.go

Lines 91 to 93 in af6752b

}()
operation()
return retErr

cockroach/pkg/sql/colflow/stats.go

Lines 91 to 93 in af6752b

func (bic *batchInfoCollector) init() {
bic.Input.Init(bic.ctx)
}

cockroach/pkg/sql/colexec/columnarizer.go

Lines 186 to 188 in af6752b

ctx = c.StartInternal(ctx, "columnarizer" /* name */)
c.input.Start(ctx)
if execStatsHijacker, ok := c.input.(execinfra.ExecStatsForTraceHijacker); ok {

cockroach/pkg/sql/plan_node_to_row_source.go

Lines 165 to 167 in af6752b

// This starts all of the nodes below this node.
if err := startExec(p.params, p.node); err != nil {
p.MoveToDraining(err)

cockroach/pkg/sql/plan.go

Lines 520 to 522 in af6752b

}
return walkPlan(params.ctx, plan, o)
}

cockroach/pkg/sql/walk.go

Lines 42 to 44 in af6752b

v := makePlanVisitor(ctx, observer)
v.visit(plan)
return v.err

cockroach/pkg/sql/walk.go

Lines 78 to 80 in af6752b

}
v.visitInternal(plan, name)
return plan

cockroach/pkg/sql/walk.go

Lines 296 to 298 in af6752b

}
}

cockroach/pkg/sql/walk.go

Lines 111 to 113 in af6752b

}
v.err = v.observer.leaveNode(name, plan)
}()

cockroach/pkg/sql/plan.go

Lines 517 to 519 in af6752b

}
return n.startExec(params)
},

cockroach/pkg/sql/create_table.go

Lines 390 to 392 in af6752b

affected = make(map[descpb.ID]*tabledesc.Mutable)
desc, err = newTableDesc(params, n.n, n.dbDesc, schema, id, creationTime, privs, affected)
if err != nil {

cockroach/pkg/sql/create_table.go

Lines 2347 to 2349 in af6752b

// See the comment at the start of NewTableDesc() and ResolveFK().
params.p.runWithOptions(resolveFlags{skipCache: true, contextDatabaseID: db.GetID()}, func() {
ret, err = NewTableDesc(

cockroach/pkg/sql/schema_resolver.go

Lines 383 to 385 in af6752b

}
fn()
}

cockroach/pkg/sql/create_table.go

Lines 2348 to 2350 in af6752b

params.p.runWithOptions(resolveFlags{skipCache: true, contextDatabaseID: db.GetID()}, func() {
ret, err = NewTableDesc(
params.ctx,

cockroach/pkg/sql/create_table.go

Lines 1577 to 1579 in af6752b

// when attempting to resolve the columns type.
defType, err := tree.ResolveType(ctx, d.Type, semaCtx.GetTypeResolver())
if err != nil {

cockroach/pkg/sql/sem/tree/type_name.go

Lines 163 to 165 in af6752b

}
return resolver.ResolveType(ctx, t)
case *OIDTypeReference:

cockroach/pkg/sql/schema_resolver.go

Lines 261 to 263 in af6752b

}
desc, prefix, err := resolver.ResolveExistingObject(ctx, sr, name, lookupFlags)
if err != nil {

cockroach/pkg/sql/catalog/resolver/resolver.go

Lines 197 to 199 in af6752b

) (res catalog.Descriptor, _ catalog.ResolvedObjectPrefix, err error) {
found, prefix, obj, err := ResolveExisting(ctx, un, sc, lookupFlags, sc.CurrentDatabase(), sc.CurrentSearchPath())
if err != nil {

cockroach/pkg/sql/catalog/resolver/resolver.go

Lines 389 to 391 in af6752b

// Already 3 parts: nothing to search. Delegate to the resolver.
found, prefix, result, err = r.LookupObject(ctx, lookupFlags, u.Catalog(), u.Schema(), u.Object())
prefix.ExplicitDatabase, prefix.ExplicitSchema = true, true

cockroach/pkg/sql/schema_resolver.go

Lines 117 to 119 in af6752b

prefix, objMeta, err = sr.descCollection.GetObjectByName(ctx, sr.txn, dbName, scName, obName, flags)
return objMeta != nil, prefix, objMeta, err

cockroach/pkg/sql/catalog/descs/object.go

Lines 52 to 54 in af6752b

}
desc, err = tc.getDescriptorByName(
ctx, txn, prefix.Database, prefix.Schema, objectName, flags.CommonLookupFlags, requestedType,

cockroach/pkg/sql/catalog/descs/descriptor.go

Lines 335 to 337 in af6752b

desc, err := tc.getDescriptorByID(ctx, txn, flags, id)
if err != nil {

cockroach/pkg/sql/catalog/descs/descriptor.go

Lines 87 to 89 in af6752b

var arr [1]catalog.Descriptor
if err := getDescriptorsByID(
ctx, tc, txn, flags, arr[:], ids...,

cockroach/pkg/sql/catalog/descs/descriptor.go

Lines 202 to 204 in af6752b

// At this point, all descriptors are in the slice, finalize and hydrate them.
if err := tc.finalizeDescriptors(ctx, txn, flags, descs, vls); err != nil {
return err

cockroach/pkg/sql/catalog/descs/descriptor.go

Lines 565 to 567 in af6752b

if len(toValidate) > 0 {
if err := tc.Validate(ctx, txn, catalog.ValidationReadTelemetry, requiredLevel, toValidate...); err != nil {
return err

cockroach/pkg/sql/catalog/descs/validate.go

Lines 35 to 37 in af6752b

version := tc.settings.Version.ActiveVersion(ctx)
return validate.Validate(
ctx,

cockroach/pkg/sql/catalog/internal/validate/validate.go

Lines 99 to 101 in af6752b

// Descriptor backward-reference checks.
if !vea.validateDescriptorsAtLevel(
catalog.ValidationLevelBackReferences,

cockroach/pkg/sql/catalog/internal/validate/validate.go

Lines 192 to 194 in af6752b

vea.currentDescriptor = desc
validationFn(desc)
}

cockroach/pkg/sql/catalog/internal/validate/validate.go

Lines 104 to 106 in af6752b

if !desc.Dropped() {
desc.ValidateBackReferences(&vea, vdg)
}

cockroach/pkg/sql/catalog/typedesc/type_desc.go

Lines 700 to 702 in af6752b

if depDesc.Dropped() {
vea.Report(errors.AssertionFailedf(
"referencing %s %d was dropped without dependency unlinking", depDesc.DescriptorType(), id))

cockroach/pkg/sql/catalog/internal/validate/validate.go

Lines 176 to 178 in af6752b

}
vea.errors = append(vea.errors, vea.decorate(err))
}

cockroach/pkg/sql/catalog/internal/validate/validate.go

Lines 252 to 254 in af6752b

case catalog.Type:
err = errors.Wrapf(err, string(catalog.Type)+" %q (%d)", name, id)
case catalog.Function:

cockroach/pkg/sql/colflow/flow_coordinator.go

Lines 246 to 248 in af6752b

return colexecerror.CatchVectorizedRuntimeError(func() {
f.input.Root.Init(ctx)
})

cockroach/pkg/sql/colflow/stats.go

Lines 100 to 102 in af6752b

// execution time (e.g. in the statement bundle).
err := colexecerror.CatchVectorizedRuntimeError(bic.init)
bic.stopwatch.Stop()

cockroach/pkg/sql/colexecerror/error.go

Lines 91 to 93 in af6752b

}()
operation()
return retErr

cockroach/pkg/sql/colflow/stats.go

Lines 91 to 93 in af6752b

func (bic *batchInfoCollector) init() {
bic.Input.Init(bic.ctx)
}

cockroach/pkg/sql/colexec/columnarizer.go

Lines 186 to 188 in af6752b

ctx = c.StartInternal(ctx, "columnarizer" /* name */)
c.input.Start(ctx)
if execStatsHijacker, ok := c.input.(execinfra.ExecStatsForTraceHijacker); ok {

cockroach/pkg/sql/plan_node_to_row_source.go

Lines 165 to 167 in af6752b

// This starts all of the nodes below this node.
if err := startExec(p.params, p.node); err != nil {
p.MoveToDraining(err)

cockroach/pkg/sql/plan.go

Lines 520 to 522 in af6752b

}
return walkPlan(params.ctx, plan, o)
}

cockroach/pkg/sql/walk.go

Lines 42 to 44 in af6752b

v := makePlanVisitor(ctx, observer)
v.visit(plan)
return v.err

cockroach/pkg/sql/walk.go

Lines 78 to 80 in af6752b

}
v.visitInternal(plan, name)
return plan

cockroach/pkg/sql/walk.go

Lines 296 to 298 in af6752b

}
}

cockroach/pkg/sql/walk.go

Lines 111 to 113 in af6752b

}
v.err = v.observer.leaveNode(name, plan)
}()

cockroach/pkg/sql/plan.go

Lines 517 to 519 in af6752b

}
return n.startExec(params)
},

cockroach/pkg/sql/create_table.go

Lines 390 to 392 in af6752b

affected = make(map[descpb.ID]*tabledesc.Mutable)
desc, err = newTableDesc(params, n.n, n.dbDesc, schema, id, creationTime, privs, affected)
if err != nil {

cockroach/pkg/sql/create_table.go

Lines 2347 to 2349 in af6752b

// See the comment at the start of NewTableDesc() and ResolveFK().
params.p.runWithOptions(resolveFlags{skipCache: true, contextDatabaseID: db.GetID()}, func() {
ret, err = NewTableDesc(

cockroach/pkg/sql/schema_resolver.go

Lines 383 to 385 in af6752b

}
fn()
}

cockroach/pkg/sql/create_table.go

Lines 2348 to 2350 in af6752b

params.p.runWithOptions(resolveFlags{skipCache: true, contextDatabaseID: db.GetID()}, func() {
ret, err = NewTableDesc(
params.ctx,

cockroach/pkg/sql/create_table.go

Lines 1577 to 1579 in af6752b

// when attempting to resolve the columns type.
defType, err := tree.ResolveType(ctx, d.Type, semaCtx.GetTypeResolver())
if err != nil {

cockroach/pkg/sql/sem/tree/type_name.go

Lines 163 to 165 in af6752b

}
return resolver.ResolveType(ctx, t)
case *OIDTypeReference:

cockroach/pkg/sql/schema_resolver.go

Lines 261 to 263 in af6752b

}
desc, prefix, err := resolver.ResolveExistingObject(ctx, sr, name, lookupFlags)
if err != nil {

cockroach/pkg/sql/catalog/resolver/resolver.go

Lines 197 to 199 in af6752b

) (res catalog.Descriptor, _ catalog.ResolvedObjectPrefix, err error) {
found, prefix, obj, err := ResolveExisting(ctx, un, sc, lookupFlags, sc.CurrentDatabase(), sc.CurrentSearchPath())
if err != nil {

cockroach/pkg/sql/catalog/resolver/resolver.go

Lines 389 to 391 in af6752b

// Already 3 parts: nothing to search. Delegate to the resolver.
found, prefix, result, err = r.LookupObject(ctx, lookupFlags, u.Catalog(), u.Schema(), u.Object())
prefix.ExplicitDatabase, prefix.ExplicitSchema = true, true

cockroach/pkg/sql/schema_resolver.go

Lines 117 to 119 in af6752b

prefix, objMeta, err = sr.descCollection.GetObjectByName(ctx, sr.txn, dbName, scName, obName, flags)
return objMeta != nil, prefix, objMeta, err

cockroach/pkg/sql/catalog/descs/object.go

Lines 52 to 54 in af6752b

}
desc, err = tc.getDescriptorByName(
ctx, txn, prefix.Database, prefix.Schema, objectName, flags.CommonLookupFlags, requestedType,

cockroach/pkg/sql/catalog/descs/descriptor.go

Lines 335 to 337 in af6752b

desc, err := tc.getDescriptorByID(ctx, txn, flags, id)
if err != nil {

cockroach/pkg/sql/catalog/descs/descriptor.go

Lines 87 to 89 in af6752b

var arr [1]catalog.Descriptor
if err := getDescriptorsByID(
ctx, tc, txn, flags, arr[:], ids...,

cockroach/pkg/sql/catalog/descs/descriptor.go

Lines 202 to 204 in af6752b

// At this point, all descriptors are in the slice, finalize and hydrate them.
if err := tc.finalizeDescriptors(ctx, txn, flags, descs, vls); err != nil {
return err

cockroach/pkg/sql/catalog/descs/descriptor.go

Lines 565 to 567 in af6752b

if len(toValidate) > 0 {
if err := tc.Validate(ctx, txn, catalog.ValidationReadTelemetry, requiredLevel, toValidate...); err != nil {
return err

cockroach/pkg/sql/catalog/descs/validate.go

Lines 35 to 37 in af6752b

version := tc.settings.Version.ActiveVersion(ctx)
return validate.Validate(
ctx,

cockroach/pkg/sql/catalog/internal/validate/validate.go

Lines 99 to 101 in af6752b

// Descriptor backward-reference checks.
if !vea.validateDescriptorsAtLevel(
catalog.ValidationLevelBackReferences,

cockroach/pkg/sql/catalog/internal/validate/validate.go

Lines 192 to 194 in af6752b

vea.currentDescriptor = desc
validationFn(desc)
}

cockroach/pkg/sql/catalog/internal/validate/validate.go

Lines 104 to 106 in af6752b

if !desc.Dropped() {
desc.ValidateBackReferences(&vea, vdg)
}

cockroach/pkg/sql/catalog/typedesc/type_desc.go

Lines 700 to 702 in af6752b

if depDesc.Dropped() {
vea.Report(errors.AssertionFailedf(
"referencing %s %d was dropped without dependency unlinking", depDesc.DescriptorType(), id)) 

pkg/sql/colexecerror/error.go in pkg/sql/colexecerror.CatchVectorizedRuntimeError at line 92
pkg/sql/colflow/stats.go in pkg/sql/colflow.(*batchInfoCollector).init at line 92
pkg/sql/colexec/columnarizer.go in pkg/sql/colexec.(*Columnarizer).Init at line 187
pkg/sql/plan_node_to_row_source.go in pkg/sql.(*planNodeToRowSource).Start at line 166
pkg/sql/plan.go in pkg/sql.startExec at line 521
pkg/sql/walk.go in pkg/sql.walkPlan at line 43
pkg/sql/walk.go in pkg/sql.(*planVisitor).visit at line 79
pkg/sql/walk.go in pkg/sql.(*planVisitor).visitInternal at line 297
pkg/sql/walk.go in pkg/sql.(*planVisitor).visitInternal.func1 at line 112
pkg/sql/plan.go in pkg/sql.startExec.func2 at line 518
pkg/sql/create_table.go in pkg/sql.(*createTableNode).startExec at line 391
pkg/sql/create_table.go in pkg/sql.newTableDesc at line 2348
pkg/sql/schema_resolver.go in pkg/sql.(*schemaResolver).runWithOptions at line 384
pkg/sql/create_table.go in pkg/sql.newTableDesc.func1 at line 2349
pkg/sql/create_table.go in pkg/sql.NewTableDesc at line 1578
pkg/sql/sem/tree/type_name.go in pkg/sql/sem/tree.ResolveType at line 164
pkg/sql/schema_resolver.go in pkg/sql.(*schemaResolver).ResolveType at line 262
pkg/sql/catalog/resolver/resolver.go in pkg/sql/catalog/resolver.ResolveExistingObject at line 198
pkg/sql/catalog/resolver/resolver.go in pkg/sql/catalog/resolver.ResolveExisting at line 390
pkg/sql/schema_resolver.go in pkg/sql.(*schemaResolver).LookupObject at line 118
pkg/sql/catalog/descs/object.go in pkg/sql/catalog/descs.(*Collection).GetObjectByName at line 53
pkg/sql/catalog/descs/descriptor.go in pkg/sql/catalog/descs.(*Collection).getDescriptorByName at line 336
pkg/sql/catalog/descs/descriptor.go in pkg/sql/catalog/descs.(*Collection).getDescriptorByID at line 88
pkg/sql/catalog/descs/descriptor.go in pkg/sql/catalog/descs.getDescriptorsByID at line 203
pkg/sql/catalog/descs/descriptor.go in pkg/sql/catalog/descs.(*Collection).finalizeDescriptors at line 566
pkg/sql/catalog/descs/validate.go in pkg/sql/catalog/descs.(*Collection).Validate at line 36
pkg/sql/catalog/internal/validate/validate.go in pkg/sql/catalog/internal/validate.Validate at line 100
pkg/sql/catalog/internal/validate/validate.go in pkg/sql/catalog/internal/validate.(*validationErrorAccumulator).validateDescriptorsAtLevel at line 193
pkg/sql/catalog/internal/validate/validate.go in pkg/sql/catalog/internal/validate.Validate.func3 at line 105
pkg/sql/catalog/typedesc/type_desc.go in pkg/sql/catalog/typedesc.(*immutable).ValidateBackReferences at line 701
pkg/sql/catalog/internal/validate/validate.go in pkg/sql/catalog/internal/validate.(*validationErrorAccumulator).Report at line 177
pkg/sql/catalog/internal/validate/validate.go in pkg/sql/catalog/internal/validate.(*validationErrorAccumulator).decorate at line 253
pkg/sql/colflow/flow_coordinator.go in pkg/sql/colflow.(*BatchFlowCoordinator).init.func1 at line 247
pkg/sql/colflow/stats.go in pkg/sql/colflow.(*batchInfoCollector).Init at line 101
pkg/sql/colexecerror/error.go in pkg/sql/colexecerror.CatchVectorizedRuntimeError at line 92
pkg/sql/colflow/stats.go in pkg/sql/colflow.(*batchInfoCollector).init at line 92
pkg/sql/colexec/columnarizer.go in pkg/sql/colexec.(*Columnarizer).Init at line 187
pkg/sql/plan_node_to_row_source.go in pkg/sql.(*planNodeToRowSource).Start at line 166
pkg/sql/plan.go in pkg/sql.startExec at line 521
pkg/sql/walk.go in pkg/sql.walkPlan at line 43
pkg/sql/walk.go in pkg/sql.(*planVisitor).visit at line 79
pkg/sql/walk.go in pkg/sql.(*planVisitor).visitInternal at line 297
pkg/sql/walk.go in pkg/sql.(*planVisitor).visitInternal.func1 at line 112
pkg/sql/plan.go in pkg/sql.startExec.func2 at line 518
pkg/sql/create_table.go in pkg/sql.(*createTableNode).startExec at line 391
pkg/sql/create_table.go in pkg/sql.newTableDesc at line 2348
pkg/sql/schema_resolver.go in pkg/sql.(*schemaResolver).runWithOptions at line 384
pkg/sql/create_table.go in pkg/sql.newTableDesc.func1 at line 2349
pkg/sql/create_table.go in pkg/sql.NewTableDesc at line 1578
pkg/sql/sem/tree/type_name.go in pkg/sql/sem/tree.ResolveType at line 164
pkg/sql/schema_resolver.go in pkg/sql.(*schemaResolver).ResolveType at line 262
pkg/sql/catalog/resolver/resolver.go in pkg/sql/catalog/resolver.ResolveExistingObject at line 198
pkg/sql/catalog/resolver/resolver.go in pkg/sql/catalog/resolver.ResolveExisting at line 390
pkg/sql/schema_resolver.go in pkg/sql.(*schemaResolver).LookupObject at line 118
pkg/sql/catalog/descs/object.go in pkg/sql/catalog/descs.(*Collection).GetObjectByName at line 53
pkg/sql/catalog/descs/descriptor.go in pkg/sql/catalog/descs.(*Collection).getDescriptorByName at line 336
pkg/sql/catalog/descs/descriptor.go in pkg/sql/catalog/descs.(*Collection).getDescriptorByID at line 88
pkg/sql/catalog/descs/descriptor.go in pkg/sql/catalog/descs.getDescriptorsByID at line 203
pkg/sql/catalog/descs/descriptor.go in pkg/sql/catalog/descs.(*Collection).finalizeDescriptors at line 566
pkg/sql/catalog/descs/validate.go in pkg/sql/catalog/descs.(*Collection).Validate at line 36
pkg/sql/catalog/internal/validate/validate.go in pkg/sql/catalog/internal/validate.Validate at line 100
pkg/sql/catalog/internal/validate/validate.go in pkg/sql/catalog/internal/validate.(*validationErrorAccumulator).validateDescriptorsAtLevel at line 193
pkg/sql/catalog/internal/validate/validate.go in pkg/sql/catalog/internal/validate.Validate.func3 at line 105
pkg/sql/catalog/typedesc/type_desc.go in pkg/sql/catalog/typedesc.(*immutable).ValidateBackReferences at line 701

Tags

Tag Value
Command server
Environment v22.2.14
Go Version go1.19.6
Platform linux amd64
Distribution CCL
Cockroach Release v22.2.14
Cockroach SHA af6752b
# of CPUs 8
# of Goroutines 571

Jira issue: CRDB-33347
@cockroach-sentry cockroach-sentry added O-sentry Originated from an in-the-wild panic report. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Nov 8, 2023
@yuzefovich
Copy link
Member

dup of #91645

@exalate-issue-sync exalate-issue-sync bot changed the title Sentry: type_desc.go:701: type × (223): referencing × 256 was dropped without dependency unlinking (1) Wraps: (2) keys: [sql.schema.validation_errors.read.backward_references.type] Wraps: (3) keys: ... Sentry: type_desc.go:701: type × (223): referencing × 256 was dropped without dependency unlinking (1) Wraps: (2) keys: [sql.schema.validation_errors.read.backward_references.type] Wraps: (3) keys: ... Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-sentry Originated from an in-the-wild panic report.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuzefovich @cockroach-sentry