Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: 23.2 performance regression caused by role existence checks #112102

Closed
rafiss opened this issue Oct 10, 2023 · 0 comments · Fixed by #111934
Closed

sql: 23.2 performance regression caused by role existence checks #112102

rafiss opened this issue Oct 10, 2023 · 0 comments · Fixed by #111934
Assignees
@rafiss
Labels
branch-master Failures and bugs on the master branch. branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented Oct 10, 2023 •
edited by cockroach-jira-scripts
Loading

In 12ec26f, we started to check for the existence of a role whenever a privilege for the public role was checked. This can hapen multiple times during some pg_catalog queries, so it introduced a performance regression.

The change in #111819 revealed the regression - once the tests were changed to use a non-root user (which is how most users will interact with CRDB), the number of round trips required by most of the queries increased.

Jira issue: CRDB-32236
@rafiss rafiss added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. branch-master Failures and bugs on the master branch. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) GA-blocker branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 labels Oct 10, 2023
@rafiss rafiss self-assigned this Oct 10, 2023
@rafiss rafiss mentioned this issue Oct 10, 2023
Merged
@craig craig bot closed this as completed in 4447a52 Oct 10, 2023
@blathers-crl blathers-crl bot mentioned this issue Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
branch-master Failures and bugs on the master branch. branch-release-23.2 Used to mark GA and release blockers, technical advisories, and bugs for 23.2 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: cache role existence checks to fix perf regression rafiss/cockroach
1 participant
@rafiss