Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: clearrange/checks=true/rangeTs=true failed #112016

Closed
cockroach-teamcity opened this issue Oct 8, 2023 · 3 comments
Closed

roachtest: clearrange/checks=true/rangeTs=true failed #112016

cockroach-teamcity opened this issue Oct 8, 2023 · 3 comments
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-storage Storage Team X-infra-flake the automatically generated issue was closed due to an infrastructure problem not a product issue
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Oct 8, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.clearrange/checks=true/rangeTs=true failed with artifacts on release-23.1 @ cfadb904a838f5bc6a402b034501a0d7cee38cd8:

(test_runner.go:1146).runTest: test timed out (6h30m0s)
(cluster.go:2109).Run: full command output in run_125407.219306164_n1_cockroach-workload-f.log: COMMAND_PROBLEM: exit status 137
test artifacts and logs in: /artifacts/clearrange/checks=true/rangeTs=true/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=16 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

/cc @cockroachdb/storage

This test on roachdash | Improve this report!

Jira issue: CRDB-32193
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Oct 8, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Oct 8, 2023
@blathers-crl blathers-crl bot added the T-storage Storage Team label Oct 8, 2023
@jbowens
Copy link
Collaborator

jbowens commented Oct 9, 2023 

F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061  file write stall detected: disk slowness detected: sync on file cockroach (0 bytes) has been ongoing for 20.6s
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !goroutine 108 [running]:
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/cockroach/pkg/util/allstacks.GetWithBuf({0x0?, 0xc0073c7860?, 0x47203f?})
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/cockroach/pkg/util/allstacks/allstacks.go:32 +0x85
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/cockroach/pkg/util/allstacks.Get(...)
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/cockroach/pkg/util/allstacks/allstacks.go:19
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/cockroach/pkg/util/log.(*loggerT).outputLogEntry(0xc000fcaee0, {{{0xc000b64f60, 0x24}, {0x5de624b, 0x1}, {0x5de6249, 0x1}, {0x5de624b, 0x1}}, 0x178c23f9027ec97d, ...})
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/cockroach/pkg/util/log/clog.go:263 +0x99
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/cockroach/pkg/util/log.logfDepthInternal({0x733f650, 0xc000dee300}, 0x2, 0x4, 0x0, 0x0?, {0x5daf30d, 0x1d}, {0xc00cb85db8, 0x1, ...})
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/cockroach/pkg/util/log/channels.go:106 +0x645
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/cockroach/pkg/util/log.logfDepth(...)
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/cockroach/pkg/util/log/channels.go:39
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/cockroach/pkg/util/log.Fatalf(...)
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/cockroach/bazel-out/k8-opt/bin/pkg/util/log/log_channels_generated.go:848
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/cockroach/pkg/storage.(*Pebble).makeMetricEtcEventListener.func4({{0x7ffebd0ddd07, 0x14}, 0x2, 0x0, 0x4cc1b399f})
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/cockroach/pkg/storage/pebble.go:1268 +0x215
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/pebble.TeeEventListener.func4({{0x7ffebd0ddd07, 0x14}, 0x2, 0x0, 0x4cc1b399f})
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/pebble/external/com_github_cockroachdb_pebble/event.go:672 +0x4d
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/cockroach/pkg/storage.wrapFilesystemMiddleware.func1({{0x7ffebd0ddd07, 0x14}, 0x2, 0x0, 0x4cc1b399f})
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/cockroach/pkg/storage/pebble.go:668 +0x97
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFS).startTickerLocked.func1()
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:575 +0x4e8
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !created by github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFS).startTickerLocked
F231008 13:11:52.007526 108 storage/pebble.go:1268 ⋮ [T1,n3] 1061 !	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:548 +0x7a

Write stall

The goroutine stack dump shows the stalled fsync attempting to sync the directory:

goroutine 347 [syscall]:
syscall.Syscall(0x1?, 0x0?, 0xc00439faa8?, 0x1c13336?)
	GOROOT/src/syscall/syscall_linux.go:68 +0x27
syscall.Fsync(0xc00439fa80?)
	GOROOT/src/syscall/zsyscall_linux_amd64.go:423 +0x2a
internal/poll.(*FD).Fsync.func1(...)
	GOROOT/src/internal/poll/fd_fsync_posix.go:18
internal/poll.ignoringEINTR(...)
	GOROOT/src/internal/poll/fd_posix.go:74
internal/poll.(*FD).Fsync(0xc00066a930?)
	GOROOT/src/internal/poll/fd_fsync_posix.go:17 +0xf4
os.(*File).Sync(0xc000ddbfd0)
	GOROOT/src/os/file_posix.go:168 +0x4e
github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingDir).Sync.func1()
	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:355 +0x2e
github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingFS).timeFilesystemOp(0xc025d621a0?, {0x7ffebd0ddd07?, 0x2ab0?}, 0xc8?, 0xc00439fba0)
	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:537 +0x49
github.com/cockroachdb/pebble/vfs.(*diskHealthCheckingDir).Sync(0xc00439fc70?)
	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_health.go:354 +0x65
github.com/cockroachdb/pebble/vfs.(*enospcFile).Sync(0xc000d3c798)
	github.com/cockroachdb/pebble/vfs/external/com_github_cockroachdb_pebble/vfs/disk_full.go:395 +0x42
github.com/cockroachdb/pebble/objstorage.(*Provider).vfsSync(0xc0009798c0)
	github.com/cockroachdb/pebble/objstorage/external/com_github_cockroachdb_pebble/objstorage/vfs.go:93 +0x8e
github.com/cockroachdb/pebble/objstorage.(*Provider).Sync(0x26da?)
	github.com/cockroachdb/pebble/objstorage/external/com_github_cockroachdb_pebble/objstorage/provider.go:322 +0x1e
github.com/cockroachdb/pebble.(*DB).ingest(0xc001692000, {0xc02666a0b0, 0x1, 0x1}, 0x60f7b30)
	github.com/cockroachdb/pebble/external/com_github_cockroachdb_pebble/ingest.go:841 +0x24d
github.com/cockroachdb/pebble.(*DB).Ingest(0x472387?, {0xc02666a0b0?, 0x5283280?, 0x1?})
	github.com/cockroachdb/pebble/external/com_github_cockroachdb_pebble/ingest.go:658 +0x96
github.com/cockroachdb/cockroach/pkg/storage.(*Pebble).IngestExternalFiles(0xc049f50000?, {0xc0101fa040?, 0xc00ae427e0?}, {0xc02666a0b0?, 0x0?, 0xc0047b4548?})
	github.com/cockroachdb/cockroach/pkg/storage/pebble.go:1940 +0x2b

@jbowens jbowens mentioned this issue Oct 9, 2023
Closed
@jbowens
Copy link
Collaborator

jbowens commented Oct 9, 2023

Filed #112049 to address the fact that this test should've failed as soon as nodes died due to disk stalls, rather than timing out 5 hours later.

@jbowens jbowens added the X-infra-flake the automatically generated issue was closed due to an infrastructure problem not a product issue label Oct 9, 2023
@jbowens jbowens closed this as completed Oct 9, 2023
@jbowens
Copy link
Collaborator

jbowens commented Oct 20, 2023

Linking to #97968.

@jbowens jbowens moved this to Done in [Deprecated] Storage Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-storage Storage Team X-infra-flake the automatically generated issue was closed due to an infrastructure problem not a product issue
Projects
No open projects
[Deprecated] Storage
Archived in project
Milestone
23.1
Development

No branches or pull requests
2 participants
@jbowens @cockroach-teamcity