Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roach{prod,test}: ask users about their department when using Azure #111787

Open
healthy-pod opened this issue Oct 4, 2023 · 2 comments
Open
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@healthy-pod
Copy link
Contributor

healthy-pod commented Oct 4, 2023

When a user is using roachprod with Azure, prompt them to choose their department from:

  • Engineering
  • Product
  • Revenue

Only do this once, then cache the value in local roachprod config.

Use the department to choose which subscription id to use by mapping department name to subscription ID.

Jira issue: CRDB-32070

@healthy-pod healthy-pod added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team labels Oct 4, 2023
@blathers-crl
Copy link

blathers-crl bot commented Oct 4, 2023

cc @cockroachdb/test-eng

@jlinder
Copy link
Collaborator

jlinder commented Oct 4, 2023

A few additional thoughts:

  • It would be ideal if this config file could be applied to choosing the default Azure subscription, GCP project or AWS account. (Because we will soon have different subscriptions / projects / accounts for different divisions.)
  • The config file might allow for setting which subscription / project / account take use as the default in these ways:
    • by department name. This would make configuration easy for the internal user, use the hard-coded default for the specified division for cloud they're running against, and allow the default to change if it ever changes for that division.
    • by a specific subscription ID, project ID, or account ID/alias for their respective clouds. This would allow roachprod to be used by non-CRL employees.
  • Suggesting ~/.config/roachprod/ as a good location for such a file

@renatolabs renatolabs added the A-testing Testing tools and infrastructure label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
No open projects
Status: Triage
Development

No branches or pull requests

3 participants