Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add REFCURSOR to postgres-compatibility cast tests #111618

Closed
DrewKimball opened this issue Oct 2, 2023 · 0 comments · Fixed by #113878
Closed

sql: add REFCURSOR to postgres-compatibility cast tests #111618

DrewKimball opened this issue Oct 2, 2023 · 0 comments · Fixed by #113878
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team

Comments

@DrewKimball
Copy link
Collaborator

DrewKimball commented Oct 2, 2023 •
edited by cockroach-jira-scripts
Loading

This issue tracks adding the new REFCURSOR data type to the postgres compatibility tests located in pkg/sql/sem/eval/cast_test/testdata/types.txt. The cast behavior of REFCURSOR is a bit strange (no casts in pg_cast; only IO conversions), so the extra test coverage will be useful.

Jira issue: CRDB-31988
@DrewKimball DrewKimball added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Oct 2, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Oct 2, 2023
@DrewKimball DrewKimball mentioned this issue Oct 3, 2023
Merged
@yuzefovich yuzefovich moved this from Triage to New Backlog in SQL Queries Oct 24, 2023
@yuzefovich yuzefovich added the T-sql-queries SQL Queries Team label Oct 25, 2023
@yuzefovich yuzefovich mentioned this issue Nov 6, 2023
Merged
@craig craig bot closed this as completed in 7a0b7f4 Nov 7, 2023
@github-project-automation github-project-automation bot moved this from New Backlog to Done in SQL Queries Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cast_test: add refcursor type yuzefovich/cockroach
2 participants
@yuzefovich @DrewKimball