Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rangefeed: if catchup iterator fails to create processor is stopped #111060

Closed
aliher1911 opened this issue Sep 21, 2023 · 2 comments · Fixed by #111045
Closed

rangefeed: if catchup iterator fails to create processor is stopped #111060

aliher1911 opened this issue Sep 21, 2023 · 2 comments · Fixed by #111045
Assignees
Labels
A-kv-replication Relating to Raft, consensus, and coordination. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker

Comments

@aliher1911
Copy link
Contributor

aliher1911 commented Sep 21, 2023

When rangefeed created it can request a catchup iterator creation from underlying store.

Recent changes to interface can cause creation to fail with error. This failure causes processor to stop immediately.

This behaviour is not correct from rangefeed client perspective. Processor can serve multiple clients at the same time and other clients should not be affected by new feed failure. The better approach should be to fail new registration instead.

There's currently no easy way to expose errors like that, what could be done instead is eager creation of iterator. In that case if iterator creation fails, we don't need to create new registration.

Jira issue: CRDB-31745

@aliher1911 aliher1911 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv-replication Relating to Raft, consensus, and coordination. T-kv-replication labels Sep 21, 2023
@blathers-crl
Copy link

blathers-crl bot commented Sep 21, 2023

cc @cockroachdb/replication

@blathers-crl
Copy link

blathers-crl bot commented Sep 21, 2023

Hi @erikgrinaker, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@erikgrinaker erikgrinaker added the branch-master Failures and bugs on the master branch. label Sep 21, 2023
@craig craig bot closed this as completed in 235babd Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-kv-replication Relating to Raft, consensus, and coordination. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants