Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema 23.2: gate automatic catalog repairs behind an environment variable #110612

Closed
rimadeodhar opened this issue Sep 13, 2023 · 0 comments · Fixed by #110816
Closed

schema 23.2: gate automatic catalog repairs behind an environment variable #110612

rimadeodhar opened this issue Sep 13, 2023 · 0 comments · Fixed by #110816
Assignees
@rafiss
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-premortem Issues identified during premortem exercise. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rimadeodhar
Copy link
Collaborator

rimadeodhar commented Sep 13, 2023 •
edited by cockroach-jira-scripts
Loading

The automatic catalog repairs added in (#105832) have been gated behind an environment variable and disabled by default in 23.1.
For 23.2, we should add this environment variable and set it to true by default.
This should only be done once #110476 is completed.

Jira issue: CRDB-31520
@rimadeodhar rimadeodhar added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Sep 13, 2023
@rimadeodhar rimadeodhar changed the title schema: gate automatic catalog repairs behind an environment variable schema 23.2: gate automatic catalog repairs behind an environment variable Sep 13, 2023
@rimadeodhar rimadeodhar added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Sep 13, 2023
@rimadeodhar rimadeodhar added the O-premortem Issues identified during premortem exercise. label Sep 13, 2023
@rafiss rafiss self-assigned this Sep 19, 2023
@rafiss rafiss mentioned this issue Sep 19, 2023
Merged
@craig craig bot closed this as completed in 5efd9b4 Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafiss rafiss

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-premortem Issues identified during premortem exercise. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrades: add COCKROACH_RUN_FIRST_UPGRADE_PRECONDITION gate rafiss/cockroach
2 participants
@rafiss @rimadeodhar