Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rangefeed: add scheduler priority shard for system ranges #110567

Closed
erikgrinaker opened this issue Sep 13, 2023 · 1 comment · Fixed by #110810
Closed

rangefeed: add scheduler priority shard for system ranges #110567

erikgrinaker opened this issue Sep 13, 2023 · 1 comment · Fixed by #110810
Assignees
@erikgrinaker
Labels
A-kv-rangefeed Rangefeed infrastructure, server+client C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-premortem Issues identified during premortem exercise.

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Sep 13, 2023 •
edited by exalate-issue-sync bot
Loading

To ensure system ranges don't get head-of-line blocked by user rangefeed traffic, we can add a separate priority shard in the scheduler for these, similarly to what we do in the Raft scheduler.

A couple of wrinkles: this will require a sync.IntMap lookup for every enqueue, which may have non-negligible cost, and we may not know whether a range is a system range when registering the rangefeed because span configs are themselves propagated via rangefeeds.

Related to #110344.

Jira issue: CRDB-31508

Epic CRDB-26372
@erikgrinaker erikgrinaker added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv-replication A-kv-rangefeed Rangefeed infrastructure, server+client labels Sep 13, 2023
@blathers-crl
Copy link

blathers-crl bot commented Sep 13, 2023

cc @cockroachdb/replication

@erikgrinaker erikgrinaker added the O-premortem Issues identified during premortem exercise. label Sep 14, 2023
@erikgrinaker erikgrinaker mentioned this issue Sep 18, 2023
Merged
@craig craig bot closed this as completed in 3d76521 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikgrinaker erikgrinaker

Labels
A-kv-rangefeed Rangefeed infrastructure, server+client C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-premortem Issues identified during premortem exercise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rangefeed: prioritize system spans in rangefeed scheduler erikgrinaker/cockroach
1 participant
@erikgrinaker