Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: do not pretty-print the statement in statement bundles #110375

Open
mgartner opened this issue Sep 11, 2023 · 0 comments
Open

sql: do not pretty-print the statement in statement bundles #110375

mgartner opened this issue Sep 11, 2023 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team

Comments

@mgartner
Copy link
Collaborator

mgartner commented Sep 11, 2023 •
edited by cockroach-jira-scripts
Loading

The pretty package is expensive and has shown to consume a lot of memory and sometimes stack overflow with very long SQL statements. To avoid issues that pretty can cause, we should reduce its usage. Pretty printing the statement in the statement bundle is a nice-to-have, but non-essential feature. We should consider always printing the original statement.

Jira issue: CRDB-31676
@mgartner mgartner added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Sep 11, 2023
@mgartner mgartner mentioned this issue Sep 11, 2023
Open
@DrewKimball DrewKimball added the E-quick-win Likely to be a quick win for someone experienced. label Sep 19, 2023
@DrewKimball DrewKimball moved this from Triage to New Backlog in SQL Queries Sep 19, 2023
@yuzefovich yuzefovich added the T-sql-queries SQL Queries Team label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgartner @yuzefovich @DrewKimball