Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvserver/rangefeed: TestBudgetReleaseOnProcessorStop failed #109802

Closed
cockroach-teamcity opened this issue Aug 31, 2023 · 4 comments · Fixed by #109809
Closed

kv/kvserver/rangefeed: TestBudgetReleaseOnProcessorStop failed #109802

cockroach-teamcity opened this issue Aug 31, 2023 · 4 comments · Fixed by #109809
Assignees
@pav-kv
Labels
A-kv-replication Relating to Raft, consensus, and coordination. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
23.2

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Aug 31, 2023 •
edited by cockroach-jira-scripts
Loading

kv/kvserver/rangefeed.TestBudgetReleaseOnProcessorStop failed with artifacts on master @ 0f70a7007724cc6550324ad9dd635c31cec8e400:

=== RUN   TestBudgetReleaseOnProcessorStop
    processor_test.go:1143: stream failed with error before all data was consumed retry rangefeed (REASON_SLOW_CONSUMER)
--- FAIL: TestBudgetReleaseOnProcessorStop (0.00s)

Parameters: TAGS=bazel,gss , stress=true

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/replication

This test on roachdash | Improve this report!

Jira issue: CRDB-31103
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv-replication labels Aug 31, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.2 milestone Aug 31, 2023
@pav-kv pav-kv added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-kv-replication Relating to Raft, consensus, and coordination. labels Aug 31, 2023
@pav-kv
Copy link
Collaborator

pav-kv commented Aug 31, 2023

Looks similar to #108555.

@pav-kv
Copy link
Collaborator

pav-kv commented Aug 31, 2023

Potentially, the fix should be similar too. See #108583.

@pav-kv pav-kv assigned pav-kv and unassigned aliher1911 Aug 31, 2023
@pav-kv
Copy link
Collaborator

pav-kv commented Aug 31, 2023

@aliher1911 I'll make an attempt, and reassign to you if it's more complex than repeating the other fix.

@pav-kv pav-kv mentioned this issue Aug 31, 2023
Merged
@pav-kv
Copy link
Collaborator

pav-kv commented Aug 31, 2023

We should stress other tests in rangefeed/processor_test.go, and see if they exhibit the same issue. The channel timeout is set to many different values across these tests.

@pav-kv pav-kv removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 1, 2023
@craig craig bot closed this as completed in 282573b Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pav-kv pav-kv

Labels
A-kv-replication Relating to Raft, consensus, and coordination. branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
23.2
Development

Successfully merging a pull request may close this issue.

rangefeed: deflake TestBudgetReleaseOnProcessorStop pav-kv/cockroach
3 participants
@pav-kv @aliher1911 @cockroach-teamcity