Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings: use the function option passing style for the register function #109011

Closed
knz opened this issue Aug 18, 2023 · 0 comments · Fixed by #109012
Closed

settings: use the function option passing style for the register function #109011

knz opened this issue Aug 18, 2023 · 0 comments · Fixed by #109012
Assignees
@knz
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@knz
Copy link
Contributor

knz commented Aug 18, 2023 •
edited by cockroach-jira-scripts
Loading

We have too many variants of the Register functions with combinations of argument types.

The validation and visibility for example could be specified by options in a variable-length argument list.

see: https://cockroachlabs.atlassian.net/wiki/spaces/CRDB/pages/1881669848/Go+function+argument+patterns

Epic: CRDB-28893

Jira issue: CRDB-30739
@knz knz added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 18, 2023
@knz knz self-assigned this Aug 18, 2023
@knz knz mentioned this issue Aug 18, 2023
Merged
@craig craig bot closed this as completed in 0352a78 Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

settings,*: use the option pattern with the setting register functions knz/cockroach
1 participant
@knz