Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: use in-memory cache of tenant info in server controller #107827

Closed
knz opened this issue Jul 28, 2023 · 0 comments · Fixed by #112001
Closed

server: use in-memory cache of tenant info in server controller #107827

knz opened this issue Jul 28, 2023 · 0 comments · Fixed by #112001
Assignees
@stevendanna
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-multitenant Issues owned by the multi-tenant virtual team

Comments

@knz
Copy link
Contributor

knz commented Jul 28, 2023 •
edited
Loading

Currently the code in server controller is using a periodic SQL poll loop to inspect the service mode of runnable tenants.

Since #106414 was merged, we now have a rangefeed-enabled cache of this state. So the SQL polling loop can be removed.

As a side benefit, this also makes it possible for the server controller to identify servers by tenant ID instead of by name.

Epic: CRDB-26691

Jira issue: CRDB-30208
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multitenancy Related to multi-tenancy T-multitenant Issues owned by the multi-tenant virtual team labels Jul 28, 2023
@knz knz mentioned this issue Jul 28, 2023
Merged
@knz knz mentioned this issue Oct 9, 2023
Merged
@craig craig bot closed this as completed in #112001 Oct 9, 2023
@craig craig bot closed this as completed in 0a99ac2 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevendanna stevendanna

Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-multitenant Issues owned by the multi-tenant virtual team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: use tenant capability watcher in orchestrator stevendanna/cockroach
2 participants
@knz @stevendanna