Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serverutils: merge StartTenant and StartSharedProcessTenant #107695

Closed
knz opened this issue Jul 27, 2023 · 1 comment
Closed

serverutils: merge StartTenant and StartSharedProcessTenant #107695

knz opened this issue Jul 27, 2023 · 1 comment
Labels
A-multitenancy Related to multi-tenancy A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) db-cy-23 T-multitenant Issues owned by the multi-tenant virtual team

Comments

@knz
Copy link
Contributor

knz commented Jul 27, 2023 •
edited by exalate-issue-sync bot
Loading

(Followup to #107612)

  1. there should be just 1 method instead of 2 -- with the deployment mode set as parameter.
  2. the name is wrong - it does not "start a tenant", it starts the service for a tenant.

Epic CRDB-31933
xref #107058.
xref #106772.

Jira issue: CRDB-30163
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure A-multitenancy Related to multi-tenancy T-multitenant Issues owned by the multi-tenant virtual team db-cy-23 labels Jul 27, 2023
@herkolategan herkolategan mentioned this issue Oct 27, 2023
Merged
@stevendanna
Copy link
Collaborator

Closing for now. I think we we probably want to do a new pass of considering the TestServer API and then generate work items as appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-multitenancy Related to multi-tenancy A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) db-cy-23 T-multitenant Issues owned by the multi-tenant virtual team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knz @stevendanna