Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/must: avoid circular dependencies #107427

Closed
erikgrinaker opened this issue Jul 23, 2023 · 2 comments
Closed

util/must: avoid circular dependencies #107427

erikgrinaker opened this issue Jul 23, 2023 · 2 comments
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Jul 23, 2023 •
edited
Loading

Currently, must can't be used from packages that must itself depends on (e.g. util/log), due to circular depencies. If this is needed, we can solve it by dependency injection, where the necessary functions are injected into must global variables at runtime via init() calls. It isn't clear that we'll need it though, so let's not spend time on this until we do.

Jira issue: CRDB-30037
@erikgrinaker erikgrinaker added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-testing Testing tools and infrastructure T-testeng TestEng Team labels Jul 23, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jul 23, 2023

cc @cockroachdb/test-eng

@erikgrinaker erikgrinaker changed the title util/must: resolve circular dependencies util/must: avoid circular dependencies Jul 23, 2023
@erikgrinaker erikgrinaker mentioned this issue Jul 23, 2023
Merged
@erikgrinaker
Copy link
Contributor Author

must is no more, see #108272.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testing Testing tools and infrastructure C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-testeng TestEng Team
Projects
No open projects
Test Engineering
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikgrinaker