Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamcity: improve UX of diagnosing package timeouts #107339

Open
tbg opened this issue Jul 21, 2023 · 1 comment
Open

teamcity: improve UX of diagnosing package timeouts #107339

tbg opened this issue Jul 21, 2023 · 1 comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) quality-friday A good issue to work on on Quality Friday T-dev-inf

Comments

@tbg
Copy link
Member

tbg commented Jul 21, 2023

This is what it takes today:

diagnosing-package-timeout-smaller.mov

I can't imagine many people can do this sequence of clicks. I've had to do it quite a few times over the last couple of days. It keeps coming up. How can we improve the UX around package timeouts? Problems I see:

  • test output doesn't indicate when the test has been running for a long time -> maybe we can put something into log.Scope or leaktest to call t.Logf("test has been running for X minutes") for each minute test has been running. This helps distinguish two kinds of problems (test timeout too short for how long the tests in the pkg shard take in aggregate vs single test gets stuck/is verrrry slow). Not distinguishing them can lead to filing issues against tests that are not to blame.
  • finding the failing shard requires knowing that you need to search the build log for FAIL:, can we somehow make the shard available in each test output? If it's in the env we could just t.Logf("shard: %d", ...) from leaktest or log.Scope to capture most tests.

Jira issue: CRDB-29997

@tbg tbg added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf quality-friday A good issue to work on on Quality Friday labels Jul 21, 2023
@exalate-issue-sync exalate-issue-sync bot changed the title tc: improve UX of diagnosing package timeouts teamcity: improve UX of diagnosing package timeouts Jul 21, 2023
@jlinder
Copy link
Collaborator

jlinder commented Jul 26, 2023

This may improve with EngFlow. We will re-evaulate once we've made the switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) quality-friday A good issue to work on on Quality Friday T-dev-inf
Projects
None yet
Development

No branches or pull requests

2 participants