Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: SpanStats architectural improvements #107217

Open
zachlite opened this issue Jul 19, 2023 · 0 comments
Open

server: SpanStats architectural improvements #107217

zachlite opened this issue Jul 19, 2023 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability

Comments

@zachlite
Copy link
Contributor

zachlite commented Jul 19, 2023

Originally mentioned in #103957, I'm making a separate issue for these comments, so that 103957 can be closed.

  • the “new” code for the stats-for-span function is deeply embedded in the obs API server, which is architecturally unsound since the functionality is a pure KV function and should be usable from SQL without interfacing with the API server at all.
  • we want to have a version of this code that is guaranteed to operate on a consistent view of the entire span (i.e. not a mix of cached data for part of the span, and uncached for another part)
  • we want the API to be able to reuse an existing client.Txn object (instead of synthetisizing its own)

Jira issue: CRDB-29949

Epic CRDB-25476

@zachlite zachlite added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cluster-observability labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability
Projects
None yet
Development

No branches or pull requests

1 participant