Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: consistency checker diff calculation uses a cancelled context #10613

Closed
petermattis opened this issue Nov 10, 2016 · 0 comments
Closed
Assignees

Comments

@petermattis
Copy link
Collaborator

Discovered while investigating #10602.

When Replica.ConsistencyChecker discovers an inconsistency, it spawns a new goroutine using Stopper.RunAsyncTask and recursively calls itself pass withDiff = true. But the new goroutine is passed the original context and when Replica.ConsistencyChecker returns the context is cancelled fairly soon. The result is that we never perform the diff check and never exist on consistency failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants