Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/pgwire: TestConn failed #105410

Closed
cockroach-teamcity opened this issue Jun 23, 2023 · 3 comments · Fixed by #105515
Closed

sql/pgwire: TestConn failed #105410

cockroach-teamcity opened this issue Jun 23, 2023 · 3 comments · Fixed by #105515
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 23, 2023 •
edited by cockroach-jira-scripts
Loading

sql/pgwire.TestConn failed with artifacts on release-23.1 @ 624d9dea7f1296af60d16bbb45cc9d1259b3a1be:

=== RUN   TestConn
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/28616e575ae934b92eba220441c7ca42/logTestConn3706962089
    test_log_scope.go:79: use -show-logs to present logs inline
==================
WARNING: DATA RACE
Write at 0x00c004f40830 by goroutine 5101:
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:106 +0x697
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:83 +0x14c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47

Previous read at 0x00c004f40830 by goroutine 7408:
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn.func1()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:102 +0x4f
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x86

Goroutine 5101 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1493 +0x75d
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:1846 +0x99
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.runTests()
      GOROOT/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:1726 +0xa84
  github.com/cockroachdb/cockroach/pkg/sql/pgwire_test.TestMain()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire_test/pkg/sql/pgwire/main_test.go:33 +0xe6
  main.main()
      main/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/testmain.go:303 +0x748

Goroutine 7408 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x12e
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:101 +0x644
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:83 +0x14c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47
==================

Parameters: TAGS=bazel,gss,race

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations @cockroachdb/server

This test on roachdash | Improve this report!

Jira issue: CRDB-29021
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Jun 23, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Jun 23, 2023
@cockroach-teamcity
Copy link
Member Author

sql/pgwire.TestConn failed with artifacts on release-23.1 @ dbf6ce8438742a73b9d17391c1ef868a4e7a9569:

      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:106 +0x697
  github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartServer()
      github.com/cockroachdb/cockroach/pkg/testutils/serverutils/test_server_shim.go:330 +0x1b6
  github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartServer()
      github.com/cockroachdb/cockroach/pkg/testutils/serverutils/test_server_shim.go:325 +0x96
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:83 +0x14c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47

Previous read at 0x00c00361e310 by goroutine 7423:
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn.func1()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:102 +0x4f
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x86

Goroutine 5145 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1493 +0x75d
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:1846 +0x99
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.runTests()
      GOROOT/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:1726 +0xa84
  github.com/cockroachdb/cockroach/pkg/sql/pgwire_test.TestMain()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire_test/pkg/sql/pgwire/main_test.go:33 +0xe6
  main.main()
      main/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/testmain.go:303 +0x748

Goroutine 7423 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x12e
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:101 +0x644
  github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartServer()
      github.com/cockroachdb/cockroach/pkg/testutils/serverutils/test_server_shim.go:330 +0x1b6
  github.com/cockroachdb/cockroach/pkg/testutils/serverutils.StartServer()
      github.com/cockroachdb/cockroach/pkg/testutils/serverutils/test_server_shim.go:325 +0x96
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:83 +0x14c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47
==================

Parameters: TAGS=bazel,gss,race

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@rafiss rafiss mentioned this issue Jun 25, 2023
Merged
@cockroach-teamcity
Copy link
Member Author

sql/pgwire.TestConn failed with artifacts on release-23.1 @ dbf6ce8438742a73b9d17391c1ef868a4e7a9569:

=== RUN   TestConn
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/28616e575ae934b92eba220441c7ca42/logTestConn1772847551
    test_log_scope.go:79: use -show-logs to present logs inline
==================
WARNING: DATA RACE
Write at 0x00c0049e4060 by goroutine 5089:
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:106 +0x697
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:83 +0x14c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47

Previous read at 0x00c0049e4060 by goroutine 7391:
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn.func1()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:102 +0x4f
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x86

Goroutine 5089 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1493 +0x75d
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:1846 +0x99
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.runTests()
      GOROOT/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:1726 +0xa84
  github.com/cockroachdb/cockroach/pkg/sql/pgwire_test.TestMain()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire_test/pkg/sql/pgwire/main_test.go:33 +0xe6
  main.main()
      main/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/testmain.go:303 +0x748

Goroutine 7391 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x12e
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:101 +0x644
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:83 +0x14c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47
==================

Parameters: TAGS=bazel,gss,race

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/pgwire.TestConn failed with artifacts on release-23.1 @ bcbc49fb67e094ebb315067e261caabecf427a07:

=== RUN   TestConn
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/28616e575ae934b92eba220441c7ca42/logTestConn2364258994
    test_log_scope.go:79: use -show-logs to present logs inline
==================
WARNING: DATA RACE
Write at 0x00c000f23410 by goroutine 5287:
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:106 +0x697
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:83 +0x14c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47

Previous read at 0x00c000f23410 by goroutine 7654:
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn.func1()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:102 +0x4f
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:75 +0x86

Goroutine 5287 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1493 +0x75d
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:1846 +0x99
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.runTests()
      GOROOT/src/testing/testing.go:1844 +0x7ec
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:1726 +0xa84
  github.com/cockroachdb/cockroach/pkg/sql/pgwire_test.TestMain()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire_test/pkg/sql/pgwire/main_test.go:33 +0xe6
  main.main()
      main/bazel-out/k8-fastbuild/bin/pkg/sql/pgwire/pgwire_test_/testmain.go:303 +0x748

Goroutine 7654 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:72 +0x12e
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:101 +0x644
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.TestConn()
      github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn_test.go:83 +0x14c
  testing.tRunner()
      GOROOT/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1493 +0x47
==================

Parameters: TAGS=bazel,gss,race

Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@craig craig bot closed this as completed in 15d43bb Jun 26, 2023
@craig craig bot closed this as completed in #105515 Jun 26, 2023
@blathers-crl blathers-crl bot mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

pgwire: fix race in TestConn rafiss/cockroach
1 participant
@cockroach-teamcity