Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: c2c/shutdown/src/coordinator failed #105176

Closed
cockroach-teamcity opened this issue Jun 20, 2023 · 8 comments
Closed

roachtest: c2c/shutdown/src/coordinator failed #105176

cockroach-teamcity opened this issue Jun 20, 2023 · 8 comments
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-testeng TestEng Team
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 20, 2023

roachtest.c2c/shutdown/src/coordinator failed with artifacts on master @ 76da6c7dfb4d71ad614715ec5e230a6cc76fbd0e:

test c2c/shutdown/src/coordinator failed during post test assertions (see test-post-assertions.log) due to (test_runner.go:1122).func1: x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "Cockroach CA")
test artifacts and logs in: /artifacts/c2c/shutdown/src/coordinator/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=8 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-28911

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels Jun 20, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Jun 20, 2023
@cockroach-teamcity
Copy link
Member Author

roachtest.c2c/shutdown/src/coordinator failed with artifacts on master @ 1eb628e8c8a7eb1cbf9bfa2bd6c31982c25cbba0:

test c2c/shutdown/src/coordinator failed during post test assertions (see test-post-assertions.log) due to (test_runner.go:1122).func1: x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "Cockroach CA")
test artifacts and logs in: /artifacts/c2c/shutdown/src/coordinator/run_1

Parameters: ROACHTEST_arch=amd64 , ROACHTEST_cloud=gce , ROACHTEST_cpu=8 , ROACHTEST_encrypted=false , ROACHTEST_fs=ext4 , ROACHTEST_localSSD=true , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

This test on roachdash | Improve this report!

@lidorcarmel
Copy link
Contributor

bisected to 3573201 which is pr #105006
I think I trust my bisection (meaning, I don't think it's flaky but I didn't really run this frequently)
cc @herkolategan somehow this pr messed up certificates?

@lidorcarmel
Copy link
Contributor

that said, other c2c tests are succeeding! still looking.

@herkolategan
Copy link
Collaborator

@lidorcarmel I'm going to look into this, because the test that PR, #105006, re-enabled does some certificate manipulation. Including changing permissions etc. It could be the culprit.

@blathers-crl
Copy link

blathers-crl bot commented Jun 26, 2023

cc @cockroachdb/test-eng

@lidorcarmel
Copy link
Contributor

@herkolategan I might have got this one wrong :( It doesn't fail anymore so maybe it is flaky? and if I was bisecting using a flaky test then that's.. garbage. Anyway I tried 3 runs now with #105006 and all 3 succeeded. Hopefully you didn't waste time on this! I'll look again tomorrow.

@renatolabs
Copy link
Contributor

Pretty sure the failure is due to a bug in the certificate management by the test infrastructure, as evidenced by the error message in the logs:

grpc: ‹connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority (possibly because of \"crypto/rsa: verification error\" while trying to verify candidate authority certificate \"Cockroach CA\")"› [code 14/Unavailable]

It was recently fixed by #105514, so I believe that is why you don't see the failure anymore. I'm going to close this issue, roachtest will create another one if it fails again.

@herkolategan
Copy link
Collaborator

@herkolategan I might have got this one wrong :( It doesn't fail anymore so maybe it is flaky? and if I was bisecting using a flaky test then that's.. garbage. Anyway I tried 3 runs now with #105006 and all 3 succeeded. Hopefully you didn't waste time on this! I'll look again tomorrow.

@lidorcarmel No problem, thanks for the heads-up. I spotted the same issue @renatolabs mentioned and thought it was the cause (I made a note on that issue #105514 that it's likely the cause of this one). Hence that should fix this even if it was flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-testeng TestEng Team
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants