Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts: only issue DeleteRange requests when pruning if there is something to delete #10479

Closed
petermattis opened this issue Nov 5, 2016 · 2 comments
Assignees

Comments

@petermattis
Copy link
Collaborator

Discovered while investigating #10409.

tsdb.PruneTimeSeries issues a DeleteRange request for every time series name it encounters regardless of whether there is any data to delete. It seems possible to enhance tsdb.findTimeSeries to only return time series which have data that needs to be pruned. When seeking to the next time series name we could "back up" (using rocksdb.Iterator.Prev) to find the oldest key for the previous time series and determine if any data needs to be deleted.

@petermattis
Copy link
Collaborator Author

@spencerkimball didn't you fix this?

@spencerkimball
Copy link
Member

Yes #11762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants