Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add query cache collision testing #104027

Open
DrewKimball opened this issue May 28, 2023 · 0 comments
Open

sql: add query cache collision testing #104027

DrewKimball opened this issue May 28, 2023 · 0 comments
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. P-3 Issues/test failures with no fix SLA quality-friday A good issue to work on on Quality Friday T-sql-queries SQL Queries Team

Comments

@DrewKimball
Copy link
Collaborator

DrewKimball commented May 28, 2023 •
edited by rickystewart
Loading

We currently have limited testing for the case when the same SQL is run concurrently by different users / on different databases against the same query cache. More testing for this case could have caught #102375. Our logic tests already allow switching the user and db session with the user directive. We should add some tests that repeatedly run the same SQL on similar schemas from different users to verify that the query cache is correctly invalidated in the case when it is thrashing. We may also want to add support for similar testing in our randomized tests.

Jira issue: CRDB-28320
@DrewKimball DrewKimball added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label May 28, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label May 28, 2023
@michae2 michae2 added the O-postmortem Originated from a Postmortem action item. label May 30, 2023
@erikgrinaker erikgrinaker added the quality-friday A good issue to work on on Quality Friday label Jul 20, 2023
@mgartner mgartner moved this to 23.2 Release in SQL Queries Jul 24, 2023
@michae2 michae2 moved this from 23.2 Release to 24.1 Release in SQL Queries Sep 12, 2023
@mgartner mgartner added the P-3 Issues/test failures with no fix SLA label Nov 17, 2023
@mgartner mgartner changed the title sql: add cache collision testing sql: add query cache collision testing Nov 28, 2023
@yuzefovich yuzefovich moved this from 24.1 Release to 24.2 Release in SQL Queries Feb 27, 2024
@mgartner mgartner moved this from 24.2 Release to 24.3 Release in SQL Queries Jun 20, 2024
@mgartner mgartner moved this from 24.3 Release to Backlog in SQL Queries Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-postmortem Originated from a Postmortem action item. P-3 Issues/test failures with no fix SLA quality-friday A good issue to work on on Quality Friday T-sql-queries SQL Queries Team
Projects
SQL Queries
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@erikgrinaker @mgartner @michae2 @DrewKimball