Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: make probe request application cheap #103905

Closed
tbg opened this issue May 25, 2023 · 1 comment · Fixed by #102953
Closed

kvserver: make probe request application cheap #103905

tbg opened this issue May 25, 2023 · 1 comment · Fixed by #102953
Assignees
@tbg
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@tbg
Copy link
Member

tbg commented May 25, 2023 •
edited by exalate-issue-sync bot
Loading

NoopRequest should be the cheapest raft command to apply (since it's deterministically rejected below raft, i.e. only writes the LeaseAppliedState update) but accidentally it wasn't marked as a trivial ("batchable") command. We think this wildly inflates the cost of applying such a command, as seen in https://github.com/cockroachlabs/support/issues/2287.

We should fix this.

x-ref #102953

Jira issue: CRDB-28253

Epic CRDB-25287
@tbg tbg added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv-replication labels May 25, 2023
@tbg tbg self-assigned this May 25, 2023
@blathers-crl
Copy link

blathers-crl bot commented May 25, 2023

cc @cockroachdb/replication

@tbg tbg mentioned this issue Jun 6, 2023
Merged
@craig craig bot closed this as completed in 9080fc9 Jun 9, 2023
@blathers-crl blathers-crl bot mentioned this issue Jun 9, 2023
Merged
@tbg tbg mentioned this issue Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserverpb: mark probe requests' replicated cmds as IsTrivial tbg/cockroach
1 participant
@tbg