Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add a placeholder cluster setting for sql.show_ranges_deprecated_behavior.enabled in v22.2 #102818

Closed
jaylim-crl opened this issue May 5, 2023 · 1 comment
Closed

sql: add a placeholder cluster setting for sql.show_ranges_deprecated_behavior.enabled in v22.2 #102818

jaylim-crl opened this issue May 5, 2023 · 1 comment
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@jaylim-crl
Copy link
Collaborator

jaylim-crl commented May 5, 2023 •
edited by cockroach-jira-scripts
Loading

Related to #98979.

#98979 shipped backwards compatibility for SHOW RANGES, and the sql.show_ranges_deprecated_behavior.enabled cluster setting was defaulted to true to support existing clusters. Given that this would be the first time tenants will have that feature, it is not necessary to have that. We'd like to override that setting to false on all tenant clusters in CC. However, there's no easy way to do that since the setting is only available in v23.1+.

This issue requests to add a placeholder cluster setting for sql.show_ranges_deprecated_behavior.enabled on v22.2 so that the rollout on CC would be easier.

Related to https://cockroachlabs.atlassian.net/browse/CC-24516.

cc: @knz

Jira issue: CRDB-27668
@jaylim-crl jaylim-crl added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label May 5, 2023
@jaylim-crl jaylim-crl changed the title sql: add a placeholder cluster setting for sql.show_ranges_deprecated_behavior.enabled sql: add a placeholder cluster setting for sql.show_ranges_deprecated_behavior.enabled in v22.2 May 5, 2023
@knz knz mentioned this issue May 16, 2023
Merged
@jaylim-crl
Copy link
Collaborator Author

Fixed in #103400.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaylim-crl