Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing: sampling in event logs for better coverage #100790

Open
pav-kv opened this issue Apr 6, 2023 · 0 comments
Open

tracing: sampling in event logs for better coverage #100790

pav-kv opened this issue Apr 6, 2023 · 0 comments
Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-3 Issues/test failures with no fix SLA T-observability

Comments

@pav-kv
Copy link
Collaborator

pav-kv commented Apr 6, 2023

There are limits to the number and size of logs that traces can collect (see #87539). When the recording exceeds the limits, it gets trimmed [#88414]. Currently it retains only a tail of events in the log.

Sometimes it is useful to see both the beginning and the ending of a span. For example, the span below has many identical events (individual Get evaluations), and was truncated to display only a tail of a 30s period. It would be useful though to see the head of this span, to make sure there wasn't a slow start / blockage before this long list of evaluations kicked off.

trace

So, when trimming is necessary, maybe the sweet spot is in retaining both the head and the tail of the log, and removing events in the middle. More generally, the events in the middle can be sampled, to provide some coverage there too. If so, discontiguous parts of the log should be marked as such so that the engineer looking at it is not confused.

Jira issue: CRDB-26623

Epic CRDB-32402

@pav-kv pav-kv added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-observability-inf A-observability-inf labels Apr 6, 2023
@shralex shralex added the O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs label May 13, 2023
@dhartunian dhartunian added the P-3 Issues/test failures with no fix SLA label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability-inf C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-support Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs P-3 Issues/test failures with no fix SLA T-observability
Projects
None yet
Development

No branches or pull requests

3 participants