Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: audit replication upgrade tests #100687

Closed
4 tasks done
erikgrinaker opened this issue Apr 5, 2023 · 5 comments
Closed
4 tasks done

kvserver: audit replication upgrade tests #100687

erikgrinaker opened this issue Apr 5, 2023 · 5 comments
Assignees
@aliher1911
Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Apr 5, 2023 •
edited by aliher1911
Loading

See #100552.

The following are owned by replication:

  • TestBiDirectionalRangefeedNotUsedUntilUpgradeFinalilzed
  • TestMigrateWaitsForApplication
  • TestLeaseUpgradeVersionGate
  • TestRangeMigration

Marking as release blocker since the main issue is, but this feels more like a GA blocker.

Jira issue: CRDB-26556
@erikgrinaker erikgrinaker added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-testing Testing tools and infrastructure release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv-replication labels Apr 5, 2023
@blathers-crl
Copy link

blathers-crl bot commented Apr 5, 2023

Hi @erikgrinaker, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl
Copy link

blathers-crl bot commented Apr 5, 2023

cc @cockroachdb/replication

@erikgrinaker erikgrinaker added branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 labels Apr 5, 2023
@aliher1911
Copy link
Contributor

TestRangeMigration - is ok, it is using made up versions to verify that below raft migration infrastructure works and doesn't test any actual migrations.
TestLeaseUpgradeVersionGate - is ok as it only needs version to test version gates, we can bootstrap with latest data and do tests regardless.
TestMigrateWaitsForApplication - is ok as it is testing migration machinery rather than actual migration effects.
TestBiDirectionalRangefeedNotUsedUntilUpgradeFinalilzed - is ok, we only need version gate regardless of data.

@aliher1911
Copy link
Contributor

All good.

@erikgrinaker
Copy link
Contributor Author

Thanks, can you mirror that on #100552 please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aliher1911 aliher1911

Labels
A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikgrinaker @aliher1911