Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: limit concurrent lease requests #100426

Closed
erikgrinaker opened this issue Apr 2, 2023 · 0 comments · Fixed by #101098
Closed

kvserver: limit concurrent lease requests #100426

erikgrinaker opened this issue Apr 2, 2023 · 0 comments · Fixed by #101098
Labels
C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-kv KV Team

Comments

@erikgrinaker
Copy link
Contributor

erikgrinaker commented Apr 2, 2023

When #98433 lands, we should consider limiting the number of concurrent lease requests in flight, since we'll be extending 1/6 of all local leases every 500 ms, probably by using a semaphore during requestLease(). However, prioritization can be a bit tricky here -- for example, we probably want lease acquisitions that's blocking foreground traffic to take precedence over lease extensions for mostly-idle ranges.

We can also consider having a bounded goroutine pool for lease requests, instead of spawning new goroutines for these.

Jira issue: CRDB-26429

Epic CRDB-25207

@erikgrinaker erikgrinaker added C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-kv KV Team labels Apr 2, 2023
@erikgrinaker erikgrinaker changed the title kvserver: limit concurrent lease acquisitions kvserver: limit concurrent lease requests Apr 2, 2023
@craig craig bot closed this as completed in 117dc40 May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-performance Perf of queries or internals. Solution not expected to change functional behavior. T-kv KV Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant