From fd099403eb4ebed5112ce19d89ba81f642d35a3e Mon Sep 17 00:00:00 2001 From: Marylia Gutierrez Date: Thu, 14 Oct 2021 10:32:36 -0400 Subject: [PATCH] ui: fix default value of filter to All A recent commit changed the default value of filter to be an empty string, but we do have transactions that have no associated app names to it, so All and empty string should be treated as different cases. This commit reverse that changes and use All Release note (bug fix): Show All statements when filter All is selected and not only the ones with empty string --- pkg/ui/workspaces/cluster-ui/src/queryFilter/filter.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/ui/workspaces/cluster-ui/src/queryFilter/filter.tsx b/pkg/ui/workspaces/cluster-ui/src/queryFilter/filter.tsx index 37e3011a5473..35507021ca48 100644 --- a/pkg/ui/workspaces/cluster-ui/src/queryFilter/filter.tsx +++ b/pkg/ui/workspaces/cluster-ui/src/queryFilter/filter.tsx @@ -69,7 +69,7 @@ const timeUnit = [ ]; export const defaultFilters: Filters = { - app: "", + app: "All", timeNumber: "0", timeUnit: "seconds", fullScan: false, @@ -116,7 +116,7 @@ export const getFiltersFromQueryString = ( * we want to consider 0 active Filters */ export const inactiveFiltersState: Filters = { - app: "", + app: "All", timeNumber: "0", fullScan: false, sqlType: "",