From cf9195907d9e75cde403404e64fa8c160a8ab28f Mon Sep 17 00:00:00 2001 From: Stan Rosenberg Date: Mon, 3 Jul 2023 20:46:20 -0400 Subject: [PATCH] cmd/internal/issues: remove reproduction command in GH issue reporter Github issue reporter for failed unit tests contains an optional `HelpCommand` field which may include a reproduction command, supplied by `ReproductionCommandFromString`. The latter was returning a closure instead of being invoked. Upon further discussion, we decided to remove the call to `ReproductionCommandFromString` altogether since the included public wiki [1] already contains a description on how to reproduce a unit test failure. [1] https://cockroachlabs.atlassian.net/l/cp/HeeQsi6H Epic: none Release note: None --- pkg/cmd/internal/issues/formatter_unit.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/cmd/internal/issues/formatter_unit.go b/pkg/cmd/internal/issues/formatter_unit.go index 52d9a46b3b26..b5e70813f88e 100644 --- a/pkg/cmd/internal/issues/formatter_unit.go +++ b/pkg/cmd/internal/issues/formatter_unit.go @@ -144,7 +144,6 @@ var UnitTestFormatter = IssueFormatter{ // renders a reproduction command and helpful links. func UnitTestHelpCommand(repro string) func(r *Renderer) { return func(r *Renderer) { - ReproductionCommandFromString(repro) r.Escaped("\n") // need this newline or link won't render r.Escaped("See also: ") r.A("How To Investigate a Go Test Failure (internal)", "https://cockroachlabs.atlassian.net/l/c/HgfXfJgM")