From f5f95babd0d008513d213660c7d49b770070f170 Mon Sep 17 00:00:00 2001 From: Nick Travers Date: Tue, 28 Mar 2023 21:58:59 +0000 Subject: [PATCH] roachtest: add back backups to disk-stalled tests Backups were inadvertently disabled in #99747 (to simplify testing). As there is no good reason to run without them, re-enable the backups during the test. Release note: None. --- pkg/cmd/roachtest/tests/disk_stall.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/roachtest/tests/disk_stall.go b/pkg/cmd/roachtest/tests/disk_stall.go index 0c0918c986e0..5cdf669145d1 100644 --- a/pkg/cmd/roachtest/tests/disk_stall.go +++ b/pkg/cmd/roachtest/tests/disk_stall.go @@ -100,7 +100,7 @@ func registerDiskStalledDetection(r registry.Registry) { func runDiskStalledDetection( ctx context.Context, t test.Test, c cluster.Cluster, s diskStaller, doStall bool, ) { - startOpts := option.DefaultStartOptsNoBackups() + startOpts := option.DefaultStartOpts() startOpts.RoachprodOpts.ExtraArgs = []string{ "--store", s.DataDir(), "--log", fmt.Sprintf(`{sinks: {stderr: {filter: INFO}}, file-defaults: {dir: "%s"}}`, s.LogDir()),