From d64bed3ab612a293736a0adf2bd6fc0eb6bc3c24 Mon Sep 17 00:00:00 2001 From: Andrew Baptist Date: Mon, 11 Sep 2023 16:42:24 -0400 Subject: [PATCH] roachtest: fix logic for exact replication Previously the check for exact replication was incorrectly counting the number of replicas that were NOT at the desired replication count. This fortunately worked becase it was a no-op in the only place that used it since it was run immediately when all replicas had only a single replica. This correctly fixes the check. Epic: none Fixes: #109905 Fixes: #109906 Release note: None --- pkg/cmd/roachtest/tests/util.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/roachtest/tests/util.go b/pkg/cmd/roachtest/tests/util.go index 8e3df12bf6db..6b07dab5fbdf 100644 --- a/pkg/cmd/roachtest/tests/util.go +++ b/pkg/cmd/roachtest/tests/util.go @@ -105,7 +105,7 @@ func WaitForReplication( var compStr string switch waitForReplicationType { case exactlyReplicationFactor: - compStr = "=" + compStr = "!=" case atLeastReplicationFactor: compStr = "<" default: