From 44da1afa3b2f7dc34c0a5d1a8151f5436499649a Mon Sep 17 00:00:00 2001 From: Tobias Grieger Date: Wed, 19 Jan 2022 08:48:55 +0100 Subject: [PATCH] roachpb,kv/kvserver: skip TestReplicaUnavailableError under bazel Refs: #75108 Reason: flaky test Generated by bin/skip-test. Release justification: non-production code changes Release note: None --- pkg/kv/kvserver/replica_circuit_breaker_test.go | 2 ++ pkg/roachpb/BUILD.bazel | 1 + pkg/roachpb/replica_unavailable_error_test.go | 2 ++ 3 files changed, 5 insertions(+) diff --git a/pkg/kv/kvserver/replica_circuit_breaker_test.go b/pkg/kv/kvserver/replica_circuit_breaker_test.go index 79426fb0a1da..9b942094ceb3 100644 --- a/pkg/kv/kvserver/replica_circuit_breaker_test.go +++ b/pkg/kv/kvserver/replica_circuit_breaker_test.go @@ -17,6 +17,7 @@ import ( "github.com/cockroachdb/cockroach/pkg/kv/kvserver/liveness" "github.com/cockroachdb/cockroach/pkg/roachpb" "github.com/cockroachdb/cockroach/pkg/testutils/echotest" + "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/util/leaktest" "github.com/cockroachdb/cockroach/pkg/util/log" "github.com/cockroachdb/redact" @@ -25,6 +26,7 @@ import ( func TestReplicaUnavailableError(t *testing.T) { defer leaktest.AfterTest(t)() + skip.UnderBazelWithIssue(t, 75108, "flaky test") defer log.Scope(t).Close(t) var repls roachpb.ReplicaSet diff --git a/pkg/roachpb/BUILD.bazel b/pkg/roachpb/BUILD.bazel index c7281d1e5afb..0c82e01b508a 100644 --- a/pkg/roachpb/BUILD.bazel +++ b/pkg/roachpb/BUILD.bazel @@ -169,6 +169,7 @@ go_test( "//pkg/storage/enginepb", "//pkg/testutils/buildutil", "//pkg/testutils/echotest", + "//pkg/testutils/skip", "//pkg/testutils/zerofields", "//pkg/util", "//pkg/util/bitarray", diff --git a/pkg/roachpb/replica_unavailable_error_test.go b/pkg/roachpb/replica_unavailable_error_test.go index b31c941aca4a..b3838e1327c5 100644 --- a/pkg/roachpb/replica_unavailable_error_test.go +++ b/pkg/roachpb/replica_unavailable_error_test.go @@ -17,12 +17,14 @@ import ( "testing" "github.com/cockroachdb/cockroach/pkg/testutils/echotest" + "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/errors" "github.com/cockroachdb/redact" ) func TestReplicaUnavailableError(t *testing.T) { ctx := context.Background() + skip.UnderBazelWithIssue(t, 75108, "flaky test") var _ = (*ReplicaUnavailableError)(nil) rDesc := ReplicaDescriptor{NodeID: 1, StoreID: 2, ReplicaID: 3} var set ReplicaSet