From bea5b13f286e0a5cd26488fec68ad3cf51c58865 Mon Sep 17 00:00:00 2001 From: Aayush Shah Date: Sun, 31 Jan 2021 20:14:22 -0500 Subject: [PATCH] kvserver: remove rotten TODO This TODO was added in 2016 and the surrounding structure of the method has entirely changed in the intervening period. It doesn't make sense anymore as we do indeed handle heterogenous sets of replica constraints now. Release note: None --- pkg/kv/kvserver/allocator.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/kv/kvserver/allocator.go b/pkg/kv/kvserver/allocator.go index ca3b3665d346..99e2c493777a 100644 --- a/pkg/kv/kvserver/allocator.go +++ b/pkg/kv/kvserver/allocator.go @@ -362,7 +362,6 @@ func (a *Allocator) ComputeAction( func (a *Allocator) computeAction( ctx context.Context, zone *zonepb.ZoneConfig, voterReplicas []roachpb.ReplicaDescriptor, ) (AllocatorAction, float64) { - // TODO(mrtracy): Handle non-homogeneous and mismatched attribute sets. have := len(voterReplicas) decommissioningReplicas := a.storePool.decommissioningReplicas(voterReplicas) clusterNodes := a.storePool.ClusterNodeCount()