From ad2254b775ba9560a58c12f6d7e7154361fa9498 Mon Sep 17 00:00:00 2001
From: maryliag <marylia@cockroachlabs.com>
Date: Wed, 26 Apr 2023 16:22:21 -0400
Subject: [PATCH] server: log instead of returning error

This fix was made on the backport PRs from #102026,
but was missing on the original PR to master.

Part Of: #101948

Logs the error message, instead of returning an error,
so the endpoint can still work if there is an issue
on the activity tables.

Release note: None
---
 pkg/server/combined_statement_stats.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pkg/server/combined_statement_stats.go b/pkg/server/combined_statement_stats.go
index 0e394d7162d4..e33749875e61 100644
--- a/pkg/server/combined_statement_stats.go
+++ b/pkg/server/combined_statement_stats.go
@@ -983,7 +983,7 @@ func getStatementDetails(
 	if settings.Version.IsActive(ctx, clusterversion.V23_1AddSystemActivityTables) {
 		activityHasData, err = activityTablesHaveFullData(ctx, ie, testingKnobs, reqStartTime)
 		if err != nil {
-			return nil, serverError(ctx, err)
+			log.Errorf(ctx, "Error on getStatementDetails: %s", err)
 		}
 	}