From a5bbfcfc7adb276fcc799aafff67e26cb24cad97 Mon Sep 17 00:00:00 2001 From: Peter Mattis Date: Thu, 20 Apr 2017 11:51:29 -0400 Subject: [PATCH] storage: disable replica pointer tag The replica pointer tag was used for debugging #11591, which has been long since fixed. --- pkg/storage/replica.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/storage/replica.go b/pkg/storage/replica.go index f990bf068bf4..eb598e6f78aa 100644 --- a/pkg/storage/replica.go +++ b/pkg/storage/replica.go @@ -513,8 +513,9 @@ func newReplica(rangeID roachpb.RangeID, store *Store) *Replica { r.rangeStr.store(0, &roachpb.RangeDescriptor{RangeID: rangeID}) // Add replica log tag - the value is rangeStr.String(). r.AmbientContext.AddLogTag("r", &r.rangeStr) - // Add replica pointer value. - r.AmbientContext.AddLogTagStr("@", fmt.Sprintf("%x", unsafe.Pointer(r))) + // Add replica pointer value. NB: this was historically useful for debugging + // replica GC issues, but is a distraction at the moment. + // r.AmbientContext.AddLogTagStr("@", fmt.Sprintf("%x", unsafe.Pointer(r))) raftMuLogger := thresholdLogger( r.AnnotateCtx(context.Background()),