diff --git a/pkg/ccl/backupccl/backupdest/BUILD.bazel b/pkg/ccl/backupccl/backupdest/BUILD.bazel index 4aa866b186f7..0cf2086be24e 100644 --- a/pkg/ccl/backupccl/backupdest/BUILD.bazel +++ b/pkg/ccl/backupccl/backupdest/BUILD.bazel @@ -60,7 +60,6 @@ go_test( "//pkg/server", "//pkg/sql", "//pkg/testutils/serverutils", - "//pkg/testutils/skip", "//pkg/testutils/testcluster", "//pkg/util/hlc", "//pkg/util/leaktest", diff --git a/pkg/ccl/backupccl/backupdest/backup_destination_test.go b/pkg/ccl/backupccl/backupdest/backup_destination_test.go index 5ccd33734ba9..006d10b58e56 100644 --- a/pkg/ccl/backupccl/backupdest/backup_destination_test.go +++ b/pkg/ccl/backupccl/backupdest/backup_destination_test.go @@ -25,7 +25,6 @@ import ( "github.com/cockroachdb/cockroach/pkg/jobs/jobspb" "github.com/cockroachdb/cockroach/pkg/security/username" "github.com/cockroachdb/cockroach/pkg/sql" - "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/util/hlc" "github.com/cockroachdb/cockroach/pkg/util/leaktest" "github.com/cockroachdb/cockroach/pkg/util/log" @@ -39,8 +38,6 @@ func TestBackupRestoreResolveDestination(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderRace(t, "probable OOM") - tc, _, _, cleanupFn := backuptestutils.StartBackupRestoreTestCluster(t, backuptestutils.MultiNode) defer cleanupFn() diff --git a/pkg/ccl/backupccl/restore_span_covering_test.go b/pkg/ccl/backupccl/restore_span_covering_test.go index 3a2c6775e50f..c60e219f9d16 100644 --- a/pkg/ccl/backupccl/restore_span_covering_test.go +++ b/pkg/ccl/backupccl/restore_span_covering_test.go @@ -27,7 +27,6 @@ import ( "github.com/cockroachdb/cockroach/pkg/sql" "github.com/cockroachdb/cockroach/pkg/sql/execinfrapb" "github.com/cockroachdb/cockroach/pkg/testutils/serverutils" - "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/util/ctxgroup" "github.com/cockroachdb/cockroach/pkg/util/encoding" "github.com/cockroachdb/cockroach/pkg/util/hlc" @@ -723,8 +722,6 @@ func sanityCheckFileIterator( //lint:ignore U1000 unused func runTestRestoreEntryCover(t *testing.T, numBackups int) { - skip.UnderRace(t, "probable OOM") - r, _ := randutil.NewTestRand() ctx := context.Background() tc, _, _, cleanupFn := backupRestoreTestSetup(t, singleNode, 1, InitManualReplication) diff --git a/pkg/ccl/backupccl/testgen/templates.go b/pkg/ccl/backupccl/testgen/templates.go index 0e469e092f66..f7fe50d16be6 100644 --- a/pkg/ccl/backupccl/testgen/templates.go +++ b/pkg/ccl/backupccl/testgen/templates.go @@ -69,7 +69,6 @@ func TestDataDriven_{{.TestName}}(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) skip.UnderRace(t, "takes ~3mins to run") - skip.UnderDeadlock(t, "takes a very long time to run") runTestDataDriven(t, "{{.TestFilePath}}") } diff --git a/pkg/ccl/importerccl/BUILD.bazel b/pkg/ccl/importerccl/BUILD.bazel index eb14fc1ac2db..c9aee0353605 100644 --- a/pkg/ccl/importerccl/BUILD.bazel +++ b/pkg/ccl/importerccl/BUILD.bazel @@ -36,7 +36,6 @@ go_test( "//pkg/testutils", "//pkg/testutils/datapathutils", "//pkg/testutils/serverutils", - "//pkg/testutils/skip", "//pkg/testutils/sqlutils", "//pkg/testutils/testcluster", "//pkg/util/leaktest", diff --git a/pkg/ccl/importerccl/ccl_test.go b/pkg/ccl/importerccl/ccl_test.go index 788f29366fbe..e6d5bcce7ce4 100644 --- a/pkg/ccl/importerccl/ccl_test.go +++ b/pkg/ccl/importerccl/ccl_test.go @@ -34,7 +34,6 @@ import ( "github.com/cockroachdb/cockroach/pkg/testutils" "github.com/cockroachdb/cockroach/pkg/testutils/datapathutils" "github.com/cockroachdb/cockroach/pkg/testutils/serverutils" - "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/testutils/sqlutils" "github.com/cockroachdb/cockroach/pkg/testutils/testcluster" "github.com/cockroachdb/cockroach/pkg/util/leaktest" @@ -58,8 +57,6 @@ func TestImportMultiRegion(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderRaceWithIssue(t, 116049, "probable OOM") - baseDir := sharedTestdata(t) tc, sqlDB, cleanup := multiregionccltestutils.TestingCreateMultiRegionCluster( t, 3 /* numServers */, base.TestingKnobs{}, multiregionccltestutils.WithBaseDirectory(baseDir), @@ -306,8 +303,6 @@ func TestMultiRegionExportImportRoundTrip(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderRace(t, "probable OOM") - validateNumRows := func(sqlDB *gosql.DB, tableName string, expected int) { res := sqlDB.QueryRow(fmt.Sprintf(`SELECT count(*) FROM %s`, tableName)) require.NoError(t, res.Err()) diff --git a/pkg/ccl/kvccl/kvfollowerreadsccl/boundedstaleness_test.go b/pkg/ccl/kvccl/kvfollowerreadsccl/boundedstaleness_test.go index 00e6b6bfc5d3..78d89de8d93c 100644 --- a/pkg/ccl/kvccl/kvfollowerreadsccl/boundedstaleness_test.go +++ b/pkg/ccl/kvccl/kvfollowerreadsccl/boundedstaleness_test.go @@ -263,7 +263,6 @@ func TestBoundedStalenessDataDriven(t *testing.T) { defer log.Scope(t).Close(t) skip.UnderStress(t, "1μs staleness reads may actually succeed due to the slow environment") - skip.UnderRace(t, "probable OOM") defer ccl.TestingEnableEnterprise()() ctx := context.Background() diff --git a/pkg/ccl/kvccl/kvfollowerreadsccl/followerreads_test.go b/pkg/ccl/kvccl/kvfollowerreadsccl/followerreads_test.go index e4f9ab94fdd2..55afd8bcb21f 100644 --- a/pkg/ccl/kvccl/kvfollowerreadsccl/followerreads_test.go +++ b/pkg/ccl/kvccl/kvfollowerreadsccl/followerreads_test.go @@ -941,7 +941,7 @@ func TestSecondaryTenantFollowerReadsRouting(t *testing.T) { defer log.Scope(t).Close(t) defer utilccl.TestingEnableEnterprise()() - skip.UnderRace(t, "times out") + skip.UnderStressRace(t, "times out") for _, testCase := range []struct { name string diff --git a/pkg/ccl/logictestccl/tests/3node-tenant-multiregion/generated_test.go b/pkg/ccl/logictestccl/tests/3node-tenant-multiregion/generated_test.go index 5ce75607b9c8..325cd4ee290d 100644 --- a/pkg/ccl/logictestccl/tests/3node-tenant-multiregion/generated_test.go +++ b/pkg/ccl/logictestccl/tests/3node-tenant-multiregion/generated_test.go @@ -85,7 +85,6 @@ func runLogicTest(t *testing.T, file string) { logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(logicTestDir, file)) } func runCCLLogicTest(t *testing.T, file string) { - skip.UnderRace(t, "large engflow executor is overloaded by this config") skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file)) } diff --git a/pkg/ccl/logictestccl/tests/3node-tenant/generated_test.go b/pkg/ccl/logictestccl/tests/3node-tenant/generated_test.go index c1096447e645..19754e71902c 100644 --- a/pkg/ccl/logictestccl/tests/3node-tenant/generated_test.go +++ b/pkg/ccl/logictestccl/tests/3node-tenant/generated_test.go @@ -81,12 +81,10 @@ func TestMain(m *testing.M) { } func runLogicTest(t *testing.T, file string) { - skip.UnderRace(t, "large engflow executor is overloaded by 3node-tenant config") skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(logicTestDir, file)) } func runCCLLogicTest(t *testing.T, file string) { - skip.UnderRace(t, "large engflow executor is overloaded by this config") skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file)) } diff --git a/pkg/ccl/logictestccl/tests/multiregion-15node-5region-3azs/generated_test.go b/pkg/ccl/logictestccl/tests/multiregion-15node-5region-3azs/generated_test.go index f2d192ccf5e3..49fa99808619 100644 --- a/pkg/ccl/logictestccl/tests/multiregion-15node-5region-3azs/generated_test.go +++ b/pkg/ccl/logictestccl/tests/multiregion-15node-5region-3azs/generated_test.go @@ -60,7 +60,6 @@ func TestMain(m *testing.M) { } func runCCLLogicTest(t *testing.T, file string) { - skip.UnderRace(t, "large engflow executor is overloaded by this config") skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file)) } diff --git a/pkg/ccl/logictestccl/tests/multiregion-3node-3superlongregions/generated_test.go b/pkg/ccl/logictestccl/tests/multiregion-3node-3superlongregions/generated_test.go index 50975f377d51..ef561fba7e16 100644 --- a/pkg/ccl/logictestccl/tests/multiregion-3node-3superlongregions/generated_test.go +++ b/pkg/ccl/logictestccl/tests/multiregion-3node-3superlongregions/generated_test.go @@ -60,7 +60,6 @@ func TestMain(m *testing.M) { } func runCCLLogicTest(t *testing.T, file string) { - skip.UnderRace(t, "large engflow executor is overloaded by this config") skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file)) } diff --git a/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-no-los/generated_test.go b/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-no-los/generated_test.go index 74cf29008f23..a4f575f3f1b0 100644 --- a/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-no-los/generated_test.go +++ b/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-no-los/generated_test.go @@ -60,7 +60,6 @@ func TestMain(m *testing.M) { } func runCCLLogicTest(t *testing.T, file string) { - skip.UnderRace(t, "large engflow executor is overloaded by this config") skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file)) } diff --git a/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-tenant/generated_test.go b/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-tenant/generated_test.go index 24865f309f85..b3d602d7f12a 100644 --- a/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-tenant/generated_test.go +++ b/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-tenant/generated_test.go @@ -60,7 +60,6 @@ func TestMain(m *testing.M) { } func runCCLLogicTest(t *testing.T, file string) { - skip.UnderRace(t, "large engflow executor is overloaded by this config") skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file)) } diff --git a/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-vec-off/generated_test.go b/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-vec-off/generated_test.go index e42051b3097c..366feee839d6 100644 --- a/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-vec-off/generated_test.go +++ b/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs-vec-off/generated_test.go @@ -60,7 +60,6 @@ func TestMain(m *testing.M) { } func runCCLLogicTest(t *testing.T, file string) { - skip.UnderRace(t, "large engflow executor is overloaded by this config") skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file)) } diff --git a/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs/generated_test.go b/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs/generated_test.go index 5fe79d3fed15..2a28c2c150f7 100644 --- a/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs/generated_test.go +++ b/pkg/ccl/logictestccl/tests/multiregion-9node-3region-3azs/generated_test.go @@ -60,7 +60,6 @@ func TestMain(m *testing.M) { } func runCCLLogicTest(t *testing.T, file string) { - skip.UnderRace(t, "large engflow executor is overloaded by this config") skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file)) } diff --git a/pkg/ccl/serverccl/statusccl/tenant_grpc_test.go b/pkg/ccl/serverccl/statusccl/tenant_grpc_test.go index 37f1e62c6c5a..b899b2e59a9d 100644 --- a/pkg/ccl/serverccl/statusccl/tenant_grpc_test.go +++ b/pkg/ccl/serverccl/statusccl/tenant_grpc_test.go @@ -19,7 +19,6 @@ import ( "github.com/cockroachdb/cockroach/pkg/server/serverpb" "github.com/cockroachdb/cockroach/pkg/sql/sqlstats" "github.com/cockroachdb/cockroach/pkg/testutils/serverutils" - "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/testutils/sqlutils" "github.com/cockroachdb/cockroach/pkg/util/leaktest" "github.com/cockroachdb/cockroach/pkg/util/log" @@ -34,8 +33,6 @@ func TestTenantGRPCServices(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderRace(t, "probable OOM") - ctx := context.Background() testCluster := serverutils.StartCluster(t, 3, base.TestClusterArgs{ diff --git a/pkg/ccl/serverccl/statusccl/tenant_status_test.go b/pkg/ccl/serverccl/statusccl/tenant_status_test.go index cc7239effcf4..315a499f36a3 100644 --- a/pkg/ccl/serverccl/statusccl/tenant_status_test.go +++ b/pkg/ccl/serverccl/statusccl/tenant_status_test.go @@ -390,7 +390,6 @@ func TestTenantCannotSeeNonTenantStats(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) skip.UnderStressWithIssue(t, 113984) - skip.UnderRace(t, "may OOM") ctx := context.Background() testCluster := serverutils.StartCluster(t, 3 /* numNodes */, base.TestClusterArgs{ diff --git a/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/BUILD.bazel b/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/BUILD.bazel index 64069d26c950..846921c456b6 100644 --- a/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/BUILD.bazel +++ b/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/BUILD.bazel @@ -34,7 +34,6 @@ go_test( "//pkg/sql/catalog/tabledesc", "//pkg/testutils/datapathutils", "//pkg/testutils/serverutils", - "//pkg/testutils/skip", "//pkg/testutils/sqlutils", "//pkg/testutils/testcluster", "//pkg/util/leaktest", diff --git a/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/datadriven_test.go b/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/datadriven_test.go index c9a3c0318e2e..6727e41eac5f 100644 --- a/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/datadriven_test.go +++ b/pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/datadriven_test.go @@ -33,7 +33,6 @@ import ( "github.com/cockroachdb/cockroach/pkg/sql/catalog/descs" "github.com/cockroachdb/cockroach/pkg/sql/catalog/tabledesc" "github.com/cockroachdb/cockroach/pkg/testutils/datapathutils" - "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/testutils/sqlutils" "github.com/cockroachdb/cockroach/pkg/testutils/testcluster" "github.com/cockroachdb/cockroach/pkg/util/leaktest" @@ -81,9 +80,6 @@ import ( // Releases the protected timestamp record with id. func TestDataDriven(t *testing.T) { t.Cleanup(leaktest.AfterTest(t)) - - skip.UnderRace(t, "likely to time out") - scope := log.Scope(t) t.Cleanup(func() { scope.Close(t) diff --git a/pkg/ccl/streamingccl/streamingest/replication_stream_e2e_test.go b/pkg/ccl/streamingccl/streamingest/replication_stream_e2e_test.go index 2c916409ff90..1ac200091096 100644 --- a/pkg/ccl/streamingccl/streamingest/replication_stream_e2e_test.go +++ b/pkg/ccl/streamingccl/streamingest/replication_stream_e2e_test.go @@ -681,7 +681,7 @@ func TestStreamingAutoReplan(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderRace(t, "multi cluster/node config exhausts hardware") + skip.UnderStressRace(t, "multi cluster/node config exhausts hardware") ctx := context.Background() args := replicationtestutils.DefaultTenantStreamingClustersArgs @@ -1209,7 +1209,7 @@ func TestLoadProducerAndIngestionProgress(t *testing.T) { func TestStreamingRegionalConstraint(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderRace(t, "takes too long under stress race") + skip.UnderStressRace(t, "takes too long under stress race") ctx := context.Background() regions := []string{"mars", "venus", "mercury"} diff --git a/pkg/cmd/generate-logictest/main.go b/pkg/cmd/generate-logictest/main.go index cad366cc2d34..984ec4dd38ec 100644 --- a/pkg/cmd/generate-logictest/main.go +++ b/pkg/cmd/generate-logictest/main.go @@ -32,8 +32,6 @@ type testFileTemplateConfig struct { CockroachGoTestserverTest bool Ccl bool ForceProductionValues bool - IsMultiRegion bool - Is3NodeTenant bool Package, TestRuleName, RelDir string ConfigIdx int TestCount int @@ -176,8 +174,6 @@ func (t *testdir) dump() error { tplCfg.RelDir = t.relPathToParent tplCfg.TestCount = testCount tplCfg.CockroachGoTestserverTest = cfg.UseCockroachGoTestserver - tplCfg.IsMultiRegion = strings.Contains(cfg.Name, "multiregion") - tplCfg.Is3NodeTenant = strings.HasSuffix(cfg.Name, "3node-tenant") // The NumCPU calculation is a guess pulled out of thin air to // allocate the tests which use 3-node clusters 2 vCPUs, and // the ones which use more a bit more. diff --git a/pkg/cmd/generate-logictest/templates.go b/pkg/cmd/generate-logictest/templates.go index e773bd8eb0d6..58c764d6c38a 100644 --- a/pkg/cmd/generate-logictest/templates.go +++ b/pkg/cmd/generate-logictest/templates.go @@ -51,11 +51,7 @@ const templateText = ` {{- define "runLogicTest" }} {{- if .LogicTest -}} func runLogicTest(t *testing.T, file string) { - {{ if .Is3NodeTenant }}skip.UnderRace(t, "large engflow executor is overloaded by 3node-tenant config") - {{ else if eq .TestRuleName "local"}}if file == "lookup_join_local" { - skip.UnderRace(t, "this file is too slow under race") - } - {{ end }}skip.UnderDeadlock(t, "times out and/or hangs") + skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(logicTestDir, file)) } {{ end }} @@ -64,8 +60,7 @@ func runLogicTest(t *testing.T, file string) { {{- define "runCCLLogicTest" }} {{- if .CclLogicTest -}} func runCCLLogicTest(t *testing.T, file string) { - {{ if or .IsMultiRegion .Is3NodeTenant }}skip.UnderRace(t, "large engflow executor is overloaded by this config") - {{ end }}skip.UnderDeadlock(t, "times out and/or hangs") + skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(cclLogicTestDir, file)) } {{ end }} diff --git a/pkg/kv/kvserver/batcheval/cmd_add_sstable_test.go b/pkg/kv/kvserver/batcheval/cmd_add_sstable_test.go index 738c14347593..fc24751ab6d8 100644 --- a/pkg/kv/kvserver/batcheval/cmd_add_sstable_test.go +++ b/pkg/kv/kvserver/batcheval/cmd_add_sstable_test.go @@ -32,7 +32,6 @@ import ( "github.com/cockroachdb/cockroach/pkg/storage/fs" "github.com/cockroachdb/cockroach/pkg/testutils" "github.com/cockroachdb/cockroach/pkg/testutils/serverutils" - "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/testutils/storageutils" "github.com/cockroachdb/cockroach/pkg/util" "github.com/cockroachdb/cockroach/pkg/util/hlc" @@ -49,8 +48,6 @@ func TestEvalAddSSTable(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderDeadlock(t, "probable OOM") - storage.DisableMetamorphicSimpleValueEncoding(t) const intentTS = 100 // values with this timestamp are written as intents diff --git a/pkg/kv/kvserver/loqrecovery/server_integration_test.go b/pkg/kv/kvserver/loqrecovery/server_integration_test.go index 858ca16d9061..0d90b053b8f6 100644 --- a/pkg/kv/kvserver/loqrecovery/server_integration_test.go +++ b/pkg/kv/kvserver/loqrecovery/server_integration_test.go @@ -478,8 +478,6 @@ func TestRetrieveRangeStatus(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderRace(t, "probable OOM") - ctx := context.Background() tc, _, _ := prepTestCluster(t, 5) @@ -535,8 +533,6 @@ func TestRetrieveApplyStatus(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderRace(t, "probable OOM") - ctx := context.Background() tc, _, _ := prepTestCluster(t, 5) diff --git a/pkg/kv/kvserver/replica_application_result.go b/pkg/kv/kvserver/replica_application_result.go index 0ed13dcd9477..e3ee7fef4f38 100644 --- a/pkg/kv/kvserver/replica_application_result.go +++ b/pkg/kv/kvserver/replica_application_result.go @@ -407,13 +407,14 @@ func (r *Replica) tryReproposeWithNewLeaseIndex(ctx context.Context, origCmd *re // The tracker wants us to forward the request timestamp, but we can't // do that without re-evaluating, so give up. The error returned here // will go to back to DistSender, so send something it can digest. - err := kvpb.NewNotLeaseHolderError( + r.mu.RLock() + defer r.mu.RUnlock() + return kvpb.NewNotLeaseHolderError( *r.mu.state.Lease, r.store.StoreID(), r.mu.state.Desc, "reproposal failed due to closed timestamp", ) - return err } // Some tests check for this log message in the trace. log.VEventf(ctx, 2, "retry: proposalIllegalLeaseIndex") diff --git a/pkg/kv/kvserver/replica_learner_test.go b/pkg/kv/kvserver/replica_learner_test.go index d0e9f1ffef98..3f0227bc2937 100644 --- a/pkg/kv/kvserver/replica_learner_test.go +++ b/pkg/kv/kvserver/replica_learner_test.go @@ -1367,9 +1367,6 @@ func TestReplicaGCQueueSeesLearnerOrJointConfig(t *testing.T) { func TestRaftSnapshotQueueSeesLearner(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - - skip.UnderRace(t, "probable OOM") - ctx := context.Background() blockSnapshotsCh := make(chan struct{}) knobs, ltk := makeReplicationTestKnobs() diff --git a/pkg/kv/kvserver/reports/reporter_test.go b/pkg/kv/kvserver/reports/reporter_test.go index efd1db852ee2..3189aac52717 100644 --- a/pkg/kv/kvserver/reports/reporter_test.go +++ b/pkg/kv/kvserver/reports/reporter_test.go @@ -125,9 +125,6 @@ func TestConstraintConformanceReportIntegration(t *testing.T) { func TestCriticalLocalitiesReportIntegration(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - - skip.UnderRace(t, "likely to timeout") - ctx := context.Background() // 2 regions, 3 dcs per region. tc := serverutils.StartCluster(t, 6, base.TestClusterArgs{ diff --git a/pkg/server/application_api/schema_inspection_test.go b/pkg/server/application_api/schema_inspection_test.go index cb5d21050baa..9f9f3afbe092 100644 --- a/pkg/server/application_api/schema_inspection_test.go +++ b/pkg/server/application_api/schema_inspection_test.go @@ -480,7 +480,6 @@ func TestAdminAPITableStats(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderDeadlock(t, "low ScanMaxIdleTime and deadlock overloads the EngFlow executor") skip.UnderStress(t, "flaky under stress #107156") skip.UnderRace(t, "flaky under race #107156") diff --git a/pkg/server/application_api/stats_test.go b/pkg/server/application_api/stats_test.go index cc4597593f4c..f2ab8c819cdc 100644 --- a/pkg/server/application_api/stats_test.go +++ b/pkg/server/application_api/stats_test.go @@ -30,7 +30,6 @@ import ( "github.com/cockroachdb/cockroach/pkg/testutils" "github.com/cockroachdb/cockroach/pkg/testutils/diagutils" "github.com/cockroachdb/cockroach/pkg/testutils/serverutils" - "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/testutils/sqlutils" "github.com/cockroachdb/cockroach/pkg/util/leaktest" "github.com/cockroachdb/cockroach/pkg/util/log" @@ -42,8 +41,6 @@ func TestTelemetrySQLStatsIndependence(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderDeadlockWithIssue(t, 115914, "likely to time out") - ctx := context.Background() var params base.TestServerArgs params.Knobs.SQLStatsKnobs = sqlstats.CreateTestingKnobs() diff --git a/pkg/server/application_api/stmtdiag_test.go b/pkg/server/application_api/stmtdiag_test.go index 0432404854a4..283fc19b985c 100644 --- a/pkg/server/application_api/stmtdiag_test.go +++ b/pkg/server/application_api/stmtdiag_test.go @@ -24,7 +24,6 @@ import ( "github.com/cockroachdb/cockroach/pkg/sql/sessiondata" "github.com/cockroachdb/cockroach/pkg/testutils" "github.com/cockroachdb/cockroach/pkg/testutils/serverutils" - "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/testutils/sqlutils" "github.com/cockroachdb/cockroach/pkg/util/leaktest" "github.com/cockroachdb/cockroach/pkg/util/log" @@ -232,8 +231,6 @@ func TestStatementDiagnosticsDoesNotReturnExpiredRequests(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) - skip.UnderDeadlockWithIssue(t, 115914, "likely to time out") - s, sqlDB, _ := serverutils.StartServer(t, base.TestServerArgs{}) defer s.Stopper().Stop(context.Background()) db := sqlutils.MakeSQLRunner(sqlDB) diff --git a/pkg/sql/catalog/lease/lease_test.go b/pkg/sql/catalog/lease/lease_test.go index 448ce40ebcdd..87f7fa962bda 100644 --- a/pkg/sql/catalog/lease/lease_test.go +++ b/pkg/sql/catalog/lease/lease_test.go @@ -1829,8 +1829,6 @@ func TestLeaseRenewedPeriodically(testingT *testing.T) { defer leaktest.AfterTest(testingT)() defer log.Scope(testingT).Close(testingT) - skip.UnderDeadlockWithIssue(testingT, 115910, "likely to time out") - ctx := context.Background() var mu syncutil.Mutex diff --git a/pkg/sql/logictest/tests/local/generated_test.go b/pkg/sql/logictest/tests/local/generated_test.go index 6227cb941e0d..3100cc9efa8e 100644 --- a/pkg/sql/logictest/tests/local/generated_test.go +++ b/pkg/sql/logictest/tests/local/generated_test.go @@ -60,9 +60,6 @@ func TestMain(m *testing.M) { } func runLogicTest(t *testing.T, file string) { - if file == "lookup_join_local" { - skip.UnderRace(t, "this file is too slow under race") - } skip.UnderDeadlock(t, "times out and/or hangs") logictest.RunLogicTest(t, logictest.TestServerArgs{}, configIdx, filepath.Join(logicTestDir, file)) } diff --git a/pkg/sql/sqlstats/persistedsqlstats/reader_test.go b/pkg/sql/sqlstats/persistedsqlstats/reader_test.go index fa57ef33872f..ff468b202ff2 100644 --- a/pkg/sql/sqlstats/persistedsqlstats/reader_test.go +++ b/pkg/sql/sqlstats/persistedsqlstats/reader_test.go @@ -185,6 +185,8 @@ func TestSQLStatsWithMultipleIdxRec(t *testing.T) { defer leaktest.AfterTest(t)() defer log.Scope(t).Close(t) + skip.UnderStressRace(t, "expensive tests") + fakeTime := stubTime{ aggInterval: time.Hour, }