From 53f21e07f7522a07961f4ba505bd1e754ac2a8a2 Mon Sep 17 00:00:00 2001 From: Tobias Grieger Date: Mon, 7 Mar 2022 13:47:56 +0100 Subject: [PATCH] kvserver: remove "not observed below raft" assertion This "meta test" intercepts all protos below raft and makes assertions about them. In particular, it was injecting a nonzero exit code if one of the tracked protos was *not* seen (so that we could stop tracking it). But in a bazel world where sharding is the norm, you can't really expect any given shard to see all of the protos. Take out this particular assertion. Release justification: testing-only fix Release note: None --- pkg/kv/kvserver/main_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/kv/kvserver/main_test.go b/pkg/kv/kvserver/main_test.go index cb2ceefbb118..81e3d2bd7af8 100644 --- a/pkg/kv/kvserver/main_test.go +++ b/pkg/kv/kvserver/main_test.go @@ -87,7 +87,8 @@ func TestMain(m *testing.M) { delete(notBelowRaftProtos, reflect.TypeOf(&roachpb.InternalTimeSeriesData{})) delete(notBelowRaftProtos, reflect.TypeOf(&enginepb.MVCCMetadataSubsetForMergeSerialization{})) for typ := range notBelowRaftProtos { - failed = true + // NB: don't set failed=true. In a bazel world, we may just end up sharding in a way that + // doesn't observe some of the protos below raft. fmt.Printf("%s: not observed below raft!\n", typ) }