From 247abb5588c0c929b5f7ced3b96387fedad9a1f9 Mon Sep 17 00:00:00 2001 From: Renato Costa Date: Thu, 19 Oct 2023 16:06:58 -0400 Subject: [PATCH] roachprod: remove `WaitDelay` call in `localSession` This call was added during work on #111064 as an attempt to fix issues during development. It should not be needed for correctness. It also makes backporting that work to 23.1 not possible, since the `WaitDelay` API was introduced in Go 1.20. Epic: none Release note: None --- pkg/roachprod/install/session.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkg/roachprod/install/session.go b/pkg/roachprod/install/session.go index de97eb85dbac..bde0ed2d961d 100644 --- a/pkg/roachprod/install/session.go +++ b/pkg/roachprod/install/session.go @@ -18,7 +18,6 @@ import ( "os/exec" "path/filepath" "sync" - "time" "github.com/cockroachdb/cockroach/pkg/roachprod/config" rperrors "github.com/cockroachdb/cockroach/pkg/roachprod/errors" @@ -246,7 +245,6 @@ type localSession struct { func newLocalSession(cmd string) *localSession { ctx, cancel := context.WithCancel(context.Background()) fullCmd := exec.CommandContext(ctx, "/bin/bash", "-c", cmd) - fullCmd.WaitDelay = time.Second return &localSession{fullCmd, cancel} }