From 409102309c807f819d7246256131e54227683d84 Mon Sep 17 00:00:00 2001 From: Jackson Owens Date: Mon, 11 Sep 2023 21:58:01 +0000 Subject: [PATCH] storage: skip TestMVCCScanWithLargeKeyValue under race This test results in the creation of a large (~7MB) sstable block. The resulting memory copy to an in-memory file's buffer may be excessively slow in race builds, triggering the disk-stall detector. Skip this test under race builds. Epic: none Informs #110308. Release note: none --- pkg/storage/pebble_mvcc_scanner_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/storage/pebble_mvcc_scanner_test.go b/pkg/storage/pebble_mvcc_scanner_test.go index e47433608390..74b032992417 100644 --- a/pkg/storage/pebble_mvcc_scanner_test.go +++ b/pkg/storage/pebble_mvcc_scanner_test.go @@ -21,6 +21,7 @@ import ( "github.com/cockroachdb/cockroach/pkg/roachpb" "github.com/cockroachdb/cockroach/pkg/settings/cluster" "github.com/cockroachdb/cockroach/pkg/storage/enginepb" + "github.com/cockroachdb/cockroach/pkg/testutils/skip" "github.com/cockroachdb/cockroach/pkg/util/hlc" "github.com/cockroachdb/cockroach/pkg/util/leaktest" "github.com/cockroachdb/cockroach/pkg/util/mon" @@ -124,6 +125,8 @@ func TestMVCCScanWithManyVersionsAndSeparatedIntents(t *testing.T) { func TestMVCCScanWithLargeKeyValue(t *testing.T) { defer leaktest.AfterTest(t)() + // This test has been observed to trip the disk-stall detector under -race. + skip.UnderRace(t, "large copies and memfs mutexes can cause excessive delays within VFS stack") eng := createTestPebbleEngine() defer eng.Close()