From 4b2b4b8169e0d9ebb35b3c0fb5ba6d1d5e56d07d Mon Sep 17 00:00:00 2001 From: Arul Ajmani Date: Wed, 22 Mar 2023 18:54:20 -0400 Subject: [PATCH] txnwait: do not require vmodule to log deadlocks in a workload Deadlocks in a workload are rare (and bad) enough that they should be logged at the level of Info, instead of under vmodule. Epic: none Release note: None --- pkg/kv/kvserver/txnwait/queue.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/kv/kvserver/txnwait/queue.go b/pkg/kv/kvserver/txnwait/queue.go index 0d2267073300..31d04ee04717 100644 --- a/pkg/kv/kvserver/txnwait/queue.go +++ b/pkg/kv/kvserver/txnwait/queue.go @@ -719,9 +719,8 @@ func (q *Queue) waitForPush( // Break the deadlock if the pusher has higher priority. p1, p2 := pusheePriority, pusherPriority if p1 < p2 || (p1 == p2 && bytes.Compare(req.PusheeTxn.ID.GetBytes(), req.PusherTxn.ID.GetBytes()) < 0) { - log.VEventf( + log.Infof( ctx, - 1, "%s breaking deadlock by force push of %s; dependencies=%s", req.PusherTxn.ID.Short(), req.PusheeTxn.ID.Short(),