From 3d0303324ec932661425b10998639f4bd26aaebf Mon Sep 17 00:00:00 2001 From: Ricky Stewart Date: Mon, 19 Apr 2021 10:22:21 -0500 Subject: [PATCH] build: upgrade go to 1.15.11 Pick up fixes to the following Go bugs: * https://github.com/golang/go/issues/45076 * https://github.com/golang/go/issues/45187 * https://github.com/golang/go/issues/42884 * [ ] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [x] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Bump the version in `WORKSPACE` under `go_register_toolchains`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). * [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [ ] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [ ] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh#L40-42)). * [x] Replace other mentions of the older version of go (grep for `golang:` and `go`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [x] Adjust `GO_VERSION` in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) and ask the Developer Infrastructure team to deploy new images. Resolves #63836. Release note (general change): Upgrade the CRDB binary to Go 1.15.10 --- WORKSPACE | 2 +- build/bootstrap/bootstrap-debian.sh | 4 ++-- build/builder.sh | 2 +- build/builder/Dockerfile | 4 ++-- build/packer/teamcity-agent.sh | 4 ++-- pkg/cmd/roachtest/go_helpers.go | 4 ++-- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/WORKSPACE b/WORKSPACE index dca36599ba4a..e9102c1adb1e 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -108,7 +108,7 @@ load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_depe go_rules_dependencies() -go_register_toolchains(go_version = "1.15.10") +go_register_toolchains(go_version = "1.15.11") # Configure nodeJS. load("@build_bazel_rules_nodejs//:index.bzl", "yarn_install") diff --git a/build/bootstrap/bootstrap-debian.sh b/build/bootstrap/bootstrap-debian.sh index 07dea0a03ca5..4783eea4e84b 100755 --- a/build/bootstrap/bootstrap-debian.sh +++ b/build/bootstrap/bootstrap-debian.sh @@ -46,9 +46,9 @@ sudo tar -C /usr -zxf /tmp/cmake.tgz && rm /tmp/cmake.tgz # Install Go. trap 'rm -f /tmp/go.tgz' EXIT -curl -fsSL https://dl.google.com/go/go1.15.10.linux-amd64.tar.gz > /tmp/go.tgz +curl -fsSL https://dl.google.com/go/go1.15.11.linux-amd64.tar.gz > /tmp/go.tgz sha256sum -c - < /tmp/go.tgz +curl -fsSL https://dl.google.com/go/go1.15.11.linux-amd64.tar.gz > /tmp/go.tgz sha256sum -c - < /tmp/go.tgz`, + ctx, c, node, "download go", `curl -fsSL https://dl.google.com/go/go1.15.11.linux-amd64.tar.gz > /tmp/go.tgz`, ); err != nil { t.Fatal(err) } if err := repeatRunE( ctx, c, node, "verify tarball", `sha256sum -c - <