-
Notifications
You must be signed in to change notification settings - Fork 3.8k
/
queue.go
799 lines (738 loc) · 25.7 KB
/
queue.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
// Copyright 2017 The Cockroach Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
// implied. See the License for the specific language governing
// permissions and limitations under the License.
package txnwait
import (
"bytes"
"context"
"sync/atomic"
"time"
"github.com/cockroachdb/cockroach/pkg/base"
"github.com/cockroachdb/cockroach/pkg/internal/client"
"github.com/cockroachdb/cockroach/pkg/roachpb"
"github.com/cockroachdb/cockroach/pkg/storage/engine/enginepb"
"github.com/cockroachdb/cockroach/pkg/util/hlc"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/cockroach/pkg/util/retry"
"github.com/cockroachdb/cockroach/pkg/util/stop"
"github.com/cockroachdb/cockroach/pkg/util/syncutil"
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
"github.com/cockroachdb/cockroach/pkg/util/uuid"
)
const maxWaitForQueryTxn = 50 * time.Millisecond
// ShouldPushImmediately returns whether the PushTxn request should
// proceed without queueing. This is true for pushes which are neither
// ABORT nor TIMESTAMP, but also for ABORT and TIMESTAMP pushes where
// the pushee has min priority or pusher has max priority.
func ShouldPushImmediately(req *roachpb.PushTxnRequest) bool {
if !(req.PushType == roachpb.PUSH_ABORT || req.PushType == roachpb.PUSH_TIMESTAMP) {
return true
}
p1, p2 := req.PusherTxn.Priority, req.PusheeTxn.Priority
if p1 > p2 && (p1 == roachpb.MaxTxnPriority || p2 == roachpb.MinTxnPriority) {
return true
}
return false
}
// isPushed returns whether the PushTxn request has already been
// fulfilled by the current transaction state. This may be true
// for transactions with pushed timestamps.
func isPushed(req *roachpb.PushTxnRequest, txn *roachpb.Transaction) bool {
return (txn.Status != roachpb.PENDING ||
(req.PushType == roachpb.PUSH_TIMESTAMP && req.PushTo.Less(txn.Timestamp)))
}
// TxnExpiration is the timestamp after which the transaction will be considered expired.
func TxnExpiration(txn *roachpb.Transaction) hlc.Timestamp {
return txn.LastActive().Add(2*base.DefaultHeartbeatInterval.Nanoseconds(), 0)
}
// IsExpired is true if the given transaction is expired.
func IsExpired(now hlc.Timestamp, txn *roachpb.Transaction) bool {
return TxnExpiration(txn).Less(now)
}
// createPushTxnResponse returns a PushTxnResponse struct with a
// copy of the supplied transaction. It is necessary to fully copy
// each field in the transaction to avoid race conditions.
func createPushTxnResponse(txn *roachpb.Transaction) *roachpb.PushTxnResponse {
return &roachpb.PushTxnResponse{PusheeTxn: txn.Clone()}
}
// A waitingPush represents a PushTxn command that is waiting on the
// pushee transaction to commit or abort. It maintains a transitive
// set of all txns which are waiting on this txn in order to detect
// dependency cycles.
type waitingPush struct {
req *roachpb.PushTxnRequest
// pending channel receives updated, pushed txn or nil if queue is cleared.
pending chan *roachpb.Transaction
mu struct {
syncutil.Mutex
dependents map[uuid.UUID]struct{} // transitive set of txns waiting on this txn
}
}
// A waitingQuery represents a QueryTxn command that is waiting on
// a target transaction to change status or acquire new dependencies.
type waitingQuery struct {
req *roachpb.QueryTxnRequest
pending chan struct{}
}
// A pendingTxn represents a transaction waiting to be pushed by one
// or more PushTxn requests.
type pendingTxn struct {
txn atomic.Value // the most recent txn record
waitingPushes []*waitingPush
}
func (pt *pendingTxn) getTxn() *roachpb.Transaction {
return pt.txn.Load().(*roachpb.Transaction)
}
func (pt *pendingTxn) getDependentsSet() map[uuid.UUID]struct{} {
set := map[uuid.UUID]struct{}{}
for _, push := range pt.waitingPushes {
if id := push.req.PusherTxn.ID; id != (uuid.UUID{}) {
set[id] = struct{}{}
push.mu.Lock()
if push.mu.dependents != nil {
for txnID := range push.mu.dependents {
set[txnID] = struct{}{}
}
}
push.mu.Unlock()
}
}
return set
}
// StoreInterface provides some parts of a Store without incurring a dependency.
type StoreInterface interface {
Clock() *hlc.Clock
Stopper() *stop.Stopper
DB() *client.DB
}
// ReplicaInterface provides some parts of a Replica without incurring a dependency.
type ReplicaInterface interface {
ContainsKey(roachpb.Key) bool
}
// Queue enqueues PushTxn requests which are waiting on extant txns
// with conflicting intents to abort or commit.
//
// Internally, it maintains a map from extant txn IDs to queues of pending
// PushTxn requests.
//
// When a write intent is encountered, the command which encountered it (called
// the "pusher" here) initiates a PushTxn request to determine the disposition
// of the intent's transaction (called the "pushee" here). This queue is where a
// PushTxn request will wait if it discovers that the pushee's transaction is
// still pending, and cannot be otherwise aborted or pushed forward.
//
// Queue is thread safe.
type Queue struct {
store StoreInterface
mu struct {
syncutil.Mutex
txns map[uuid.UUID]*pendingTxn
queries map[uuid.UUID][]*waitingQuery
}
}
// NewQueue instantiates a new Queue.
func NewQueue(store StoreInterface) *Queue {
return &Queue{
store: store,
}
}
// Enable allows transactions to be enqueued and waiting pushers
// added. This method must be idempotent as it can be invoked multiple
// times as range leases are updated for the same replica.
func (q *Queue) Enable() {
q.mu.Lock()
defer q.mu.Unlock()
if q.mu.txns == nil {
q.mu.txns = map[uuid.UUID]*pendingTxn{}
}
if q.mu.queries == nil {
q.mu.queries = map[uuid.UUID][]*waitingQuery{}
}
}
// Clear empties the queue and returns all waiters. This method should
// be invoked when the replica loses or transfers its lease. If
// `disable` is true, future transactions may not be enqueued or
// waiting pushers added. Call Enable() once the lease is again
// acquired by the replica.
func (q *Queue) Clear(disable bool) {
q.mu.Lock()
var pushWaiters []chan *roachpb.Transaction
for _, pt := range q.mu.txns {
for _, w := range pt.waitingPushes {
pushWaiters = append(pushWaiters, w.pending)
}
pt.waitingPushes = nil
}
var queryWaiters []chan struct{}
for _, waitingQueries := range q.mu.queries {
for _, w := range waitingQueries {
queryWaiters = append(queryWaiters, w.pending)
}
}
if log.V(1) {
log.Infof(
context.Background(),
"clearing %d push waiters and %d query waiters",
len(pushWaiters),
len(queryWaiters),
)
}
if disable {
q.mu.txns = nil
q.mu.queries = nil
} else {
q.mu.txns = map[uuid.UUID]*pendingTxn{}
q.mu.queries = map[uuid.UUID][]*waitingQuery{}
}
q.mu.Unlock()
// Send on the pending push waiter channels outside of the mutex lock.
for _, w := range pushWaiters {
w <- nil
}
// Close query waiters outside of the mutex lock.
for _, w := range queryWaiters {
close(w)
}
}
// IsEnabled is true if the queue is enabled.
func (q *Queue) IsEnabled() bool {
q.mu.Lock()
defer q.mu.Unlock()
return q.mu.txns != nil
}
// Enqueue creates a new pendingTxn for the target txn of a failed
// PushTxn command. Subsequent PushTxn requests for the same txn
// will be enqueued behind the pendingTxn via MaybeWait().
func (q *Queue) Enqueue(txn *roachpb.Transaction) {
q.mu.Lock()
defer q.mu.Unlock()
if q.mu.txns == nil {
// Not enabled; do nothing.
return
}
// If the txn which failed to push is already pending, update the
// transaction status.
if pt, ok := q.mu.txns[txn.ID]; ok {
pt.txn.Store(txn)
} else {
pt = &pendingTxn{}
pt.txn.Store(txn)
q.mu.txns[txn.ID] = pt
}
}
// UpdateTxn is invoked to update a transaction's status after a
// successful PushTxn or EndTransaction command. It unblocks all
// pending waiters.
func (q *Queue) UpdateTxn(ctx context.Context, txn *roachpb.Transaction) {
txn.AssertInitialized(ctx)
q.mu.Lock()
if log.V(1) {
if count := len(q.mu.queries[txn.ID]); count > 0 {
log.Infof(ctx, "returning %d waiting queries for %s", count, txn.ID.Short())
}
}
for _, w := range q.mu.queries[txn.ID] {
close(w.pending)
}
delete(q.mu.queries, txn.ID)
if q.mu.txns == nil {
// Not enabled; do nothing.
q.mu.Unlock()
return
}
pending, ok := q.mu.txns[txn.ID]
if !ok {
q.mu.Unlock()
return
}
waitingPushes := pending.waitingPushes
pending.waitingPushes = nil
delete(q.mu.txns, txn.ID)
pending.txn.Store(txn)
q.mu.Unlock()
if log.V(1) && len(waitingPushes) > 0 {
log.Infof(context.Background(), "updating %d push waiters for %s", len(waitingPushes), txn.ID.Short())
}
// Send on pending waiter channels outside of the mutex lock.
for _, w := range waitingPushes {
w.pending <- txn
}
}
// GetDependents returns a slice of transactions waiting on the specified
// txn either directly or indirectly.
func (q *Queue) GetDependents(txnID uuid.UUID) []uuid.UUID {
q.mu.Lock()
defer q.mu.Unlock()
if q.mu.txns == nil {
// Not enabled; do nothing.
return nil
}
if pending, ok := q.mu.txns[txnID]; ok {
set := pending.getDependentsSet()
dependents := make([]uuid.UUID, 0, len(set))
for txnID := range set {
dependents = append(dependents, txnID)
}
return dependents
}
return nil
}
// isTxnUpdated returns whether the transaction specified in
// the QueryTxnRequest has had its status or priority updated
// or whether the known set of dependent transactions has
// changed.
func (q *Queue) isTxnUpdated(pending *pendingTxn, req *roachpb.QueryTxnRequest) bool {
// First check whether txn status or priority has changed.
txn := pending.getTxn()
if txn.Status != roachpb.PENDING || txn.Priority > req.Txn.Priority {
return true
}
// Next, see if there is any discrepancy in the set of known dependents.
set := pending.getDependentsSet()
if len(req.KnownWaitingTxns) != len(set) {
return true
}
for _, txnID := range req.KnownWaitingTxns {
if _, ok := set[txnID]; !ok {
return true
}
}
return false
}
func (q *Queue) clearWaitingQueriesLocked(ctx context.Context, txnID uuid.UUID) {
waitingQueries := q.mu.queries[txnID]
if log.V(1) && len(waitingQueries) > 0 {
log.Infof(
ctx,
"proceeding with %d query waiters for %s",
len(waitingQueries),
txnID.Short(),
)
}
for _, w := range waitingQueries {
close(w.pending)
}
delete(q.mu.queries, txnID)
}
// ErrDeadlock is a sentinel error returned when a cyclic dependency between
// waiting transactions is detected.
var ErrDeadlock = roachpb.NewErrorf("deadlock detected")
// MaybeWaitForPush checks whether there is a queue already
// established for pushing the transaction. If not, or if the PushTxn
// request isn't queueable, return immediately. If there is a queue,
// enqueue this request as a waiter and enter a select loop waiting
// for resolution.
//
// If the transaction is successfully pushed while this method is waiting,
// the first return value is a non-nil PushTxnResponse object.
//
// In the event of a dependency cycle of pushers leading to deadlock,
// this method will return an ErrDeadlock error.
func (q *Queue) MaybeWaitForPush(
ctx context.Context, repl ReplicaInterface, req *roachpb.PushTxnRequest,
) (*roachpb.PushTxnResponse, *roachpb.Error) {
if ShouldPushImmediately(req) {
return nil, nil
}
q.mu.Lock()
// If the txn wait queue is not enabled or if the request is not
// contained within the replica, do nothing. The request can fall
// outside of the replica after a split or merge. Note that the
// ContainsKey check is done under the txn wait queue's lock to
// ensure that it's not cleared before an incorrect insertion happens.
if q.mu.txns == nil || !repl.ContainsKey(req.Key) {
q.mu.Unlock()
return nil, nil
}
// If there's no pending queue for this txn, return not pushed. If
// already pushed, return push success.
pending, ok := q.mu.txns[req.PusheeTxn.ID]
if !ok {
q.mu.Unlock()
return nil, nil
}
if txn := pending.getTxn(); isPushed(req, txn) {
q.mu.Unlock()
return createPushTxnResponse(txn), nil
}
push := &waitingPush{
req: req,
pending: make(chan *roachpb.Transaction, 1),
}
pending.waitingPushes = append(pending.waitingPushes, push)
// Because we're adding another dependent on the pending
// transaction, send on the waiting queries' channel to
// indicate there is a new dependent and they should proceed
// to execute the QueryTxn command.
q.clearWaitingQueriesLocked(ctx, req.PusheeTxn.ID)
if req.PusherTxn.ID != (uuid.UUID{}) {
log.VEventf(
ctx,
2,
"%s pushing %s (%d pending)",
req.PusherTxn.ID.Short(),
req.PusheeTxn.ID.Short(),
len(pending.waitingPushes),
)
} else {
log.VEventf(ctx, 2, "pushing %s (%d pending)", req.PusheeTxn.ID.Short(), len(pending.waitingPushes))
}
q.mu.Unlock()
// Wait for any updates to the pusher txn to be notified when
// status, priority, or dependents (for deadlock detection) have
// changed.
var queryPusherCh <-chan *roachpb.Transaction // accepts updates to the pusher txn
var queryPusherErrCh <-chan *roachpb.Error // accepts errors querying the pusher txn
var readyCh chan struct{} // signaled when pusher txn should be queried
if req.PusherTxn.ID != (uuid.UUID{}) {
// Create a context which will be canceled once this call completes.
// This ensures that the goroutine created to query the pusher txn
// is properly cleaned up.
var cancel func()
ctx, cancel = context.WithCancel(ctx)
readyCh = make(chan struct{}, 1)
queryPusherCh, queryPusherErrCh = q.startQueryPusherTxn(ctx, push, readyCh)
// Ensure that the pusher querying goroutine is complete at exit.
defer func() {
cancel()
if queryPusherErrCh != nil {
<-queryPusherErrCh
}
}()
}
var pusheeTxnTimer timeutil.Timer
defer pusheeTxnTimer.Stop()
pusherPriority := req.PusherTxn.Priority
pusheePriority := req.PusheeTxn.Priority
first := true
for {
// Set the timer to check for the pushee txn's expiration.
if !first {
expiration := TxnExpiration(pending.txn.Load().(*roachpb.Transaction)).GoTime()
now := q.store.Clock().Now().GoTime()
pusheeTxnTimer.Reset(expiration.Sub(now))
} else {
// The first time we want to check the pushee's txn record immediately:
// the pushee might be gone by the time the pusher gets here if it cleaned
// itself up after the pusher saw an intent but before it entered this
// queue.
pusheeTxnTimer.Reset(0)
first = false
}
select {
case <-ctx.Done():
// Caller has given up.
log.Event(ctx, "pusher giving up due to context cancellation")
return nil, roachpb.NewError(ctx.Err())
case txn := <-push.pending:
log.Eventf(ctx, "result of pending push: %v", txn)
// If txn is nil, the queue was cleared, presumably because the
// replica lost the range lease. Return not pushed so request
// proceeds and is redirected to the new range lease holder.
if txn == nil {
return nil, nil
}
// Transaction was committed, aborted or had its timestamp
// pushed. If this PushTxn request is satisfied, return
// successful PushTxn response.
if isPushed(req, txn) {
log.Event(ctx, "push request is satisfied")
return createPushTxnResponse(txn), nil
}
// If not successfully pushed, return not pushed so request proceeds.
log.Event(ctx, "not pushed; returning to caller")
return nil, nil
case <-pusheeTxnTimer.C:
log.Event(ctx, "querying pushee")
pusheeTxnTimer.Read = true
// Periodically check whether the pushee txn has been abandoned.
updatedPushee, _, pErr := q.queryTxnStatus(
ctx, req.PusheeTxn, false, nil, q.store.Clock().Now(),
)
if pErr != nil {
return nil, pErr
} else if updatedPushee == nil {
// Continue with push.
log.Event(ctx, "pushee not found, push should now succeed")
return nil, nil
}
pusheePriority = updatedPushee.Priority
pending.txn.Store(updatedPushee)
if IsExpired(q.store.Clock().Now(), updatedPushee) {
log.VEventf(ctx, 1, "pushing expired txn %s", req.PusheeTxn.ID.Short())
return nil, nil
}
case updatedPusher := <-queryPusherCh:
log.Eventf(ctx, "pusher was updated: %v", updatedPusher)
switch updatedPusher.Status {
case roachpb.COMMITTED:
return nil, roachpb.NewErrorWithTxn(roachpb.NewTransactionStatusError("already committed"), updatedPusher)
case roachpb.ABORTED:
return nil, roachpb.NewErrorWithTxn(roachpb.NewTransactionAbortedError(), updatedPusher)
}
if updatedPusher.Priority > pusherPriority {
pusherPriority = updatedPusher.Priority
}
// Check for dependency cycle to find and break deadlocks.
push.mu.Lock()
_, haveDependency := push.mu.dependents[req.PusheeTxn.ID]
dependents := make([]string, 0, len(push.mu.dependents))
for id := range push.mu.dependents {
dependents = append(dependents, id.Short())
}
log.VEventf(
ctx,
2,
"%s (%d), pushing %s (%d), has dependencies=%s",
req.PusherTxn.ID.Short(),
pusherPriority,
req.PusheeTxn.ID.Short(),
pusheePriority,
dependents,
)
push.mu.Unlock()
// Since the pusher has been updated, clear any waiting queries
// so that they continue with a query of new dependents added here.
q.mu.Lock()
q.clearWaitingQueriesLocked(ctx, req.PusheeTxn.ID)
q.mu.Unlock()
if haveDependency {
// Break the deadlock if the pusher has higher priority.
p1, p2 := pusheePriority, pusherPriority
if p1 < p2 || (p1 == p2 && bytes.Compare(req.PusheeTxn.ID.GetBytes(), req.PusherTxn.ID.GetBytes()) < 0) {
if log.V(1) {
log.Infof(
ctx,
"%s breaking deadlock by force push of %s; dependencies=%s",
req.PusherTxn.ID.Short(),
req.PusheeTxn.ID.Short(),
dependents,
)
}
return nil, ErrDeadlock
}
}
// Signal the pusher query txn loop to continue.
readyCh <- struct{}{}
case pErr := <-queryPusherErrCh:
queryPusherErrCh = nil
return nil, pErr
}
}
}
// MaybeWaitForQuery checks whether there is a queue already
// established for pushing the transaction. If not, or if the QueryTxn
// request hasn't specified WaitForUpdate, return immediately. If
// there is a queue, enqueue this request as a waiter and enter a
// select loop waiting for any updates to the target transaction.
func (q *Queue) MaybeWaitForQuery(
ctx context.Context, repl ReplicaInterface, req *roachpb.QueryTxnRequest,
) *roachpb.Error {
if !req.WaitForUpdate {
return nil
}
q.mu.Lock()
// If the txn wait queue is not enabled or if the request is not
// contained within the replica, do nothing. The request can fall
// outside of the replica after a split or merge. Note that the
// ContainsKey check is done under the txn wait queue's lock to
// ensure that it's not cleared before an incorrect insertion happens.
if q.mu.txns == nil || !repl.ContainsKey(req.Key) {
q.mu.Unlock()
return nil
}
var maxWaitCh <-chan time.Time
pending, ok := q.mu.txns[req.Txn.ID]
// If the transaction we're waiting to query has a queue of txns
// in turn waiting on it, and is _already_ updated from what the
// caller is expecting, return to query the updates immediately.
if ok && q.isTxnUpdated(pending, req) {
q.mu.Unlock()
return nil
} else if !ok {
// If the transaction we're querying has no queue established,
// it's possible that it's no longer pending. To avoid waiting
// forever for an update that isn't forthcoming, we set a maximum
// time to wait for updates before allowing the query to
// proceed.
maxWaitCh = time.After(maxWaitForQueryTxn)
}
query := &waitingQuery{
req: req,
pending: make(chan struct{}),
}
q.mu.queries[req.Txn.ID] = append(q.mu.queries[req.Txn.ID], query)
q.mu.Unlock()
if log.V(2) {
log.Infof(ctx, "waiting on query for %s", req.Txn.ID.Short())
}
select {
case <-ctx.Done():
// Caller has given up.
return roachpb.NewError(ctx.Err())
case <-maxWaitCh:
return nil
case <-query.pending:
return nil
}
}
// startQueryPusherTxn starts a goroutine to send QueryTxn requests to
// fetch updates to the pusher's own transaction until the context is
// done or an error occurs while querying. Returns two channels: one
// for updated versions of the pusher transaction, and the other for
// errors encountered while querying. The readyCh parameter is used by
// the caller to signal when the next query to the pusher should be
// sent, and is mostly intended to avoid an extra RPC in the event that
// the QueryTxn returns sufficient information to determine a dependency
// cycle exists and must be broken.
//
// Note that the contents of the pusher transaction including updated
// priority and set of known waiting transactions (dependents) are
// accumulated over iterations and supplied with each successive
// invocation of QueryTxn in order to avoid busy querying.
func (q *Queue) startQueryPusherTxn(
ctx context.Context, push *waitingPush, readyCh <-chan struct{},
) (<-chan *roachpb.Transaction, <-chan *roachpb.Error) {
ch := make(chan *roachpb.Transaction, 1)
errCh := make(chan *roachpb.Error, 1)
push.mu.Lock()
var waitingTxns []uuid.UUID
if push.mu.dependents != nil {
waitingTxns = make([]uuid.UUID, 0, len(push.mu.dependents))
for txnID := range push.mu.dependents {
waitingTxns = append(waitingTxns, txnID)
}
}
pusher := push.req.PusherTxn.Clone()
push.mu.Unlock()
if err := q.store.Stopper().RunAsyncTask(
ctx, "monitoring pusher txn",
func(ctx context.Context) {
// We use a backoff/retry here in case the pusher transaction
// doesn't yet exist.
for r := retry.StartWithCtx(ctx, base.DefaultRetryOptions()); r.Next(); {
var pErr *roachpb.Error
var updatedPusher *roachpb.Transaction
updatedPusher, waitingTxns, pErr = q.queryTxnStatus(
ctx, pusher.TxnMeta, true, waitingTxns, q.store.Clock().Now(),
)
if pErr != nil {
errCh <- pErr
return
} else if updatedPusher == nil {
// No pusher to query; the BeginTransaction hasn't yet created the
// pusher's record. Continue in order to backoff and retry.
log.Event(ctx, "no pusher found; backing off")
continue
}
// Update the pending pusher's set of dependents. These accumulate
// and are used to propagate the transitive set of dependencies for
// distributed deadlock detection.
push.mu.Lock()
if push.mu.dependents == nil {
push.mu.dependents = map[uuid.UUID]struct{}{}
}
for _, txnID := range waitingTxns {
push.mu.dependents[txnID] = struct{}{}
}
push.mu.Unlock()
// Send an update of the pusher txn.
pusher.Update(updatedPusher)
ch <- &pusher
// Wait for context cancellation or indication on readyCh that the
// push waiter requires another query of the pusher txn.
select {
case <-ctx.Done():
errCh <- roachpb.NewError(ctx.Err())
return
case <-readyCh:
}
// Reset the retry to query again immediately.
r.Reset()
}
errCh <- roachpb.NewError(ctx.Err())
}); err != nil {
errCh <- roachpb.NewError(err)
}
return ch, errCh
}
// queryTxnStatus does a "query" push on the specified transaction
// to glean possible changes, such as a higher timestamp and/or
// priority. It turns out this is necessary while a request is waiting
// to push a transaction, as two txns can have circular dependencies
// where both are unable to push because they have different
// information about their own txns.
//
// Returns the updated transaction (or nil if not updated) as well as
// the list of transactions which are waiting on the updated txn.
func (q *Queue) queryTxnStatus(
ctx context.Context,
txnMeta enginepb.TxnMeta,
wait bool,
dependents []uuid.UUID,
now hlc.Timestamp,
) (*roachpb.Transaction, []uuid.UUID, *roachpb.Error) {
b := &client.Batch{}
b.AddRawRequest(&roachpb.QueryTxnRequest{
RequestHeader: roachpb.RequestHeader{
Key: txnMeta.Key,
},
Txn: txnMeta,
WaitForUpdate: wait,
KnownWaitingTxns: dependents,
})
if err := q.store.DB().Run(ctx, b); err != nil {
// TODO(tschottdorf):
// We shouldn't catch an error here (unless it's from the AbortSpan, in
// which case we would not get the crucial information that we've been
// aborted; instead we'll go around thinking we're still PENDING,
// potentially caught in an infinite loop). Same issue: we must not use
// RunWithResponse on this level - we're trying to do internal kv stuff
// through the public interface. Likely not exercised in tests, so I'd be
// ok tackling this separately.
//
// Scenario:
// - we're aborted and don't know if we have a read-write conflict
// - the push above fails and we get a WriteIntentError
// - we try to update our transaction (right here, and if we don't we might
// be stuck in a race, that's why we do this - the txn proto we're using
// might be outdated)
// - query fails because our home range has the AbortSpan populated we catch
// a TransactionAbortedError, but with a pending transaction (since we lose
// the original txn, and you just use the txn we had...)
//
// so something is sketchy here, but it should all resolve nicely when we
// don't use store.db for these internal requests any more.
return nil, nil, roachpb.NewError(err)
}
br := b.RawResponse()
resp := br.Responses[0].GetInner().(*roachpb.QueryTxnResponse)
// ID can be nil if no BeginTransaction has been sent yet.
if updatedTxn := &resp.QueriedTxn; updatedTxn.ID != (uuid.UUID{}) {
return updatedTxn, resp.WaitingTxns, nil
}
return nil, nil, nil
}
// TrackedTxns returns a (newly minted) set containing the transaction IDs which
// are being tracked (i.e. waited on).
//
// For testing purposes only.
func (q *Queue) TrackedTxns() map[uuid.UUID]struct{} {
m := make(map[uuid.UUID]struct{})
q.mu.Lock()
for k := range q.mu.txns {
m[k] = struct{}{}
}
q.mu.Unlock()
return m
}