-
Notifications
You must be signed in to change notification settings - Fork 3.8k
/
rule_solver.go
447 lines (412 loc) · 12.8 KB
/
rule_solver.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
// Copyright 2016 The Cockroach Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
// implied. See the License for the specific language governing
// permissions and limitations under the License.
//
// Author: Tristan Rice ([email protected])
package storage
import (
"bytes"
"fmt"
"sort"
"github.com/cockroachdb/cockroach/pkg/config"
"github.com/cockroachdb/cockroach/pkg/roachpb"
)
// candidate store for allocation.
type candidate struct {
store roachpb.StoreDescriptor
valid bool
constraint float64 // Score used to pick the top candidates.
capacity float64 // Score used to choose between top candidates.
}
func (c candidate) String() string {
return fmt.Sprintf("s%d, valid:%t, con:%.2f, bal:%.2f",
c.store.StoreID, c.valid, c.constraint, c.capacity)
}
// less first compares valid, then constraint scores, then capacity
// scores.
func (c candidate) less(o candidate) bool {
if !o.valid {
return false
}
if !c.valid {
return true
}
if c.constraint != o.constraint {
return c.constraint < o.constraint
}
return c.capacity < o.capacity
}
type candidateList []candidate
func (cl candidateList) String() string {
var buffer bytes.Buffer
buffer.WriteRune('[')
for i, c := range cl {
if i != 0 {
buffer.WriteString("; ")
}
buffer.WriteString(c.String())
}
buffer.WriteRune(']')
return buffer.String()
}
// byScore implements sort.Interface to sort by scores.
type byScore candidateList
var _ sort.Interface = byScore(nil)
func (c byScore) Len() int { return len(c) }
func (c byScore) Less(i, j int) bool { return c[i].less(c[j]) }
func (c byScore) Swap(i, j int) { c[i], c[j] = c[j], c[i] }
// byScoreAndID implements sort.Interface to sort by scores and ids.
type byScoreAndID candidateList
var _ sort.Interface = byScoreAndID(nil)
func (c byScoreAndID) Len() int { return len(c) }
func (c byScoreAndID) Less(i, j int) bool {
if c[i].constraint == c[j].constraint &&
c[i].capacity == c[j].capacity &&
c[i].valid == c[j].valid {
return c[i].store.StoreID < c[j].store.StoreID
}
return c[i].less(c[j])
}
func (c byScoreAndID) Swap(i, j int) { c[i], c[j] = c[j], c[i] }
// onlyValid returns all the elements in a sorted (by score reversed) candidate
// list that are valid.
func (cl candidateList) onlyValid() candidateList {
for i := len(cl) - 1; i >= 0; i-- {
if cl[i].valid {
return cl[:i+1]
}
}
return candidateList{}
}
// best returns all the elements in a sorted (by score reversed) candidate list
// that share the highest constraint score and are valid.
func (cl candidateList) best() candidateList {
cl = cl.onlyValid()
if len(cl) <= 1 {
return cl
}
for i := 1; i < len(cl); i++ {
if cl[i].constraint < cl[0].constraint {
return cl[:i]
}
}
return cl
}
// worst returns all the elements in a sorted (by score reversed) candidate
// list that share the lowest constraint score.
func (cl candidateList) worst() candidateList {
if len(cl) <= 1 {
return cl
}
// Are there invalid candidates? If so, pick those.
if !cl[len(cl)-1].valid {
for i := len(cl) - 2; i >= 0; i-- {
if cl[i].valid {
return cl[i+1:]
}
}
}
// Find the worst constraint values.
for i := len(cl) - 2; i >= 0; i-- {
if cl[i].constraint > cl[len(cl)-1].constraint {
return cl[i+1:]
}
}
return cl
}
// betterThan returns all elements from a sorted (by score reversed) candidate
// list that have a higher score than the candidate
func (cl candidateList) betterThan(c candidate) candidateList {
for i := 0; i < len(cl); i++ {
if !c.less(cl[i]) {
return cl[:i]
}
}
return cl
}
// selectGood randomly chooses a good candidate store from a sorted (by score
// reserved) candidate list using the provided random generator.
func (cl candidateList) selectGood(randGen allocatorRand) *roachpb.StoreDescriptor {
if len(cl) == 0 {
return nil
}
cl = cl.best()
if len(cl) == 1 {
return &cl[0].store
}
randGen.Lock()
order := randGen.Perm(len(cl))
randGen.Unlock()
best := &cl[order[0]]
for i := 1; i < allocatorRandomCount; i++ {
if best.less(cl[order[i]]) {
best = &cl[order[i]]
}
}
return &best.store
}
// selectBad randomly chooses a bad candidate store from a sorted (by score
// reversed) candidate list using the provided random generator.
func (cl candidateList) selectBad(randGen allocatorRand) *roachpb.StoreDescriptor {
if len(cl) == 0 {
return nil
}
cl = cl.worst()
if len(cl) == 1 {
return &cl[0].store
}
randGen.Lock()
order := randGen.Perm(len(cl))
randGen.Unlock()
worst := &cl[order[0]]
for i := 1; i < allocatorRandomCount; i++ {
if cl[order[i]].less(*worst) {
worst = &cl[order[i]]
}
}
return &worst.store
}
// allocateCandidates creates a candidate list of all stores that can used for
// allocating a new replica ordered from the best to the worst. Only stores
// that meet the criteria are included in the list.
func allocateCandidates(
sl StoreList,
constraints config.Constraints,
existing []roachpb.ReplicaDescriptor,
existingNodeLocalities map[roachpb.NodeID]roachpb.Locality,
deterministic bool,
) candidateList {
var candidates candidateList
for _, s := range sl.stores {
if !preexistingReplicaCheck(s.Node.NodeID, existing) {
continue
}
constraintsOk, preferredMatched := constraintCheck(s, constraints)
if !constraintsOk {
continue
}
if !maxCapacityCheck(s) {
continue
}
constraintScore := diversityScore(s, existingNodeLocalities) + float64(preferredMatched)
candidates = append(candidates, candidate{
store: s,
valid: true,
constraint: constraintScore,
capacity: capacityScore(s),
})
}
if deterministic {
sort.Sort(sort.Reverse(byScoreAndID(candidates)))
} else {
sort.Sort(sort.Reverse(byScore(candidates)))
}
return candidates
}
// removeCandidates creates a candidate list of all existing replicas' stores
// ordered from least qualified for removal to most qualified. Stores that are
// marked as not valid, are in violation of a required criteria.
func removeCandidates(
sl StoreList,
constraints config.Constraints,
existingNodeLocalities map[roachpb.NodeID]roachpb.Locality,
deterministic bool,
) candidateList {
var candidates candidateList
for _, s := range sl.stores {
constraintsOk, preferredMatched := constraintCheck(s, constraints)
if !constraintsOk {
candidates = append(candidates, candidate{store: s, valid: false})
continue
}
if !maxCapacityCheck(s) {
candidates = append(candidates, candidate{store: s, valid: false})
continue
}
constraintScore := diversityRemovalScore(s.Node.NodeID, existingNodeLocalities) + float64(preferredMatched)
if !rebalanceFromConvergesOnMean(sl, s) {
constraintScore++
}
candidates = append(candidates, candidate{
store: s,
valid: true,
constraint: constraintScore,
capacity: capacityScore(s),
})
}
if deterministic {
sort.Sort(sort.Reverse(byScoreAndID(candidates)))
} else {
sort.Sort(sort.Reverse(byScore(candidates)))
}
return candidates
}
// rebalanceCandidates creates two candidate list. The first contains all
// existing replica's stores, order from least qualified for rebalancing to
// most qualified. The second list is of all potential stores that could be
// used as rebalancing receivers, ordered from best to worst.
func rebalanceCandidates(
sl StoreList,
constraints config.Constraints,
existing []roachpb.ReplicaDescriptor,
existingNodeLocalities map[roachpb.NodeID]roachpb.Locality,
deterministic bool,
) (candidateList, candidateList) {
// Load the exiting storesIDs into a map so to eliminate having to loop
// through the existing descriptors more than once.
existingStoreIDs := make(map[roachpb.StoreID]struct{})
for _, repl := range existing {
existingStoreIDs[repl.StoreID] = struct{}{}
}
var existingCandidates candidateList
var candidates candidateList
for _, s := range sl.stores {
constraintsOk, preferredMatched := constraintCheck(s, constraints)
maxCapacityOK := maxCapacityCheck(s)
if _, ok := existingStoreIDs[s.StoreID]; ok {
if !constraintsOk {
existingCandidates = append(existingCandidates, candidate{store: s, valid: false})
continue
}
if !maxCapacityOK {
existingCandidates = append(existingCandidates, candidate{store: s, valid: false})
continue
}
constraintScore := diversityRemovalScore(s.Node.NodeID, existingNodeLocalities) + float64(preferredMatched)
if !rebalanceFromConvergesOnMean(sl, s) {
constraintScore++
}
existingCandidates = append(existingCandidates, candidate{
store: s,
valid: true,
constraint: constraintScore,
capacity: capacityScore(s),
})
} else {
if !constraintsOk || !maxCapacityOK || !rebalanceToConvergesOnMean(sl, s) {
continue
}
constraintScore := 1.0 + diversityScore(s, existingNodeLocalities) + float64(preferredMatched)
candidates = append(candidates, candidate{
store: s,
valid: true,
constraint: constraintScore,
capacity: capacityScore(s),
})
}
}
if deterministic {
sort.Sort(sort.Reverse(byScoreAndID(existingCandidates)))
sort.Sort(sort.Reverse(byScoreAndID(candidates)))
} else {
sort.Sort(sort.Reverse(byScore(existingCandidates)))
sort.Sort(sort.Reverse(byScore(candidates)))
}
return existingCandidates, candidates
}
// preexistingReplicaCheck returns true if no existing replica is present on
// the candidate's node.
func preexistingReplicaCheck(nodeID roachpb.NodeID, existing []roachpb.ReplicaDescriptor) bool {
for _, r := range existing {
if r.NodeID == nodeID {
return false
}
}
return true
}
// storeHasConstraint returns whether a store's attributes or node's locality
// matches the key value pair in the constraint.
func storeHasConstraint(store roachpb.StoreDescriptor, c config.Constraint) bool {
if c.Key == "" {
for _, attrs := range []roachpb.Attributes{store.Attrs, store.Node.Attrs} {
for _, attr := range attrs.Attrs {
if attr == c.Value {
return true
}
}
}
} else {
for _, tier := range store.Node.Locality.Tiers {
if c.Key == tier.Key && c.Value == tier.Value {
return true
}
}
}
return false
}
// constraintCheck returns true iff all required and prohibited constraints are
// satisfied. Stores with attributes or localities that match the most positive
// constraints return higher scores.
func constraintCheck(store roachpb.StoreDescriptor, constraints config.Constraints) (bool, int) {
if len(constraints.Constraints) == 0 {
return true, 0
}
positive := 0
for _, constraint := range constraints.Constraints {
hasConstraint := storeHasConstraint(store, constraint)
switch {
case constraint.Type == config.Constraint_REQUIRED && !hasConstraint:
return false, 0
case constraint.Type == config.Constraint_PROHIBITED && hasConstraint:
return false, 0
case (constraint.Type == config.Constraint_POSITIVE && hasConstraint):
positive++
}
}
return true, positive
}
// diversityScore returns a score between 1 and 0 where higher scores are stores
// with the fewest locality tiers in common with already existing replicas.
func diversityScore(
store roachpb.StoreDescriptor, existingNodeLocalities map[roachpb.NodeID]roachpb.Locality,
) float64 {
minScore := 1.0
for _, locality := range existingNodeLocalities {
if newScore := store.Node.Locality.DiversityScore(locality); newScore < minScore {
minScore = newScore
}
}
return minScore
}
// diversityRemovalScore is similar to diversityScore but instead of calculating
// the score if a new node is added, it calculates the remaining diversity if a
// node is removed.
func diversityRemovalScore(
nodeID roachpb.NodeID, existingNodeLocalities map[roachpb.NodeID]roachpb.Locality,
) float64 {
var maxScore float64
for nodeIDx, localityX := range existingNodeLocalities {
if nodeIDx == nodeID {
continue
}
for nodeIDy, localityY := range existingNodeLocalities {
if nodeIDy == nodeID || nodeIDx >= nodeIDy {
continue
}
if newScore := localityX.DiversityScore(localityY); newScore > maxScore {
maxScore = newScore
}
}
}
return maxScore
}
// capacityScore returns a score between 0 and 1 that is inversely proportional
// to the number of ranges on the store such that the most empty store will have
// the highest scores.
func capacityScore(store roachpb.StoreDescriptor) float64 {
return 1.0 / float64(store.Capacity.RangeCount+1)
}
// maxCapacityCheck returns true if the store has room for a new replica.
func maxCapacityCheck(store roachpb.StoreDescriptor) bool {
return store.Capacity.FractionUsed() < maxFractionUsedThreshold
}