-
Notifications
You must be signed in to change notification settings - Fork 3.9k
/
Copy pathinterval_skl.go
1150 lines (1022 loc) · 41.7 KB
/
interval_skl.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright 2017 Andy Kimball
// Copyright 2017 The Cockroach Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package tscache
import (
"bytes"
"container/list"
"context"
"encoding/binary"
"fmt"
"sync/atomic"
"time"
"unsafe"
"github.com/andy-kimball/arenaskl"
"github.com/cockroachdb/cockroach/pkg/util"
"github.com/cockroachdb/cockroach/pkg/util/hlc"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/cockroach/pkg/util/syncutil"
"github.com/cockroachdb/cockroach/pkg/util/uuid"
)
// rangeOptions are passed to AddRange to indicate the bounds of the range. By
// default, the "from" and "to" keys are inclusive. Setting these bit flags
// indicates that one or both is exclusive instead.
type rangeOptions int
const (
// excludeFrom indicates that the range does not include the starting key.
excludeFrom = rangeOptions(1 << iota)
// excludeTo indicates that the range does not include the ending key.
excludeTo
)
// nodeOptions are meta tags on skiplist nodes that indicate the status and role
// of that node in the intervalSkl. The options are bit flags that can be
// independently added and removed.
//
// Each node in the intervalSkl holds a key and, optionally, the latest read
// timestamp for that key. In addition, the node optionally holds the latest
// read timestamp for the range of keys between itself and the next key that is
// present in the skiplist. This space between keys is called the "gap", and the
// timestamp for that range is called the "gap timestamp". Here is a simplified
// representation that would result after these ranges were added to an empty
// intervalSkl:
// ["apple", "orange") = 200
// ["kiwi", "raspberry"] = 100
//
// "apple" "orange" "raspberry"
// keyts=200 keyts=100 keyts=100
// gapts=200 gapts=100 gapts=0
//
// That is, the range from apple (inclusive) to orange (exclusive) has a read
// timestamp of 200. The range from orange (inclusive) to raspberry (inclusive)
// has a read timestamp of 100. All other keys have a read timestamp of 0.
type nodeOptions int
const (
// initialized indicates that the node has been created and fully
// initialized. Key and gap values are final, and can now be used.
initialized = 1 << iota
// cantInit indicates that the node should never be allowed to initialize.
// This is set on nodes which were unable to ratchet their values at some
// point because of a full arena. In this case, the node's values should
// never become final and any goroutines trying to initialize it it will be
// forced to create it again in a new page when they notice this flag.
cantInit
// hasKey indicates that the node has an associated key value. If this is
// not set, then the key timestamp is assumed to be zero and the key is
// assumed to not have a corresponding txnID.
hasKey
// hasGap indicates that the node has an associated gap value. If this is
// not set, then the gap timestamp is assumed to be zero and the gap is
// assumed to not have a corresponding txnID.
hasGap
)
const (
encodedTsSize = int(unsafe.Sizeof(hlc.Timestamp{}))
encodedTxnIDSize = int(unsafe.Sizeof(uuid.UUID{}))
encodedValSize = encodedTsSize + encodedTxnIDSize
defaultMinSklPages = 2
)
// initialSklAllocSize is the amount of space in its arena that an empty
// arenaskl.Skiplist consumes.
var initialSklAllocSize = func() int {
a := arenaskl.NewArena(1000)
_ = arenaskl.NewSkiplist(a)
return int(a.Size())
}()
// intervalSkl efficiently tracks the latest logical time at which any key or
// range of keys has been accessed. Keys are binary values of any length, and
// times are represented as hybrid logical timestamps (see hlc package). The
// data structure guarantees that the read timestamp of any given key or range
// will never decrease. In other words, if a lookup returns timestamp A and
// repeating the same lookup returns timestamp B, then B >= A.
//
// Add and lookup operations do not block or interfere with one another, which
// enables predictable operation latencies. Also, the impact of the structure on
// the GC is virtually nothing, even when the structure is very large. These
// properties are enabled by employing a lock-free skiplist implementation that
// uses an arena allocator. Skiplist nodes refer to one another by offset into
// the arena rather than by pointer, so the GC has very few objects to track.
//
//
// The data structure can conceptually be thought of as being parameterized over
// a key and a value type, such that the key implements a Comparable interface
// (see interval.Comparable) and the value implements a Ratchetable interface:
//
// type Ratchetable interface {
// Ratchet(other Ratchetable) (changed bool)
// }
//
// In other words, if Go supported zero-cost abstractions, this type might look
// like:
//
// type intervalSkl<K: Comparable, V: Ratchetable>
//
type intervalSkl struct {
// rotMutex synchronizes page rotation with all other operations. The read
// lock is acquired by the Add and Lookup operations. The write lock is
// acquired only when the pages are rotated. Since that is very rare, the
// vast majority of operations can proceed without blocking.
rotMutex syncutil.RWMutex
// The following fields are used to enforce a minimum retention window on
// all timestamp intervals. intervalSkl promises to retain all timestamp
// intervals until they are at least this old before allowing the floor
// timestamp to ratchet and subsume them. If clock is nil then no minimum
// retention policy will be employed.
clock *hlc.Clock
minRet time.Duration
// The size of each page in the data structure, in bytes. When a page fills,
// the pages will be rotated and older entries will be discarded. The entire
// data structure will usually have a size limit of pageSize*minPages.
// However, this limit can be violated if the intervalSkl needs to grow
// larger to enforce a minimum retention policy.
pageSize uint32
// The linked list maintains fixed-size skiplist pages, ordered by creation
// time such that the first page is the one most recently created. When the
// first page fills, a new empty page is prepended to the front of the list
// and all others are pushed back. This first page is the only sklPage that
// is written to, all others are immutable after they have left the front of
// the list. However, earlier pages are accessed whenever necessary during
// lookups. Pages are evicted when they become too old, subject to a minimum
// retention policy described above.
pages list.List // List<*sklPage>
minPages int
// In order to ensure that timestamps never decrease, intervalSkl maintains
// a floor timestamp, which is the minimum timestamp that can be returned by
// the lookup operations. When the earliest page is discarded, its current
// maximum timestamp becomes the new floor timestamp for the overall
// intervalSkl.
floorTS hlc.Timestamp
metrics sklMetrics
}
// newIntervalSkl creates a new interval skiplist with the given minimum
// retention duration and the maximum size.
func newIntervalSkl(
clock *hlc.Clock, minRet time.Duration, pageSize uint32, metrics sklMetrics,
) *intervalSkl {
s := intervalSkl{
clock: clock,
minRet: minRet,
pageSize: pageSize,
minPages: defaultMinSklPages,
metrics: metrics,
}
s.pushNewPage(0 /* maxWallTime */, nil /* arena */)
s.metrics.Pages.Update(1)
return &s
}
// Add marks the a single key as having been read at the given timestamp. Once
// Add completes, future lookups of this key are guaranteed to return an equal
// or greater timestamp.
func (s *intervalSkl) Add(key []byte, val cacheValue) {
s.AddRange(nil, key, 0, val)
}
// AddRange marks the given range of keys [from, to] as having been read at the
// given timestamp. The starting and ending points of the range are inclusive by
// default, but can be excluded by passing the applicable range options. nil can
// be passed as the "from" key, in which case only the end key will be added.
// nil can also be passed as the "to" key, in which case an open range will be
// added spanning [from, infinity). However, it is illegal to pass nil for both
// "from" and "to". It is also illegal for "from" > "to", which would be an
// inverted range.
//
// intervalSkl defines the domain of possible keys to span ["", nil). A range
// with a starting key of []byte("") is treated as a closed range beginning at
// the minimum key. A range with an ending key of []byte(nil) is treated as an
// open range extending to infinity (as such, excludeTo has not effect on it). A
// range starting at []byte("") and ending at []byte(nil) will span all keys.
//
// If some or all of the range was previously read at a higher timestamp, then
// the range is split into sub-ranges that are each marked with the maximum read
// timestamp for that sub-range. Once AddRange completes, future lookups at any
// point in the range are guaranteed to return an equal or greater timestamp.
func (s *intervalSkl) AddRange(from, to []byte, opt rangeOptions, val cacheValue) {
if from == nil && to == nil {
panic("from and to keys cannot be nil")
}
if encodedRangeSize(from, to, opt) > int(s.pageSize)-initialSklAllocSize {
// Without this check, we could fall into an infinite page rotation loop
// if a range would take up more space than available in an empty page.
panic("key range too large to fit in any page")
}
if to != nil {
cmp := 0
if from != nil {
cmp = bytes.Compare(from, to)
}
switch {
case cmp > 0:
// Starting key is after ending key. This shouldn't happen. Determine
// the index where the keys diverged and panic.
d := 0
for d < len(from) && d < len(to) {
if from[d] != to[d] {
break
}
d++
}
msg := fmt.Sprintf("inverted range (issue #32149): key lens = [%d,%d), diff @ index %d",
len(from), len(to), d)
log.Errorf(context.Background(), "%s, [%s,%s)", msg, from, to)
panic(log.Safe(msg))
case cmp == 0:
// Starting key is same as ending key, so just add single node.
if opt == (excludeFrom | excludeTo) {
// Both from and to keys are excluded, so range is zero length.
return
}
// Just add the ending key.
from = nil
opt = 0
}
}
for {
// Try to add the range to the later page.
filledPage := s.addRange(from, to, opt, val)
if filledPage == nil {
break
}
// The page was filled up, so rotate the pages and then try again.
s.rotatePages(filledPage)
}
}
// addRange marks the given range of keys [from, to] as having been read at the
// given timestamp. The key range and the rangeOptions observe the same behavior
// as is specified for AddRange above. Notably, addRange treats nil "from" and
// "to" arguments in accordance with AddRange's contract. It returns nil if the
// operation was successful, or a pointer to an sklPage if the operation failed
// because that page was full.
func (s *intervalSkl) addRange(from, to []byte, opt rangeOptions, val cacheValue) *sklPage {
// Acquire the rotation mutex read lock so that the page will not be rotated
// while add or lookup operations are in progress.
s.rotMutex.RLock()
defer s.rotMutex.RUnlock()
// If floor ts is >= requested timestamp, then no need to perform a search
// or add any records.
if !s.floorTS.Less(val.ts) {
return nil
}
fp := s.frontPage()
var it arenaskl.Iterator
it.Init(fp.list)
// Start by ensuring that the ending node has been created (unless "to" is
// nil, in which case the range extends indefinitely). Do this before creating
// the start node, so that the range won't extend past the end point during
// the period between creating the two endpoints. Since we need the ending node
// to be initialized before creating the starting node, we pass mustInit = true.
var err error
if to != nil {
if (opt & excludeTo) == 0 {
err = fp.addNode(&it, to, val, hasKey, true /* mustInit */)
} else {
err = fp.addNode(&it, to, val, 0, true /* mustInit */)
}
if err == arenaskl.ErrArenaFull {
return fp
}
}
// If from is nil, then the "range" is just a single key. We already
// asserted above that if from == nil then to != nil.
if from == nil {
return nil
}
// Ensure that the starting node has been created.
if (opt & excludeFrom) == 0 {
err = fp.addNode(&it, from, val, hasKey|hasGap, false /* mustInit */)
} else {
err = fp.addNode(&it, from, val, hasGap, false /* mustInit */)
}
if err == arenaskl.ErrArenaFull {
return fp
}
// Seek to the node immediately after the "from" node.
//
// If there are no nodes after the "from" node (only possible if to == nil),
// then ensureFloorValue below will be a no-op because no other nodes need
// to be adjusted.
if !it.Valid() || !bytes.Equal(it.Key(), from) {
// We will only reach this state if we didn't need to add a node at
// "from" due to the previous gap value being larger than val. The fast
// path for this case is in sklPage.addNode. For all other times, adding
// the new node will have positioned the iterator at "from".
//
// If Seek returns false then we're already at the following node, so
// there's no need to call Next.
if it.Seek(from) {
it.Next()
}
} else {
it.Next()
}
// Now iterate forwards and ensure that all nodes between the start and
// end (exclusive) have timestamps that are >= the range timestamp. end
// is exclusive because we already added a node at that key.
if !fp.ensureFloorValue(&it, to, val) {
// Page is filled up, so rotate pages and try again.
return fp
}
return nil
}
// frontPage returns the front page of the intervalSkl.
func (s *intervalSkl) frontPage() *sklPage {
return s.pages.Front().Value.(*sklPage)
}
// pushNewPage prepends a new empty page to the front of the pages list. It
// accepts an optional arena argument to facilitate re-use.
func (s *intervalSkl) pushNewPage(maxWallTime int64, arena *arenaskl.Arena) {
if arena != nil && arena.Size() == s.pageSize {
// Re-use the provided arena, if possible.
arena.Reset()
} else {
arena = arenaskl.NewArena(s.pageSize)
}
p := newSklPage(arena)
p.maxWallTime = maxWallTime
s.pages.PushFront(p)
}
// rotatePages makes the later page the earlier page, and then discards the
// earlier page. The max timestamp of the earlier page becomes the new floor
// timestamp, in order to guarantee that timestamp lookups never return decreasing
// values.
func (s *intervalSkl) rotatePages(filledPage *sklPage) {
// Acquire the rotation mutex write lock to lock the entire intervalSkl.
s.rotMutex.Lock()
defer s.rotMutex.Unlock()
fp := s.frontPage()
if filledPage != fp {
// Another thread already rotated the pages, so don't do anything more.
return
}
// Determine the minimum timestamp a page must contain to be within the
// minimum retention window. If clock is nil, we have no minimum retention
// window.
minTSToRetain := hlc.MaxTimestamp
if s.clock != nil {
minTSToRetain = s.clock.Now()
minTSToRetain.WallTime -= s.minRet.Nanoseconds()
}
// Iterate over the pages in reverse, evicting pages that are no longer
// needed and ratcheting up the floor timestamp in the process.
//
// If possible, keep a reference to an evicted page's arena so that we can
// re-use it. This is safe because we're holding the rotation mutex write
// lock, so there cannot be concurrent readers and no reader will ever
// access evicted pages once we unlock.
back := s.pages.Back()
var oldArena *arenaskl.Arena
for s.pages.Len() >= s.minPages {
bp := back.Value.(*sklPage)
bpMaxTS := hlc.Timestamp{WallTime: bp.maxWallTime}
if !bpMaxTS.Less(minTSToRetain) {
// The back page's maximum timestamp is within the time
// window we've promised to retain, so we can't evict it.
break
}
// Max timestamp of the back page becomes the new floor timestamp.
s.floorTS.Forward(bpMaxTS)
// Evict the page.
oldArena = bp.list.Arena()
evict := back
back = back.Prev()
s.pages.Remove(evict)
}
// Push a new empty page on the front of the pages list. We give this page
// the maxWallTime of the old front page. This assures that the maxWallTime
// for a page is always equal to or greater than that for all earlier pages.
// In other words, it assures that the maxWallTime for a page is not only
// the maximum timestamp for all values it contains, but also for all values
// any earlier pages contain.
s.pushNewPage(fp.maxWallTime, oldArena)
// Update metrics.
s.metrics.Pages.Update(int64(s.pages.Len()))
s.metrics.PageRotations.Inc(1)
}
// LookupTimestamp returns the latest timestamp value at which the given key was
// read. If this operation is repeated with the same key, it will always result
// in an equal or greater timestamp.
func (s *intervalSkl) LookupTimestamp(key []byte) cacheValue {
return s.LookupTimestampRange(nil, key, 0)
}
// LookupTimestampRange returns the latest timestamp value of any key within the
// specified range. If this operation is repeated with the same range, it will
// always result in an equal or greater timestamp.
func (s *intervalSkl) LookupTimestampRange(from, to []byte, opt rangeOptions) cacheValue {
if from == nil && to == nil {
panic("from and to keys cannot be nil")
}
// Acquire the rotation mutex read lock so that the page will not be rotated
// while add or lookup operations are in progress.
s.rotMutex.RLock()
defer s.rotMutex.RUnlock()
// Iterate over the pages, performing the lookup on each and remembering the
// maximum value we've seen so far.
var val cacheValue
for e := s.pages.Front(); e != nil; e = e.Next() {
p := e.Value.(*sklPage)
// If the maximum value's timestamp is greater than the max timestamp in
// the current page, then there's no need to do the lookup in this page.
// There's also no reason to do the lookup in any earlier pages either,
// because rotatePages assures that a page will never have a max
// timestamp smaller than that of any page earlier than it.
//
// NB: if the max timestamp of the current page is equal to the maximum
// value's timestamp, then we still need to perform the lookup. This is
// because the current page's max timestamp _may_ (if the hlc.Timestamp
// ceil operation in sklPage.ratchetMaxTimestamp was a no-op) correspond
// to a real range's timestamp, and this range _may_ overlap with our
// lookup range. If that is the case and that other range has a
// different txnID than our current cacheValue result (val), then we
// need to remove the txnID from our result, per the ratcheting policy
// for cacheValues. This is tested in TestIntervalSklMaxPageTS.
maxTS := hlc.Timestamp{WallTime: atomic.LoadInt64(&p.maxWallTime)}
if maxTS.Less(val.ts) {
break
}
val2 := p.lookupTimestampRange(from, to, opt)
val, _ = ratchetValue(val, val2)
}
// Return the higher value from the the page lookups and the floor
// timestamp.
floorVal := cacheValue{ts: s.floorTS, txnID: noTxnID}
val, _ = ratchetValue(val, floorVal)
return val
}
// FloorTS returns the receiver's floor timestamp.
func (s *intervalSkl) FloorTS() hlc.Timestamp {
s.rotMutex.RLock()
defer s.rotMutex.RUnlock()
return s.floorTS
}
// sklPage maintains a skiplist based on a fixed-size arena. When the arena has
// filled up, it returns arenaskl.ErrArenaFull. At that point, a new fixed page
// must be allocated and used instead.
type sklPage struct {
list *arenaskl.Skiplist
maxWallTime int64 // accessed atomically
isFull int32 // accessed atomically
}
func newSklPage(arena *arenaskl.Arena) *sklPage {
return &sklPage{list: arenaskl.NewSkiplist(arena)}
}
func (p *sklPage) lookupTimestampRange(from, to []byte, opt rangeOptions) cacheValue {
if to != nil {
cmp := 0
if from != nil {
cmp = bytes.Compare(from, to)
}
if cmp > 0 {
// Starting key is after ending key, so range is zero length.
return cacheValue{}
}
if cmp == 0 {
// Starting key is same as ending key.
if opt == (excludeFrom | excludeTo) {
// Both from and to keys are excluded, so range is zero length.
return cacheValue{}
}
// Scan over a single key.
from = to
opt = 0
}
}
var it arenaskl.Iterator
it.Init(p.list)
it.SeekForPrev(from)
return p.maxInRange(&it, from, to, opt)
}
// addNode adds a new node at key with the provided value if one does not exist.
// If one does exist, it ratchets the existing node's value instead.
//
// If the mustInit flag is set, the function will ensure that the node is
// initialized by the time the method returns, even if a different goroutine
// created the node. If the flag is not set and a different goroutine created
// the node, the method won't try to help.
func (p *sklPage) addNode(
it *arenaskl.Iterator, key []byte, val cacheValue, opt nodeOptions, mustInit bool,
) error {
// Array with constant size will remain on the stack.
var arr [encodedValSize * 2]byte
var keyVal, gapVal cacheValue
if (opt & hasKey) != 0 {
keyVal = val
}
if (opt & hasGap) != 0 {
gapVal = val
}
if !it.SeekForPrev(key) {
// The key was not found. Scan for the previous gap value.
prevGapVal := p.incomingGapVal(it, key)
var err error
if it.Valid() && bytes.Equal(it.Key(), key) {
// Another thread raced and added a node at key while we were
// scanning backwards. Ratchet the new node.
err = arenaskl.ErrRecordExists
} else {
// There is still no node at key. If the previous node has a gap
// value that would not be updated with the new value, then there is
// no need to add another node, since its timestamp would be the
// same as the gap timestamp and its txnID would be the same as the
// gap txnID.
if _, update := ratchetValue(prevGapVal, val); !update {
return nil
}
// Ratchet max timestamp before adding the node.
p.ratchetMaxTimestamp(val.ts)
// Ensure that a new node is created. It needs to stay in the
// initializing state until the gap value of its preceding node
// has been found and used to ratchet this node's value. During
// the search for the gap value, this node acts as a sentinel
// for other ongoing operations - when they see this node they're
// forced to stop and ratchet its value before they can continue.
b, meta := encodeValueSet(arr[:0], keyVal, gapVal)
err = it.Add(key, b, meta)
}
switch err {
case arenaskl.ErrArenaFull:
atomic.StoreInt32(&p.isFull, 1)
return err
case arenaskl.ErrRecordExists:
// Another thread raced and added the node, so just ratchet its
// values instead (down below).
case nil:
// Add was successful, so finish initialization by scanning for gap
// value and using it to ratchet the new nodes' values.
return p.ensureInitialized(it, key)
default:
panic(fmt.Sprintf("unexpected error: %v", err))
}
}
// If mustInit is set to true then we're promising that the node will be
// initialized by the time this method returns. Ensure this by helping out
// the goroutine that created the node.
if (it.Meta()&initialized) == 0 && mustInit {
if err := p.ensureInitialized(it, key); err != nil {
return err
}
}
// Ratchet up the timestamps on the existing node, but don't set the
// initialized bit. If mustInit is set then we already made sure the node
// was initialized. If mustInit is not set then we don't require it to be
// initialized.
if opt == 0 {
// Don't need to set either key or gap value, so done.
return nil
}
return p.ratchetValueSet(it, always, keyVal, gapVal, false /* setInit */)
}
// ensureInitialized ensures that the node at the specified key is initialized.
// It does so by first scanning backwards to the first initialized node and
// using its gap value as the initial "previous gap value". It then scans
// forward until it reaches the desired key, ratcheting any uninitialized nodes
// it encounters (but not initializing them), and updating the candidate
// "previous gap value" as it goes. Finally, it initializes the node with the
// "previous gap value".
//
// Iterating backwards and then forwards solves potential race conditions with
// other threads. During backwards iteration, other nodes can be inserting new
// nodes between the previous node and the lookup node, which could change the
// choice for the "previous gap value". The solution is two-fold:
//
// 1. Add new nodes in two phases - initializing and then initialized. Nodes in
// the initializing state act as a synchronization point between goroutines
// that are adding a particular node and goroutines that are scanning for gap
// values. Scanning goroutines encounter the initializing nodes and are
// forced to ratchet them before continuing. If they fail to ratchet them
// because an arena is full, the nodes must never be initialized so they are
// set to cantInit. This is critical for correctness, because if one of these
// initializing nodes was not ratcheted when encountered during a forward
// scan and later initialized, we could see a ratchet inversion. For example,
// the inversion would occur if:
// - 1: a goroutine is scanning forwards after finding a previous gap value
// from node A in which it plans to initialize node C.
// - 2: node B is created and initialized between node A and node C with a
// larger value than either.
// - 1: the iterator scanning forwards to node C is already past node B when
// it is created.
// - 3: a lookup for the timestamp of node C comes in. Since it's not
// initialized, it uses node B's gap value.
// - 1: the iterator reaches node C and initializes it with node A's gap
// value, which is smaller than node B's.
// - 4: another lookup for the timestamp of node C comes it. It returns the
// nodes newly initialized value, which is smaller than the one it
// reported before.
// Ratcheting initializing nodes when encountered with the current gap value
// avoids this race.
//
// However, only a goroutine that saw a node in an uninitialized state before
// scanning backwards can switch it from initializing to initialized. This
// enforces a "happens-before" relationship between the creation of a node
// and the discovery of the gap value that is used when initializing it. If
// any goroutine was able to initialize a node, then this relationship would
// not exist and we could experience races where a newly inserted node A's
// call to ensureFloorValue could come before the insertion of a node B, but
// node B could be initialized with a gap value discovered before the
// insertion of node A. For more on this, see the discussion in #19672.
//
// 2. After the gap value of the first initialized node with a key less than or
// equal to the desired key has been found, the scanning goroutine will scan
// forwards until it reaches the original key. It will ratchet any
// uninitialized nodes along the way and inherit the gap value from them as
// it goes. By the time it reaches the original key, it has a valid gap
// value, which we have called the "previous gap value". At this point, if
// the node at key is uninitialized, the node can be initialized with the
// "previous gap value".
//
// It is an error to call ensureInitialized on a key without a node. When
// finished, the iterator will be positioned the same as if it.Seek(key) had
// been called.
func (p *sklPage) ensureInitialized(it *arenaskl.Iterator, key []byte) error {
// Determine the incoming gap value.
prevGapVal := p.incomingGapVal(it, key)
// Make sure we're on the right key again.
if util.RaceEnabled && !bytes.Equal(it.Key(), key) {
panic("no node found")
}
// If the node isn't initialized, initialize it.
return p.ratchetValueSet(it, onlyIfUninitialized, prevGapVal, prevGapVal, true /* setInit */)
}
// ensureFloorValue scans from the current position of the iterator to the
// provided key, ratcheting all initialized or uninitialized nodes as it goes
// with the provided value. It returns a boolean indicating whether it was
// successful (true) or whether it saw an ErrArenaFull while ratcheting (false).
func (p *sklPage) ensureFloorValue(it *arenaskl.Iterator, to []byte, val cacheValue) bool {
for it.Valid() {
util.RacePreempt()
// If "to" is not nil (open range) then it is treated as an exclusive
// bound.
if to != nil && bytes.Compare(it.Key(), to) >= 0 {
break
}
if atomic.LoadInt32(&p.isFull) == 1 {
// Page is full, so stop iterating. The caller will then be able to
// release the read lock and rotate the pages. Not doing this could
// result in forcing all other operations to wait for this thread to
// completely finish iteration. That could take a long time if this
// range is very large.
return false
}
// Don't clear the initialization bit, since we don't have the gap
// timestamp from the previous node, and don't need an initialized node
// for this operation anyway.
err := p.ratchetValueSet(it, always, val, val, false /* setInit */)
switch err {
case nil:
// Continue scanning.
case arenaskl.ErrArenaFull:
// Page is too full to ratchet value, so stop iterating.
return false
default:
panic(fmt.Sprintf("unexpected error: %v", err))
}
it.Next()
}
return true
}
func (p *sklPage) ratchetMaxTimestamp(ts hlc.Timestamp) {
// Cheat and just use the max wall time portion of the timestamp, since it's
// fine for the max timestamp to be a bit too large. This is the case
// because it's always safe to increase the timestamp in a range. It's also
// always safe to remove the transaction ID from a range. Either of these
// changes may force a transaction to lose "ownership" over a range of keys,
// but they'll never allow a transaction to gain "ownership" over a range of
// keys that it wouldn't otherwise have. In other words, it's ok for the
// intervalSkl to produce false negatives but never ok for it to produce
// false positives.
//
// We could use an atomic.Value to store a "MaxValue" cacheValue for a given
// page, but this would be more expensive and it's not clear that it would
// be worth it.
new := ts.WallTime
if ts.Logical > 0 {
new++
}
for {
old := atomic.LoadInt64(&p.maxWallTime)
if new <= old {
break
}
if atomic.CompareAndSwapInt64(&p.maxWallTime, old, new) {
break
}
}
}
// ratchetPolicy defines the behavior a ratcheting attempt should take when
// trying to ratchet a node. Certain operations require nodes to be ratcheted
// regardless of whether they're already initialized or not. Other operations
// only want nodes that are uninitialized to be ratcheted.
type ratchetPolicy bool
const (
// always is a policy to ratchet a node regardless of whether it is already
// initialized or not.
always ratchetPolicy = false
// onlyIfUninitialized is a policy to only ratchet a node if it has not been
// initialized yet.
onlyIfUninitialized ratchetPolicy = true
)
// ratchetValueSet will update the current node's key and gap values to the
// maximum of their current values or the given values. If setInit is true, then
// the initialized bit will be set, indicating that the node is now fully
// initialized and its values can now be relied upon.
//
// The method will return ErrArenaFull if the arena was too full to ratchet the
// node's value set. In that case, the node will be marked with the "cantInit"
// flag because its values should never be trusted in isolation.
func (p *sklPage) ratchetValueSet(
it *arenaskl.Iterator, policy ratchetPolicy, keyVal, gapVal cacheValue, setInit bool,
) error {
// Array with constant size will remain on the stack.
var arr [encodedValSize * 2]byte
for {
util.RacePreempt()
meta := it.Meta()
inited := (meta & initialized) != 0
if inited && policy == onlyIfUninitialized {
// If the node is already initialized and the policy is
// onlyIfUninitialized, return. If this isn't the first ratcheting
// attempt then we must have raced with node initialization before.
return nil
}
var keyValUpdate, gapValUpdate bool
oldKeyVal, oldGapVal := decodeValueSet(it.Value(), meta)
keyVal, keyValUpdate = ratchetValue(oldKeyVal, keyVal)
gapVal, gapValUpdate = ratchetValue(oldGapVal, gapVal)
updateVals := keyValUpdate || gapValUpdate
newMeta := meta
updateInit := setInit && !inited
if updateInit {
// If the meta has the cantInit flag set to true, we fail with an
// ErrArenaFull error to force the current goroutine to retry on a
// new page.
if (meta & cantInit) != 0 {
return arenaskl.ErrArenaFull
}
newMeta |= initialized
}
if updateVals {
// If we're updating the values (and maybe the init flag) then we
// need to call it.Set. This can return an ErrArenaFull, which we
// must handle with care.
// Ratchet the max timestamp.
keyTs, gapTs := keyVal.ts, gapVal.ts
if gapTs.Less(keyTs) {
p.ratchetMaxTimestamp(keyTs)
} else {
p.ratchetMaxTimestamp(gapTs)
}
// Remove the hasKey and hasGap flags from the meta. These will be
// replaced below.
newMeta &^= (hasKey | hasGap)
// Update the values, possibly preserving the init bit.
b, valMeta := encodeValueSet(arr[:0], keyVal, gapVal)
newMeta |= valMeta
err := it.Set(b, newMeta)
switch err {
case nil:
// Success.
return nil
case arenaskl.ErrRecordUpdated:
// Record was updated by another thread, so restart ratchet attempt.
continue
case arenaskl.ErrArenaFull:
// The arena was full which means that we were unable to ratchet
// the value of this node. Mark the page as full and make sure
// that the node is moved to the "cantInit" state if it hasn't
// been initialized yet. This is critical because if the node
// was initialized after this, its value set would be relied
// upon to stand on its own even though it would be missing the
// ratcheting we tried to perform here.
atomic.StoreInt32(&p.isFull, 1)
if !inited && (meta&cantInit) == 0 {
err := it.SetMeta(meta | cantInit)
switch err {
case arenaskl.ErrRecordUpdated:
// Record was updated by another thread, so restart
// ratchet attempt.
continue
case arenaskl.ErrArenaFull:
panic(fmt.Sprintf("SetMeta with larger meta should not return %v", err))
}
}
return arenaskl.ErrArenaFull
default:
panic(fmt.Sprintf("unexpected error: %v", err))
}
} else if updateInit {
// If we're only updating the init flag and not the values, we can
// use it.SetMeta instead of it.Set, which avoids allocating new
// chunks in the arena.
err := it.SetMeta(newMeta)
switch err {
case nil:
// Success.
return nil
case arenaskl.ErrRecordUpdated:
// Record was updated by another thread, so restart ratchet attempt.
continue
case arenaskl.ErrArenaFull:
panic(fmt.Sprintf("SetMeta with larger meta should not return %v", err))
default:
panic(fmt.Sprintf("unexpected error: %v", err))
}
} else {
return nil
}
}
}
// maxInRange scans the range of keys between from and to and returns the
// maximum (initialized or uninitialized) value found. When finished, the
// iterator will be positioned the same as if it.Seek(to) had been called.
func (p *sklPage) maxInRange(it *arenaskl.Iterator, from, to []byte, opt rangeOptions) cacheValue {
// Determine the previous gap value. This will move the iterator to the
// first node >= from.
prevGapVal := p.incomingGapVal(it, from)
if !it.Valid() {
// No more nodes.
return prevGapVal
} else if bytes.Equal(it.Key(), from) {
// Found a node at from.
if (it.Meta() & initialized) != 0 {
// The node was initialized. Ignore the previous gap value.
prevGapVal = cacheValue{}
}
} else {
// No node at from. Remove excludeFrom option.
opt &^= excludeFrom
}
// Scan the rest of the way. Notice that we provide the previous gap value.
// This is important for two reasons:
// 1. it will be counted towards the maxVal result.
// 2. it will be used to ratchet uninitialized nodes that the scan sees
// before any initialized nodes.
_, maxVal := p.scanTo(it, to, opt, prevGapVal)
return maxVal
}
// incomingGapVal determines the gap value active at the specified key by first
// scanning backwards to the first initialized node and then scanning forwards
// to the specified key. If there is already a node at key then the previous gap
// value will be returned. When finished, the iterator will be positioned the
// same as if it.Seek(key) had been called.
//
// During forward iteration, if another goroutine inserts a new gap node in the
// interval between the previous node and the original key, then either:
//
// 1. The forward iteration finds it and looks up its gap value. That node's gap
// value now becomes the new "previous gap value", and iteration continues.
//
// 2. The new node is created after the iterator has move past its position. As
// part of node creation, the creator had to scan backwards to find the gap
// value of the previous node. It is guaranteed to find a gap value that is
// >= the gap value found by the original goroutine.
//
// This means that no matter what gets inserted, or when it gets inserted, the
// scanning goroutine is guaranteed to end up with a value that will never
// decrease on future lookups, which is the critical invariant.
func (p *sklPage) incomingGapVal(it *arenaskl.Iterator, key []byte) cacheValue {
// Iterate backwards to the nearest initialized node.
prevInitNode(it)
// Iterate forwards to key, remembering the last gap value.
prevGapVal, _ := p.scanTo(it, key, 0, cacheValue{})
return prevGapVal
}
// scanTo scans from the current iterator position until the key "to". While
// scanning, any uninitialized values are ratcheted with the current gap value,
// which is essential to avoiding ratchet inversions (see the comment on
// ensureInitialized).