Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating httpPort or sqlPort does not update cockroachdb-public service port #498

Open
taroface opened this issue May 14, 2021 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@taroface
Copy link
Contributor

taroface commented May 14, 2021

I deployed a cluster with httpPort: 8081 and was able to access the DB Console on this port. I subsequently changed this back to httpPort: 8080 and this successfully performed a rolling restart of the pods with the new port. However, when running kubectl port-forward service/cockroachdb-public 8080, I got this error:

error: Service cockroachdb-public does not have a service port 8080

Running kubectl get service shows:

cockroachdb-public    ClusterIP   10.3.242.84   <none>        26258/TCP,8081/TCP,26257/TCP   24m

Is there another step that needs to update the service to use the new port?

Note: I was still able to port-forward to 8081, but this quickly threw errors like

E0514 16:50:16.364820   63081 portforward.go:400] an error occurred forwarding 8081 -> 8081: error forwarding port 8081 to pod c86376879927c9d62242ca840a9a4c4d6427fee3b5974e84586e47ac2d88643f, uid : exit status 1: 2021/05/14 20:50:16 socat[94227] E connect(5, AF=2 127.0.0.1:8081, 16): Connection refused

as expected.

This is using the Operator version currently at https://github.com/cockroachdb/cockroach-operator/blob/master/manifests/operator.yaml on GKE and CRDB v20.2.8.

@taroface taroface added the bug Something isn't working label May 14, 2021
@taroface taroface changed the title updating httpPort does not update cockroachdb-public service updating httpPort does not update cockroachdb-public service HTTP port May 14, 2021
@keith-mcclellan
Copy link
Contributor

This also applies to changing the SQL port - we need to update the services when we change ports on the pod configs. @chrislovecnm @udnay We need to get this prioritized ASAP. Is there a workaround (maybe a kubectl patch service ) command that would work or is this a release blocker?

@keith-mcclellan keith-mcclellan changed the title updating httpPort does not update cockroachdb-public service HTTP port updating httpPort or sqlPort does not update cockroachdb-public service HTTP port May 17, 2021
@taroface taroface changed the title updating httpPort or sqlPort does not update cockroachdb-public service HTTP port updating httpPort or sqlPort does not update cockroachdb-public service port May 18, 2021
@keith-mcclellan
Copy link
Contributor

keith-mcclellan commented May 18, 2021

I have a workaround - if you delete ${clustername}-public eg oc delete service crdb-tls-example-public --namespace=cockroachdb after updating the CR with the new port, when the operator recreates the service it gets generated with the new port.

@udnay @taroface I suggest we document this as a known issue with a workaround, and then backlog this issue to be fixed after the release. Thoughts?

fwiw, I also tested manually patching the service, but that was more steps so I think this is cleaner.

@taroface
Copy link
Contributor Author

taroface commented May 18, 2021

@keith-mcclellan @udnay Can we use a red callout where the doc describes changing the port, or would you prefer to have this on the Known Limitations page? https://www.cockroachlabs.com/docs/v21.1/known-limitations.html

@taroface
Copy link
Contributor Author

Added a callout to this file in the open PR: https://github.com/cockroachdb/docs/pull/10578/files

@keith-mcclellan
Copy link
Contributor

we can close when cockroachdb/docs#10578 is merged

@keith-mcclellan
Copy link
Contributor

@keith-mcclellan @udnay Can we use a red callout where the doc describes changing the port, or would you prefer to have this on the Known Limitations page? https://www.cockroachlabs.com/docs/v21.1/known-limitations.html

I think we should call this out in the doc specifically. Can you host this somewhere for a final review @taroface ? I think it looks good but I want to read it formatted. Thanks!

@taroface
Copy link
Contributor Author

taroface commented Jun 1, 2021

@keith-mcclellan
Copy link
Contributor

Callout LGTM thanks @taroface !

@chrislovecnm
Copy link
Contributor

@keith-mcclellan is this a release blocker?

@chrislovecnm
Copy link
Contributor

@keith-mcclellan i am removing release blocker

@chrislovecnm
Copy link
Contributor

@udnay ^

@udnay
Copy link

udnay commented Jun 18, 2021

It's not a release blocker, we can remove the label and put it into the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants