Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize polkit checks from firewall #11033

Open
martinpitt opened this issue Jan 22, 2019 · 1 comment
Open

Generalize polkit checks from firewall #11033

martinpitt opened this issue Jan 22, 2019 · 1 comment

Comments

@martinpitt
Copy link
Member

The firewall page is the first page which does a polkit check for a read-only view of the UI when the logged-in user doesn't have sufficient permissions.

A lot of other pages could use something like this as well. Choose another page where we can use this and move the functionality into pkg/lib

@ancorgs
Copy link

ancorgs commented Aug 24, 2022

The check in the firewall page is certainly a step in the right direction, but please improve it before replicating the model. It introduces a hard dependency on polkit and is not fully precise, I fear. See #17669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants